diff --git a/build/Modules/Umbraco.Build/Umbraco.Build.psm1 b/build/Modules/Umbraco.Build/Umbraco.Build.psm1 index 62ab7f1865..dde1ef6467 100644 --- a/build/Modules/Umbraco.Build/Umbraco.Build.psm1 +++ b/build/Modules/Umbraco.Build/Umbraco.Build.psm1 @@ -239,18 +239,18 @@ function Prepare-Tests # data Write-Host "Copy data files" - if( -Not (Test-Path -Path "$tmp\tests\Packaging" ) ) + if (-Not (Test-Path -Path "$tmp\tests\Packaging" ) ) { Write-Host "Create packaging directory" - New-Item -ItemType directory -Path "$tmp\tests\Packaging" + mkdir "$tmp\tests\Packaging" > $null } Copy-Files "$src\Umbraco.Tests\Packaging\Packages" "*" "$tmp\tests\Packaging\Packages" # required for package install tests - if( -Not (Test-Path -Path "$tmp\tests\bin" ) ) + if (-Not (Test-Path -Path "$tmp\tests\bin" ) ) { Write-Host "Create bin directory" - New-Item -ItemType directory -Path "$tmp\tests\bin" + mkdir "$tmp\tests\bin" > $null } } diff --git a/build/NuSpecs/UmbracoCms.Core.nuspec b/build/NuSpecs/UmbracoCms.Core.nuspec index 549048c91c..476baf2545 100644 --- a/build/NuSpecs/UmbracoCms.Core.nuspec +++ b/build/NuSpecs/UmbracoCms.Core.nuspec @@ -28,7 +28,7 @@ - + diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj index e8b21f01cd..95639145f6 100644 --- a/src/Umbraco.Core/Umbraco.Core.csproj +++ b/src/Umbraco.Core/Umbraco.Core.csproj @@ -43,8 +43,8 @@ ..\packages\AutoMapper.3.3.1\lib\net40\AutoMapper.Net4.dll - - ..\packages\ClientDependency.1.9.2\lib\net45\ClientDependency.Core.dll + + ..\packages\ClientDependency.1.9.4\lib\net45\ClientDependency.Core.dll ..\packages\HtmlAgilityPack.1.4.9.5\lib\Net45\HtmlAgilityPack.dll diff --git a/src/Umbraco.Core/packages.config b/src/Umbraco.Core/packages.config index de911f5515..80ffd9d7cb 100644 --- a/src/Umbraco.Core/packages.config +++ b/src/Umbraco.Core/packages.config @@ -1,7 +1,7 @@ - + diff --git a/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs b/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs index 3c1d4e7c9b..81f7ce30bd 100644 --- a/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs +++ b/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs @@ -29,7 +29,7 @@ namespace Umbraco.Tests.PropertyEditors [Test] public void ImageCropData_Properties_As_Dynamic() { - var sourceObj = cropperJson1.SerializeToCropDataSet(); + var sourceObj = cropperJson1.DeserializeToCropDataSet(); dynamic d = sourceObj; var index = 0; @@ -62,7 +62,7 @@ namespace Umbraco.Tests.PropertyEditors [Test] public void ImageCropFocalPoint_Properties_As_Dynamic() { - var sourceObj = cropperJson1.SerializeToCropDataSet(); + var sourceObj = cropperJson1.DeserializeToCropDataSet(); dynamic d = sourceObj; Assert.AreEqual(sourceObj.FocalPoint.Left, d.FocalPoint.Left); @@ -75,7 +75,7 @@ namespace Umbraco.Tests.PropertyEditors [Test] public void ImageCropDataSet_Properties_As_Dynamic() { - var sourceObj = cropperJson1.SerializeToCropDataSet(); + var sourceObj = cropperJson1.DeserializeToCropDataSet(); dynamic d = sourceObj; Assert.AreEqual(sourceObj.Src, d.Src); @@ -91,7 +91,7 @@ namespace Umbraco.Tests.PropertyEditors [Test] public void ImageCropDataSet_Methods_As_Dynamic() { - var sourceObj = cropperJson1.SerializeToCropDataSet(); + var sourceObj = cropperJson1.DeserializeToCropDataSet(); dynamic d = sourceObj; Assert.AreEqual(sourceObj.HasCrop("thumb"), d.HasCrop("thumb")); @@ -108,7 +108,7 @@ namespace Umbraco.Tests.PropertyEditors public void CanConvertImageCropperDataSetSrcToString() { //cropperJson3 - has not crops - var sourceObj = cropperJson3.SerializeToCropDataSet(); + var sourceObj = cropperJson3.DeserializeToCropDataSet(); var destObj = sourceObj.TryConvertTo(); Assert.IsTrue(destObj.Success); Assert.AreEqual(destObj.Result, "/media/1005/img_0672.jpg"); @@ -118,7 +118,7 @@ namespace Umbraco.Tests.PropertyEditors public void CanConvertImageCropperDataSetJObject() { //cropperJson3 - has not crops - var sourceObj = cropperJson3.SerializeToCropDataSet(); + var sourceObj = cropperJson3.DeserializeToCropDataSet(); var destObj = sourceObj.TryConvertTo(); Assert.IsTrue(destObj.Success); Assert.AreEqual(sourceObj, destObj.Result.ToObject()); @@ -127,7 +127,7 @@ namespace Umbraco.Tests.PropertyEditors [Test] public void CanConvertImageCropperDataSetJsonToString() { - var sourceObj = cropperJson1.SerializeToCropDataSet(); + var sourceObj = cropperJson1.DeserializeToCropDataSet(); var destObj = sourceObj.TryConvertTo(); Assert.IsTrue(destObj.Success); Assert.IsTrue(destObj.Result.DetectIsJson()); @@ -150,7 +150,7 @@ namespace Umbraco.Tests.PropertyEditors var converter = new Umbraco.Web.PropertyEditors.ValueConverters.ImageCropperValueConverter(dataTypeService.Object); var result = converter.ConvertDataToSource(new PublishedPropertyType("test", 0, "test"), val1, false); // does not use type for conversion - var resultShouldMatch = val2.SerializeToCropDataSet(); + var resultShouldMatch = val2.DeserializeToCropDataSet(); if (expected) { Assert.AreEqual(resultShouldMatch, result); @@ -220,7 +220,7 @@ namespace Umbraco.Tests.PropertyEditors [Test] public void GetBaseCropUrlFromModelTest() { - var cropDataSet = cropperJson1.SerializeToCropDataSet(); + var cropDataSet = cropperJson1.DeserializeToCropDataSet(); var urlString = cropDataSet.GetCropUrl("thumb"); Assert.AreEqual("?crop=0.58729977382575338,0.055768992440203169,0,0.32457553600198386&cropmode=percentage&width=100&height=100", urlString); } diff --git a/src/Umbraco.Web.UI.Client/src/common/directives/validation/nodirtycheck.directive.js b/src/Umbraco.Web.UI.Client/src/common/directives/validation/nodirtycheck.directive.js index f027d7a12f..e15f62e8df 100644 --- a/src/Umbraco.Web.UI.Client/src/common/directives/validation/nodirtycheck.directive.js +++ b/src/Umbraco.Web.UI.Client/src/common/directives/validation/nodirtycheck.directive.js @@ -9,9 +9,14 @@ function noDirtyCheck() { restrict: 'A', require: 'ngModel', link: function (scope, elm, attrs, ctrl) { + elm.focus(function () { - ctrl.$pristine = false; + scope.$watch(function() { + ctrl.$pristine = false; + }); }); + + } }; } diff --git a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/iconpicker.html b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/iconpicker.html index 4e482c26b1..f21fdf0b06 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/iconpicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/iconpicker.html @@ -1,7 +1,7 @@ - - - + + + + no-dirty-check /> - - + + - + + No icons were found. + + - + diff --git a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html index 99102fed19..c974cf7adf 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/mediapicker.html @@ -61,22 +61,23 @@ + on-drag-leave="dragLeave()" + on-drag-end="dragLeave()" + on-drag-enter="dragEnter()" + ng-hide="target"> + - - - - + + + @@ -97,7 +98,7 @@ {{item.name}} / - + @@ -114,28 +115,26 @@ - + diff --git a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/membergrouppicker.html b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/membergrouppicker.html index 48302cea02..e2ff9790d5 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/dialogs/membergrouppicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/dialogs/membergrouppicker.html @@ -1,7 +1,7 @@ - + \ No newline at end of file diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/compositions/compositions.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/compositions/compositions.html index 3cc81fdcf6..6759da0fb4 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/compositions/compositions.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/compositions/compositions.html @@ -7,9 +7,10 @@ style="width: 100%" ng-model="searchTerm" class="umb-search-field search-query input-block-level" - localize="placeholder" - placeholder="@placeholders_filter" - umb-auto-focus> + localize="placeholder" + placeholder="@placeholders_filter" + umb-auto-focus + no-dirty-check /> @@ -17,20 +18,17 @@ - - + + - - + + @@ -41,7 +39,7 @@ checklist-model="model.compositeContentTypes" checklist-value="compositeContentType.contentType.alias" ng-change="model.selectCompositeContentType(compositeContentType.contentType)" - ng-disabled="compositeContentType.allowed===false || compositeContentType.inherited"/> + ng-disabled="compositeContentType.allowed===false || compositeContentType.inherited" /> diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/editorpicker/editorpicker.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/editorpicker/editorpicker.html index ceeb27ee42..1f2f3a8759 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/editorpicker/editorpicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/editorpicker/editorpicker.html @@ -1,120 +1,103 @@ - - - - - - - - - - - - - - - - - - - - - - - {{key}} - - + + + + + + + + + + + + + + + {{key}} + + - - - {{ systemDataType.name }} - - - - - - - - - {{key}} - - + + + {{ systemDataType.name }} + + + + + + + + {{key}} + + - - - {{ dataType.name }} - - - - - - - - - - - - - - - - - - - {{key}} - - - - - {{ dataType.name }} - - - - - - - - - - {{key}} - - - - - {{ systemDataType.name }} - - - - - - - - - + + + {{ dataType.name }} + + + + + + + + + + + + + + {{key}} + + + + + {{ dataType.name }} + + + + + + + + + {{key}} + + + + + {{ systemDataType.name }} + + + + + + + - - + model="vm.editorSettingsOverlay" + position="right" + view="vm.editorSettingsOverlay.view"> + diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/iconpicker/iconpicker.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/iconpicker/iconpicker.html index 56b31c8503..d962f8eec4 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/iconpicker/iconpicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/iconpicker/iconpicker.html @@ -10,7 +10,7 @@ localize="placeholder" placeholder="@placeholders_filter" umb-auto-focus - no-dirty-check> + no-dirty-check /> diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/itempicker/itempicker.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/itempicker/itempicker.html index d71352c3d9..aac4830d52 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/itempicker/itempicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/itempicker/itempicker.html @@ -1,25 +1,25 @@ - - + + - - - - {{ availableItem.name }} - - + + + + {{ availableItem.name }} + + diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/macropicker/macropicker.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/macropicker/macropicker.html index 6bcbaad50c..9f9356d85e 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/macropicker/macropicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/macropicker/macropicker.html @@ -13,7 +13,8 @@ class="umb-search-field search-query input-block-level" localize="placeholder" placeholder="@placeholders_filter" - umb-auto-focus /> + umb-auto-focus + no-dirty-check /> @@ -27,9 +28,8 @@ - + There are no macros available to insert @@ -52,9 +52,8 @@ - + There are no parameters for this macro diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/mediaPicker/mediapicker.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/mediaPicker/mediapicker.html index 73b0915161..6ce53e7571 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/mediaPicker/mediapicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/mediaPicker/mediapicker.html @@ -3,159 +3,147 @@ enctype="multipart/form-data" umb-image-upload="options"> - + - + - - + + - - - - + + + + - - - - + + + + - + - - - - Media - / - + + + + Media + / + - - {{item.name}} - / - + + {{item.name}} + / + - - - - + + + + - - - - - + + + + + - - + + - - + + - + - + - + - + - + - - - - + + + + - + - - Preview - + + Preview + - - + + - + - + - - - - + + + + - - - - + + + + - + diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/usergrouppicker/usergrouppicker.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/usergrouppicker/usergrouppicker.html index 665645ad17..4768052844 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/usergrouppicker/usergrouppicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/usergrouppicker/usergrouppicker.html @@ -1,7 +1,6 @@ - + @@ -9,17 +8,18 @@ + ng-model="searchTerm" + class="umb-search-field search-query input-block-level -full-width-input" + localize="placeholder" + placeholder="@placeholders_filter" + umb-auto-focus + no-dirty-check /> - + - + @@ -42,7 +42,7 @@ {{ userGroup.contentStartNode.name }} - + Media start node: @@ -55,9 +55,8 @@ - + No user groups have been added diff --git a/src/Umbraco.Web.UI.Client/src/views/common/overlays/userpicker/userpicker.html b/src/Umbraco.Web.UI.Client/src/views/common/overlays/userpicker/userpicker.html index 8a3300a5a6..517a63f60b 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/overlays/userpicker/userpicker.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/overlays/userpicker/userpicker.html @@ -51,7 +51,7 @@ total-pages="vm.usersOptions.totalPages" on-change="vm.changePageNumber(pageNumber)"> - + diff --git a/src/Umbraco.Web.UI.Client/src/views/components/application/umb-navigation.html b/src/Umbraco.Web.UI.Client/src/views/components/application/umb-navigation.html index d6eb3de3ef..faf32173cc 100644 --- a/src/Umbraco.Web.UI.Client/src/views/components/application/umb-navigation.html +++ b/src/Umbraco.Web.UI.Client/src/views/components/application/umb-navigation.html @@ -1,115 +1,115 @@ - - + + - - + + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - Search results - - - - {{key}} - - - - - - - - {{result.name}} - - - - {{result.subTitle}} - - - - + hotkey="ctrl+space" + id="search-field" + ng-model="searchTerm" + class="umb-search-field search-query search-input" + localize="placeholder" + placeholder="@placeholders_search" + ng-keydown="navigateResults($event)" + no-dirty-check /> + - - + - + + - - + + + + + + + + + + Search results + + + + {{key}} + + + + + + + + {{result.name}} + + + + {{result.subTitle}} + + + + + + + + + + + + + + + + + + + + + - + - - - - - + + + + + + + + + + + {{menuDialogTitle}} + + + + + - - - - - - - - - - - - - {{menuDialogTitle}} - - - - - - - diff --git a/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj b/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj index c3d655f194..b810b9a0ad 100644 --- a/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj +++ b/src/Umbraco.Web.UI/Umbraco.Web.UI.csproj @@ -116,9 +116,8 @@ ..\packages\AutoMapper.3.3.1\lib\net40\AutoMapper.Net4.dll True - - ..\packages\ClientDependency.1.9.2\lib\net45\ClientDependency.Core.dll - True + + ..\packages\ClientDependency.1.9.4\lib\net45\ClientDependency.Core.dll ..\packages\ClientDependency-Mvc5.1.8.0.0\lib\net45\ClientDependency.Core.Mvc.dll diff --git a/src/Umbraco.Web.UI/packages.config b/src/Umbraco.Web.UI/packages.config index 8653059b89..0bcf04d4ce 100644 --- a/src/Umbraco.Web.UI/packages.config +++ b/src/Umbraco.Web.UI/packages.config @@ -1,7 +1,7 @@ - + diff --git a/src/Umbraco.Web.UI/umbraco/config/lang/da.xml b/src/Umbraco.Web.UI/umbraco/config/lang/da.xml index 29068057b1..9be893b8bb 100644 --- a/src/Umbraco.Web.UI/umbraco/config/lang/da.xml +++ b/src/Umbraco.Web.UI/umbraco/config/lang/da.xml @@ -1446,7 +1446,7 @@ Mange hilsner fra Umbraco robotten Dokumenttype Redaktør Uddragsfelt - Fejlet loginforsøg + Fejlede loginforsøg Gå til brugerprofil Tilføj grupper for at tildele adgang og tilladelser Invitér anden bruger @@ -1454,7 +1454,7 @@ Mange hilsner fra Umbraco robotten Sprog Indstil det sprog, du vil se i menuer og dialoger Seneste låst ude dato - Senest login + Seneste login Kodeord sidst ændret Brugernavn Startnode i mediearkivet diff --git a/src/Umbraco.Web.UI/umbraco/dialogs/viewAuditTrail.aspx b/src/Umbraco.Web.UI/umbraco/dialogs/viewAuditTrail.aspx index 4a51de9800..d13bc662c2 100644 --- a/src/Umbraco.Web.UI/umbraco/dialogs/viewAuditTrail.aspx +++ b/src/Umbraco.Web.UI/umbraco/dialogs/viewAuditTrail.aspx @@ -7,6 +7,7 @@ diff --git a/src/Umbraco.Web/ImageCropperBaseExtensions.cs b/src/Umbraco.Web/ImageCropperBaseExtensions.cs index e993559f1e..f30437705e 100644 --- a/src/Umbraco.Web/ImageCropperBaseExtensions.cs +++ b/src/Umbraco.Web/ImageCropperBaseExtensions.cs @@ -13,7 +13,7 @@ namespace Umbraco.Web { internal static class ImageCropperBaseExtensions { - internal static ImageCropDataSet SerializeToCropDataSet(this string json) + internal static ImageCropDataSet DeserializeToCropDataSet(this string json) { var imageCrops = new ImageCropDataSet(); if (json.DetectIsJson()) diff --git a/src/Umbraco.Web/ImageCropperTemplateExtensions.cs b/src/Umbraco.Web/ImageCropperTemplateExtensions.cs index ddf8ee0727..3517da0e49 100644 --- a/src/Umbraco.Web/ImageCropperTemplateExtensions.cs +++ b/src/Umbraco.Web/ImageCropperTemplateExtensions.cs @@ -232,7 +232,7 @@ namespace Umbraco.Web ImageCropDataSet cropDataSet = null; if (string.IsNullOrEmpty(imageCropperValue) == false && imageCropperValue.DetectIsJson() && (imageCropMode == ImageCropMode.Crop || imageCropMode == null)) { - cropDataSet = imageCropperValue.SerializeToCropDataSet(); + cropDataSet = imageCropperValue.DeserializeToCropDataSet(); } return GetCropUrl( imageUrl, cropDataSet, width, height, cropAlias, quality, imageCropMode, diff --git a/src/Umbraco.Web/Umbraco.Web.csproj b/src/Umbraco.Web/Umbraco.Web.csproj index e77c8e167b..a17ef73b15 100644 --- a/src/Umbraco.Web/Umbraco.Web.csproj +++ b/src/Umbraco.Web/Umbraco.Web.csproj @@ -105,9 +105,8 @@ ..\packages\AutoMapper.3.3.1\lib\net40\AutoMapper.Net4.dll True - - ..\packages\ClientDependency.1.9.2\lib\net45\ClientDependency.Core.dll - True + + ..\packages\ClientDependency.1.9.4\lib\net45\ClientDependency.Core.dll ..\packages\dotless.1.5.2\lib\dotless.Core.dll diff --git a/src/Umbraco.Web/WebBootManager.cs b/src/Umbraco.Web/WebBootManager.cs index 793e56dbba..c562570e38 100644 --- a/src/Umbraco.Web/WebBootManager.cs +++ b/src/Umbraco.Web/WebBootManager.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Collections.Specialized; using System.Configuration; +using System.IO; using System.Linq; using System.Web; using System.Web.Configuration; @@ -9,6 +10,7 @@ using System.Web.Http; using System.Web.Http.Dispatcher; using System.Web.Mvc; using System.Web.Routing; +using ClientDependency.Core.CompositeFiles.Providers; using ClientDependency.Core.Config; using Examine.Providers; using Umbraco.Core; @@ -105,16 +107,7 @@ namespace Umbraco.Web _examineStartup = new ExamineStartup(ApplicationContext); _examineStartup.Initialize(); - // Backwards compatibility - set the path and URL type for ClientDependency 1.5.1 [LK] - ClientDependency.Core.CompositeFiles.Providers.XmlFileMapper.FileMapVirtualFolder = "~/App_Data/TEMP/ClientDependency"; - ClientDependency.Core.CompositeFiles.Providers.BaseCompositeFileProcessingProvider.UrlTypeDefault = ClientDependency.Core.CompositeFiles.Providers.CompositeUrlType.Base64QueryStrings; - - var section = ConfigurationManager.GetSection("system.web/httpRuntime") as HttpRuntimeSection; - if (section != null) - { - //set the max url length for CDF to be the smallest of the max query length, max request length - ClientDependency.Core.CompositeFiles.CompositeDependencyHandler.MaxHandlerUrlLength = Math.Min(section.MaxQueryStringLength, section.MaxRequestLength); - } + ConfigureClientDependency(); //set master controller factory ControllerBuilder.Current.SetControllerFactory( @@ -131,14 +124,6 @@ namespace Umbraco.Web ////add the profiling action filter //GlobalFilters.Filters.Add(new ProfilingActionFilter()); - //Register a custom renderer - used to process property editor dependencies - var renderer = new DependencyPathRenderer(); - renderer.Initialize("Umbraco.DependencyPathRenderer", new NameValueCollection - { - { "compositeFileHandlerPath", ClientDependencySettings.Instance.CompositeFileHandlerPath } - }); - ClientDependencySettings.Instance.MvcRendererCollection.Add(renderer); - // Disable the X-AspNetMvc-Version HTTP Header MvcHandler.DisableMvcResponseHeader = true; @@ -275,6 +260,45 @@ namespace Umbraco.Web RoutePluginControllers(); } + private void ConfigureClientDependency() + { + // Backwards compatibility - set the path and URL type for ClientDependency 1.5.1 [LK] + XmlFileMapper.FileMapDefaultFolder = "~/App_Data/TEMP/ClientDependency"; + BaseCompositeFileProcessingProvider.UrlTypeDefault = CompositeUrlType.Base64QueryStrings; + + // Now we need to detect if we are running umbracoLocalTempStorage as EnvironmentTemp and in that case we want to change the CDF file + // location to be there + if (GlobalSettings.LocalTempStorageLocation == LocalTempStorage.EnvironmentTemp) + { + var appDomainHash = HttpRuntime.AppDomainAppId.ToSHA1(); + var cachePath = Path.Combine(Environment.ExpandEnvironmentVariables("%temp%"), "UmbracoData", + //include the appdomain hash is just a safety check, for example if a website is moved from worker A to worker B and then back + // to worker A again, in theory the %temp% folder should already be empty but we really want to make sure that its not + // utilizing an old path + appDomainHash); + + //set the file map and composite file default location to the %temp% location + BaseCompositeFileProcessingProvider.CompositeFilePathDefaultFolder + = XmlFileMapper.FileMapDefaultFolder + = Path.Combine(cachePath, "ClientDependency"); + } + + var section = ConfigurationManager.GetSection("system.web/httpRuntime") as HttpRuntimeSection; + if (section != null) + { + //set the max url length for CDF to be the smallest of the max query length, max request length + ClientDependency.Core.CompositeFiles.CompositeDependencyHandler.MaxHandlerUrlLength = Math.Min(section.MaxQueryStringLength, section.MaxRequestLength); + } + + //Register a custom renderer - used to process property editor dependencies + var renderer = new DependencyPathRenderer(); + renderer.Initialize("Umbraco.DependencyPathRenderer", new NameValueCollection + { + { "compositeFileHandlerPath", ClientDependencySettings.Instance.CompositeFileHandlerPath } + }); + ClientDependencySettings.Instance.MvcRendererCollection.Add(renderer); + } + private void RoutePluginControllers() { var umbracoPath = GlobalSettings.UmbracoMvcArea; diff --git a/src/Umbraco.Web/packages.config b/src/Umbraco.Web/packages.config index 5f8b8aab48..33e4a9c83c 100644 --- a/src/Umbraco.Web/packages.config +++ b/src/Umbraco.Web/packages.config @@ -1,7 +1,7 @@ - + diff --git a/src/Umbraco.Web/umbraco.presentation/umbraco/dialogs/viewAuditTrail.aspx b/src/Umbraco.Web/umbraco.presentation/umbraco/dialogs/viewAuditTrail.aspx index 4a51de9800..d13bc662c2 100644 --- a/src/Umbraco.Web/umbraco.presentation/umbraco/dialogs/viewAuditTrail.aspx +++ b/src/Umbraco.Web/umbraco.presentation/umbraco/dialogs/viewAuditTrail.aspx @@ -7,6 +7,7 @@ diff --git a/src/umbraco.cms/packages.config b/src/umbraco.cms/packages.config index c3987bb55d..10203d0228 100644 --- a/src/umbraco.cms/packages.config +++ b/src/umbraco.cms/packages.config @@ -1,6 +1,6 @@ - + diff --git a/src/umbraco.cms/umbraco.cms.csproj b/src/umbraco.cms/umbraco.cms.csproj index 2b81d1fe92..58b7ae2ee6 100644 --- a/src/umbraco.cms/umbraco.cms.csproj +++ b/src/umbraco.cms/umbraco.cms.csproj @@ -106,8 +106,8 @@ false - - ..\packages\ClientDependency.1.9.2\lib\net45\ClientDependency.Core.dll + + ..\packages\ClientDependency.1.9.4\lib\net45\ClientDependency.Core.dll ..\packages\HtmlAgilityPack.1.4.9.5\lib\Net45\HtmlAgilityPack.dll diff --git a/src/umbraco.controls/packages.config b/src/umbraco.controls/packages.config index eca7107322..f5ede5ac2a 100644 --- a/src/umbraco.controls/packages.config +++ b/src/umbraco.controls/packages.config @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/src/umbraco.controls/umbraco.controls.csproj b/src/umbraco.controls/umbraco.controls.csproj index c562fa35d1..669c96d540 100644 --- a/src/umbraco.controls/umbraco.controls.csproj +++ b/src/umbraco.controls/umbraco.controls.csproj @@ -68,8 +68,8 @@ false - - ..\packages\ClientDependency.1.9.2\lib\net45\ClientDependency.Core.dll + + ..\packages\ClientDependency.1.9.4\lib\net45\ClientDependency.Core.dll diff --git a/src/umbraco.editorControls/packages.config b/src/umbraco.editorControls/packages.config index eca7107322..f5ede5ac2a 100644 --- a/src/umbraco.editorControls/packages.config +++ b/src/umbraco.editorControls/packages.config @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/src/umbraco.editorControls/umbraco.editorControls.csproj b/src/umbraco.editorControls/umbraco.editorControls.csproj index 602187e55a..99f25a9bc7 100644 --- a/src/umbraco.editorControls/umbraco.editorControls.csproj +++ b/src/umbraco.editorControls/umbraco.editorControls.csproj @@ -114,8 +114,8 @@ {651E1350-91B6-44B7-BD60-7207006D7003} Umbraco.Web - - ..\packages\ClientDependency.1.9.2\lib\net45\ClientDependency.Core.dll + + ..\packages\ClientDependency.1.9.4\lib\net45\ClientDependency.Core.dll System