From b3f204a164285e6f7bf1fac06fce9ed5d2ba69c9 Mon Sep 17 00:00:00 2001 From: leekelleher Date: Wed, 29 May 2024 09:54:59 +0100 Subject: [PATCH] Removed redundant `destroy()` methods --- .../repository/extension-collection.repository.ts | 2 -- .../repository/data-type-collection.repository.ts | 2 -- .../repository/dictionary-collection.repository.ts | 6 +++--- .../collection/repository/document-collection.repository.ts | 2 -- .../collection/repository/language-collection.repository.ts | 6 +++--- .../collection/repository/media-collection.repository.ts | 2 -- .../repository/member-group-collection.repository.ts | 6 +++--- .../repository/relation-type-collection.repository.ts | 6 +++--- .../collection/repository/relation-collection.repository.ts | 6 +++--- .../collection/repository/webhook-collection.repository.ts | 6 +++--- 10 files changed, 18 insertions(+), 26 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/collection/repository/extension-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/collection/repository/extension-collection.repository.ts index c867c84bd2..5daaac2129 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/collection/repository/extension-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/collection/repository/extension-collection.repository.ts @@ -43,8 +43,6 @@ export class UmbExtensionCollectionRepository const data = { items, total }; return { data }; } - - destroy(): void {} } export { UmbExtensionCollectionRepository as api }; diff --git a/src/Umbraco.Web.UI.Client/src/packages/data-type/collection/repository/data-type-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/data-type/collection/repository/data-type-collection.repository.ts index 64cc038870..03fe77cb8d 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/data-type/collection/repository/data-type-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/data-type/collection/repository/data-type-collection.repository.ts @@ -37,8 +37,6 @@ export class UmbDataTypeCollectionRepository extends UmbRepositoryBase implement return { data, error, asObservable: () => this.#itemStore!.items(uniques) }; } - - destroy(): void {} } export default UmbDataTypeCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/dictionary/collection/repository/dictionary-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/dictionary/collection/repository/dictionary-collection.repository.ts index 0ee0ed768e..50932d2f60 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/dictionary/collection/repository/dictionary-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/dictionary/collection/repository/dictionary-collection.repository.ts @@ -1,21 +1,21 @@ import type { UmbDictionaryCollectionFilterModel } from '../types.js'; import { UmbDictionaryCollectionServerDataSource } from './dictionary-collection.server.data-source.js'; import type { UmbDictionaryCollectionDataSource } from './types.js'; +import { UmbRepositoryBase } from '@umbraco-cms/backoffice/repository'; import type { UmbCollectionRepository } from '@umbraco-cms/backoffice/collection'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; -export class UmbDictionaryCollectionRepository implements UmbCollectionRepository { +export class UmbDictionaryCollectionRepository extends UmbRepositoryBase implements UmbCollectionRepository { #collectionSource: UmbDictionaryCollectionDataSource; constructor(host: UmbControllerHost) { + super(host); this.#collectionSource = new UmbDictionaryCollectionServerDataSource(host); } async requestCollection(filter: UmbDictionaryCollectionFilterModel) { return this.#collectionSource.getCollection(filter); } - - destroy(): void {} } export default UmbDictionaryCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/repository/document-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/repository/document-collection.repository.ts index 9364d5ab58..9f2989d1b0 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/repository/document-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/repository/document-collection.repository.ts @@ -16,8 +16,6 @@ export class UmbDocumentCollectionRepository extends UmbRepositoryBase implement async requestCollection(query: UmbDocumentCollectionFilterModel) { return this.#collectionSource.getCollection(query); } - - destroy(): void {} } export default UmbDocumentCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/collection/repository/language-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/language/collection/repository/language-collection.repository.ts index 8f2a018756..f91e753859 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/language/collection/repository/language-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/language/collection/repository/language-collection.repository.ts @@ -1,21 +1,21 @@ import type { UmbLanguageCollectionFilterModel } from '../types.js'; import { UmbLanguageCollectionServerDataSource } from './language-collection.server.data-source.js'; import type { UmbLanguageCollectionDataSource } from './types.js'; +import { UmbRepositoryBase } from '@umbraco-cms/backoffice/repository'; import type { UmbCollectionRepository } from '@umbraco-cms/backoffice/collection'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; -export class UmbLanguageCollectionRepository implements UmbCollectionRepository { +export class UmbLanguageCollectionRepository extends UmbRepositoryBase implements UmbCollectionRepository { #collectionSource: UmbLanguageCollectionDataSource; constructor(host: UmbControllerHost) { + super(host); this.#collectionSource = new UmbLanguageCollectionServerDataSource(host); } async requestCollection(filter: UmbLanguageCollectionFilterModel) { return this.#collectionSource.getCollection(filter); } - - destroy(): void {} } export default UmbLanguageCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/collection/repository/media-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/collection/repository/media-collection.repository.ts index ffb21ff449..09d9e19567 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/collection/repository/media-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/collection/repository/media-collection.repository.ts @@ -23,8 +23,6 @@ export class UmbMediaCollectionRepository extends UmbRepositoryBase implements U async requestCollection(query: UmbMediaCollectionFilterModel) { return this.#collectionSource.getCollection(query); } - - destroy(): void {} } export default UmbMediaCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/members/member-group/collection/repository/member-group-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/members/member-group/collection/repository/member-group-collection.repository.ts index 436484d116..886443f4af 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/members/member-group/collection/repository/member-group-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/members/member-group/collection/repository/member-group-collection.repository.ts @@ -1,21 +1,21 @@ import type { UmbMemberGroupCollectionFilterModel } from '../types.js'; import { UmbMemberGroupCollectionServerDataSource } from './member-group-collection.server.data-source.js'; import type { UmbMemberGroupCollectionDataSource } from './types.js'; +import { UmbRepositoryBase } from '@umbraco-cms/backoffice/repository'; import type { UmbCollectionRepository } from '@umbraco-cms/backoffice/collection'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; -export class UmbMemberGroupCollectionRepository implements UmbCollectionRepository { +export class UmbMemberGroupCollectionRepository extends UmbRepositoryBase implements UmbCollectionRepository { #collectionSource: UmbMemberGroupCollectionDataSource; constructor(host: UmbControllerHost) { + super(host); this.#collectionSource = new UmbMemberGroupCollectionServerDataSource(host); } async requestCollection(filter: UmbMemberGroupCollectionFilterModel) { return this.#collectionSource.getCollection(filter); } - - destroy(): void {} } export default UmbMemberGroupCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/relations/relation-types/collection/repository/relation-type-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/relations/relation-types/collection/repository/relation-type-collection.repository.ts index f2222a3bde..abf933da73 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/relations/relation-types/collection/repository/relation-type-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/relations/relation-types/collection/repository/relation-type-collection.repository.ts @@ -1,21 +1,21 @@ import type { UmbRelationTypeCollectionFilterModel } from '../types.js'; import { UmbRelationTypeCollectionServerDataSource } from './relation-type-collection.server.data-source.js'; import type { UmbRelationTypeCollectionDataSource } from './types.js'; +import { UmbRepositoryBase } from '@umbraco-cms/backoffice/repository'; import type { UmbCollectionRepository } from '@umbraco-cms/backoffice/collection'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; -export class UmbRelationTypeCollectionRepository implements UmbCollectionRepository { +export class UmbRelationTypeCollectionRepository extends UmbRepositoryBase implements UmbCollectionRepository { #collectionSource: UmbRelationTypeCollectionDataSource; constructor(host: UmbControllerHost) { + super(host); this.#collectionSource = new UmbRelationTypeCollectionServerDataSource(host); } async requestCollection(filter: UmbRelationTypeCollectionFilterModel) { return this.#collectionSource.getCollection(filter); } - - destroy(): void {} } export default UmbRelationTypeCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/relations/relations/collection/repository/relation-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/relations/relations/collection/repository/relation-collection.repository.ts index c07fd79cd1..465cfc0e29 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/relations/relations/collection/repository/relation-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/relations/relations/collection/repository/relation-collection.repository.ts @@ -1,21 +1,21 @@ import type { UmbRelationCollectionFilterModel } from '../types.js'; import { UmbRelationCollectionServerDataSource } from './relation-collection.server.data-source.js'; import type { UmbRelationCollectionDataSource } from './types.js'; +import { UmbRepositoryBase } from '@umbraco-cms/backoffice/repository'; import type { UmbCollectionRepository } from '@umbraco-cms/backoffice/collection'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; -export class UmbRelationCollectionRepository implements UmbCollectionRepository { +export class UmbRelationCollectionRepository extends UmbRepositoryBase implements UmbCollectionRepository { #collectionSource: UmbRelationCollectionDataSource; constructor(host: UmbControllerHost) { + super(host); this.#collectionSource = new UmbRelationCollectionServerDataSource(host); } async requestCollection(filter: UmbRelationCollectionFilterModel) { return this.#collectionSource.getCollection(filter); } - - destroy(): void {} } export default UmbRelationCollectionRepository; diff --git a/src/Umbraco.Web.UI.Client/src/packages/webhook/collection/repository/webhook-collection.repository.ts b/src/Umbraco.Web.UI.Client/src/packages/webhook/collection/repository/webhook-collection.repository.ts index 96a19f53ca..3b1bf6d9bf 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/webhook/collection/repository/webhook-collection.repository.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/webhook/collection/repository/webhook-collection.repository.ts @@ -1,21 +1,21 @@ import type { UmbWebhookCollectionFilterModel } from '../types.js'; import { UmbWebhookCollectionServerDataSource } from './webhook-collection.server.data-source.js'; import type { UmbWebhookCollectionDataSource } from './types.js'; +import { UmbRepositoryBase } from '@umbraco-cms/backoffice/repository'; import type { UmbCollectionRepository } from '@umbraco-cms/backoffice/collection'; import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api'; -export class UmbWebhookCollectionRepository implements UmbCollectionRepository { +export class UmbWebhookCollectionRepository extends UmbRepositoryBase implements UmbCollectionRepository { #collectionSource: UmbWebhookCollectionDataSource; constructor(host: UmbControllerHost) { + super(host); this.#collectionSource = new UmbWebhookCollectionServerDataSource(host); } async requestCollection(filter: UmbWebhookCollectionFilterModel) { return this.#collectionSource.getCollection(filter); } - - destroy(): void {} } export default UmbWebhookCollectionRepository;