From 577dad86e83b1a2da31a12170867a922676aae37 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Tue, 19 Mar 2024 16:21:23 +0100 Subject: [PATCH 1/2] do not assign to `super` in a change event --- .../packages/core/components/input-color/input-color.element.ts | 2 +- .../components/input-eye-dropper/input-eye-dropper.element.ts | 2 +- .../core/modal/common/icon-picker/icon-picker-modal.element.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-color/input-color.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-color/input-color.element.ts index bd9e1f56b0..44b2794d90 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-color/input-color.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-color/input-color.element.ts @@ -23,7 +23,7 @@ export class UmbInputColorElement extends FormControlMixin(UmbLitElement) { #onChange(event: UUIColorSwatchesEvent) { event.stopPropagation(); - super.value = event.target.value; + this.value = event.target.value; this.dispatchEvent(new UmbChangeEvent()); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-eye-dropper/input-eye-dropper.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-eye-dropper/input-eye-dropper.element.ts index ab7aac9264..4c2a24bc4e 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/components/input-eye-dropper/input-eye-dropper.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/components/input-eye-dropper/input-eye-dropper.element.ts @@ -11,7 +11,7 @@ export class UmbInputEyeDropperElement extends FormControlMixin(UmbLitElement) { #onChange(e: UUIColorPickerChangeEvent) { e.stopPropagation(); - super.value = e.target.value; + this.value = e.target.value; this.dispatchEvent(new CustomEvent('change')); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/icon-picker/icon-picker-modal.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/icon-picker/icon-picker-modal.element.ts index 9e28e70b4e..2f7f07a155 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/icon-picker/icon-picker-modal.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/modal/common/icon-picker/icon-picker-modal.element.ts @@ -1,4 +1,4 @@ -import icons from '../../../icon-registry/icons/icons.json' assert { type: 'json' }; +import icons from '../../../icon-registry/icons/icons.json' with { type: 'json' }; import type { UUIColorSwatchesEvent } from '@umbraco-cms/backoffice/external/uui'; import { css, html, customElement, state, repeat } from '@umbraco-cms/backoffice/external/lit'; From b2b25b1ad9f2e05039610771a8601d3582b2f961 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Tue, 19 Mar 2024 16:21:36 +0100 Subject: [PATCH 2/2] chrome warning: replace 'assert' with 'with' --- .../src/packages/core/icon-registry/icon.registry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon.registry.ts b/src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon.registry.ts index ada1f0e660..85e11428f4 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon.registry.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icon.registry.ts @@ -1,4 +1,4 @@ -import icons from './icons/icons.json' assert { type: 'json' }; +import icons from './icons/icons.json' with { type: 'json' }; import { UUIIconRegistry } from '@umbraco-cms/backoffice/external/uui'; interface UmbIconDescriptor {