From b812f3eaf74599c151f7f9eb3644eb4fa1da2aeb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Mon, 19 Aug 2024 12:33:48 +0200 Subject: [PATCH] lint fix --- .../entity-actions/duplicate/duplicate-document.action.ts | 2 +- .../duplicate/modal/duplicate-document-modal.token.ts | 1 + .../public-access/modal/public-access-modal.token.ts | 1 + .../modals/publish-modal/document-publish-modal.token.ts | 2 ++ .../document-publish-with-descendants-modal.token.ts | 1 + .../documents/modals/rollback/rollback-modal.token.ts | 2 ++ .../modals/save-modal/document-save-modal.token.ts | 2 ++ .../schedule-modal/document-schedule-modal.token.ts | 1 + .../unpublish-modal/document-unpublish-modal.token.ts | 1 + .../documents/documents/recycle-bin/tree/types.ts | 2 ++ .../src/packages/documents/documents/types.ts | 2 ++ .../input-document-granular-user-permission.element.ts | 2 +- .../workspace/actions/save-and-publish.action.ts | 6 +++++- .../documents/documents/workspace/actions/save.action.ts | 6 +++++- .../log-viewer/workspace/logviewer-workspace.context.ts | 4 ++-- .../views/search/components/log-viewer-message.element.ts | 6 +++++- .../components/log-viewer-search-input-modal.element.ts | 1 + .../src/packages/media/media-types/types.ts | 3 +++ .../src/packages/media/media/audit-log/types.ts | 1 + .../media/media/dropzone/dropzone-manager.class.ts | 8 +++----- .../create/media-create-options-modal.token.ts | 1 + .../src/packages/media/media/recycle-bin/tree/types.ts | 2 ++ 22 files changed, 45 insertions(+), 12 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/duplicate-document.action.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/duplicate-document.action.ts index aa07146b23..a0d46d1456 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/duplicate-document.action.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/duplicate-document.action.ts @@ -4,7 +4,7 @@ import { UMB_MODAL_MANAGER_CONTEXT } from '@umbraco-cms/backoffice/modal'; import { UMB_ACTION_EVENT_CONTEXT } from '@umbraco-cms/backoffice/action'; import { UmbEntityActionBase, UmbRequestReloadStructureForEntityEvent } from '@umbraco-cms/backoffice/entity-action'; -export class UmbDuplicateDocumentEntityAction extends UmbEntityActionBase { +export class UmbDuplicateDocumentEntityAction extends UmbEntityActionBase { override async execute() { if (!this.args.unique) throw new Error('Unique is not available'); if (!this.args.entityType) throw new Error('Entity Type is not available'); diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/modal/duplicate-document-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/modal/duplicate-document-modal.token.ts index ecd9639a4b..128d3217c6 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/modal/duplicate-document-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/duplicate/modal/duplicate-document-modal.token.ts @@ -2,6 +2,7 @@ import { UMB_DUPLICATE_DOCUMENT_MODAL_ALIAS } from './constants.js'; import type { UmbEntityModel } from '@umbraco-cms/backoffice/entity'; import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDuplicateDocumentModalData extends UmbEntityModel {} export interface UmbDuplicateDocumentModalValue { diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/public-access/modal/public-access-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/public-access/modal/public-access-modal.token.ts index 92bc0ca089..57f3143a5d 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/public-access/modal/public-access-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/public-access/modal/public-access-modal.token.ts @@ -4,6 +4,7 @@ export interface UmbPublicAccessModalData { unique: string; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbPublicAccessModalValue {} export const UMB_PUBLIC_ACCESS_MODAL = new UmbModalToken( diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-modal/document-publish-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-modal/document-publish-modal.token.ts index f05f650c8f..f90e5e30c8 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-modal/document-publish-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-modal/document-publish-modal.token.ts @@ -2,8 +2,10 @@ import type { UmbDocumentVariantPickerData, UmbDocumentVariantPickerValue } from import { UMB_DOCUMENT_PUBLISH_MODAL_ALIAS } from '../manifests.js'; import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentPublishModalData extends UmbDocumentVariantPickerData {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentPublishModalValue extends UmbDocumentVariantPickerValue {} export const UMB_DOCUMENT_PUBLISH_MODAL = new UmbModalToken( diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-with-descendants-modal/document-publish-with-descendants-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-with-descendants-modal/document-publish-with-descendants-modal.token.ts index 84c5a9b9aa..20067e7a60 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-with-descendants-modal/document-publish-with-descendants-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/publish-with-descendants-modal/document-publish-with-descendants-modal.token.ts @@ -2,6 +2,7 @@ import type { UmbDocumentVariantPickerData, UmbDocumentVariantPickerValue } from import { UMB_DOCUMENT_PUBLISH_WITH_DESCENDANTS_MODAL_ALIAS } from '../manifests.js'; import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentPublishWithDescendantsModalData extends UmbDocumentVariantPickerData {} export interface UmbDocumentPublishWithDescendantsModalValue extends UmbDocumentVariantPickerValue { diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/rollback/rollback-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/rollback/rollback-modal.token.ts index a6174f17e7..1f600049a1 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/rollback/rollback-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/rollback/rollback-modal.token.ts @@ -1,7 +1,9 @@ import { UMB_ROLLBACK_MODAL_ALIAS } from '../manifests.js'; import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbRollbackModalData {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbRollbackModalValue {} export const UMB_ROLLBACK_MODAL = new UmbModalToken( diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/save-modal/document-save-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/save-modal/document-save-modal.token.ts index 6d6a317035..333cc23df0 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/save-modal/document-save-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/save-modal/document-save-modal.token.ts @@ -2,8 +2,10 @@ import type { UmbDocumentVariantPickerData, UmbDocumentVariantPickerValue } from import { UMB_DOCUMENT_SAVE_MODAL_ALIAS } from '../manifests.js'; import { UmbModalToken } from '@umbraco-cms/backoffice/modal'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentSaveModalData extends UmbDocumentVariantPickerData {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentSaveModalValue extends UmbDocumentVariantPickerValue {} export const UMB_DOCUMENT_SAVE_MODAL = new UmbModalToken( diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/schedule-modal/document-schedule-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/schedule-modal/document-schedule-modal.token.ts index 326cc01342..00f33267b7 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/schedule-modal/document-schedule-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/schedule-modal/document-schedule-modal.token.ts @@ -8,6 +8,7 @@ export interface UmbDocumentScheduleSelectionModel { schedule?: ScheduleRequestModel | null; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentScheduleModalData extends UmbDocumentVariantPickerData {} export interface UmbDocumentScheduleModalValue { diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/unpublish-modal/document-unpublish-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/unpublish-modal/document-unpublish-modal.token.ts index f69a224bee..8b9d51827c 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/unpublish-modal/document-unpublish-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/modals/unpublish-modal/document-unpublish-modal.token.ts @@ -6,6 +6,7 @@ export interface UmbDocumentUnpublishModalData extends UmbDocumentVariantPickerD documentUnique?: string; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentUnpublishModalValue extends UmbDocumentVariantPickerValue {} export const UMB_DOCUMENT_UNPUBLISH_MODAL = new UmbModalToken< diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/types.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/types.ts index 1f1d38718b..3db26df828 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/recycle-bin/tree/types.ts @@ -1,6 +1,8 @@ import type { UmbDocumentTreeItemModel } from '../../tree/index.js'; import type { UmbTreeRootModel } from '@umbraco-cms/backoffice/tree'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentRecycleBinTreeItemModel extends UmbDocumentTreeItemModel {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentRecycleBinTreeRootModel extends UmbTreeRootModel {} diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/types.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/types.ts index d1dbf80d16..2d2d184e6e 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/types.ts @@ -36,6 +36,8 @@ export interface UmbDocumentValueModel { value: ValueType; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentVariantOptionModel extends UmbVariantOptionModel {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbDocumentVariantPublishModel extends UmbVariantPublishModel {} diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/user-permissions/input-document-granular-user-permission/input-document-granular-user-permission.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/user-permissions/input-document-granular-user-permission/input-document-granular-user-permission.element.ts index 6ab1ecd687..dc605b47f8 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/user-permissions/input-document-granular-user-permission/input-document-granular-user-permission.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/user-permissions/input-document-granular-user-permission/input-document-granular-user-permission.element.ts @@ -133,7 +133,7 @@ export class UmbInputDocumentGranularUserPermissionElement extends UUIFormContro try { const value = await this.#entityUserPermissionModalContext?.onSubmit(); return value?.allowedVerbs; - } catch (error) { + } catch { throw new Error(); } } diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save-and-publish.action.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save-and-publish.action.ts index 44db8373f4..ee8f35ed94 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save-and-publish.action.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save-and-publish.action.ts @@ -22,7 +22,11 @@ export class UmbDocumentSaveAndPublishWorkspaceAction extends UmbWorkspaceAction allOf: [UMB_USER_PERMISSION_DOCUMENT_UPDATE, UMB_USER_PERMISSION_DOCUMENT_PUBLISH], }, onChange: () => { - condition.permitted ? this.enable() : this.disable(); + if (condition.permitted) { + this.enable(); + } else { + this.disable(); + } }, }); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save.action.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save.action.ts index 3ba7f40d8f..8b9d866f0a 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save.action.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/workspace/actions/save.action.ts @@ -25,7 +25,11 @@ export class UmbDocumentSaveWorkspaceAction extends UmbSubmitWorkspaceAction { oneOf: [UMB_USER_PERMISSION_DOCUMENT_CREATE, UMB_USER_PERMISSION_DOCUMENT_UPDATE], }, onChange: () => { - condition.permitted ? this.enable() : this.disable(); + if (condition.permitted) { + this.enable(); + } else { + this.disable(); + } }, }); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts index 50a8874129..0c1f7c84f2 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/logviewer-workspace.context.ts @@ -214,7 +214,7 @@ export class UmbLogViewerWorkspaceContext extends UmbControllerBase implements U try { this.#savedSearches.update({ items: [...previousSavedSearches, { name, query }] }); await this.#repository.saveSearch({ name, query }); - } catch (err) { + } catch { this.#savedSearches.update({ items: previousSavedSearches }); } } @@ -224,7 +224,7 @@ export class UmbLogViewerWorkspaceContext extends UmbControllerBase implements U try { this.#savedSearches.update({ items: previousSavedSearches.filter((search) => search.name !== name) }); await this.#repository.removeSearch({ name }); - } catch (err) { + } catch { this.#savedSearches.update({ items: previousSavedSearches }); } } diff --git a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-message.element.ts b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-message.element.ts index db7d4d095f..bae596d175 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-message.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-message.element.ts @@ -43,7 +43,11 @@ export class UmbLogViewerMessageElement extends UmbLitElement { protected override updated(_changedProperties: PropertyValueMap | Map): void { if (_changedProperties.has('open')) { - this.open ? this.details.setAttribute('open', 'true') : this.details.removeAttribute('open'); + if (this.open) { + this.details.setAttribute('open', 'true'); + } else { + this.details.removeAttribute('open'); + } } } diff --git a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-search-input-modal.element.ts b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-search-input-modal.element.ts index 898aac6399..d8c2fd89f7 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-search-input-modal.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/log-viewer/workspace/views/search/components/log-viewer-search-input-modal.element.ts @@ -7,6 +7,7 @@ export interface UmbContextSaveSearchModalData { query: string; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbContextSaveSearchModalValue extends SavedLogSearchResponseModel {} @customElement('umb-log-viewer-save-search-modal') diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media-types/types.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media-types/types.ts index 17acb2e86e..c6737451a8 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media-types/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media-types/types.ts @@ -10,8 +10,11 @@ export interface UmbMediaTypeDetailModel extends UmbContentTypeModel { entityType: UmbMediaTypeEntityType; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaTypeAvailableCompositionRequestModel extends UmbContentTypeAvailableCompositionRequestModel {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaTypeCompositionCompatibleModel extends UmbContentTypeCompositionCompatibleModel {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaTypeCompositionReferenceModel extends UmbContentTypeCompositionReferenceModel {} diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/audit-log/types.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/audit-log/types.ts index bc08f8826a..d5c964e4fd 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/audit-log/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/audit-log/types.ts @@ -1,4 +1,5 @@ import type { UmbMediaAuditLogType } from './utils/index.js'; import type { UmbAuditLogModel } from '@umbraco-cms/backoffice/audit-log'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaAuditLogModel extends UmbAuditLogModel {} diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-manager.class.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-manager.class.ts index a5d24d6dd2..8e397f05cd 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-manager.class.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/dropzone/dropzone-manager.class.ts @@ -71,6 +71,7 @@ export class UmbDropzoneManager extends UmbControllerBase { * Allows the user to pick a media type option if multiple types are allowed. * @param files * @param parentUnique + * @returns Promise */ public async createFilesAsMedia(files: Array, parentUnique: string | null) { if (!files.length) return; @@ -118,11 +119,8 @@ export class UmbDropzoneManager extends UmbControllerBase { } notAllowedFiles.forEach((file) => { - try { - throw new Error(`File ${file.name} of type ${file.type} is not allowed here.`); - } catch (e) { - undefined; - } + // TODO: It seems like some implementation(user feedback) is missing here? [NL] + console.error(`File ${file.name} of type ${file.type} is not allowed here.`); }); if (!uploadableFiles.length) return; diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/create/media-create-options-modal.token.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/create/media-create-options-modal.token.ts index ef56265205..7eaae0d330 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/create/media-create-options-modal.token.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/entity-actions/create/media-create-options-modal.token.ts @@ -8,6 +8,7 @@ export interface UmbMediaCreateOptionsModalData { } | null; } +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaCreateOptionsModalValue {} export const UMB_MEDIA_CREATE_OPTIONS_MODAL = new UmbModalToken< diff --git a/src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/types.ts b/src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/types.ts index cc6ea5b8ef..9a67942921 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/types.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/media/media/recycle-bin/tree/types.ts @@ -1,6 +1,8 @@ import type { UmbMediaTreeItemModel } from '../../tree/index.js'; import type { UmbTreeRootModel } from '@umbraco-cms/backoffice/tree'; +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaRecycleBinTreeItemModel extends UmbMediaTreeItemModel {} +// eslint-disable-next-line @typescript-eslint/no-empty-object-type export interface UmbMediaRecycleBinTreeRootModel extends UmbTreeRootModel {}