From b8928bac0b3b316fdec64ccf08457aeb8768871f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Fri, 24 Jan 2025 11:35:52 +0100 Subject: [PATCH] fix observation controller instance property --- .../core/property/components/property/property.element.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/property/components/property/property.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/property/components/property/property.element.ts index 1ead621347..d21f1dcd51 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/property/components/property/property.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/property/components/property/property.element.ts @@ -28,7 +28,6 @@ import { UmbRoutePathAddendumContext } from '@umbraco-cms/backoffice/router'; * The Element will render a Property Editor based on the Property Editor UI alias passed to the element. * This will also render all Property Actions related to the Property Editor UI Alias. */ - @customElement('umb-property') export class UmbPropertyElement extends UmbLitElement { /** @@ -178,6 +177,7 @@ export class UmbPropertyElement extends UmbLitElement { #validationMessageBinder?: UmbBindServerValidationToFormControl; #valueObserver?: UmbObserverController; #configObserver?: UmbObserverController; + #validationMessageObserver?: UmbObserverController; #extensionsController?: UmbExtensionsApiInitializer; constructor() { @@ -293,6 +293,7 @@ export class UmbPropertyElement extends UmbLitElement { // cleanup: this.#valueObserver?.destroy(); this.#configObserver?.destroy(); + this.#validationMessageObserver?.destroy(); this.#controlValidator?.destroy(); oldElement?.removeEventListener('change', this._onPropertyEditorChange as any as EventListener); oldElement?.removeEventListener('property-value-change', this._onPropertyEditorChange as any as EventListener); @@ -330,7 +331,7 @@ export class UmbPropertyElement extends UmbLitElement { }, null, ); - this.#configObserver = this.observe( + this.#validationMessageObserver = this.observe( this.#propertyContext.validationMandatoryMessage, (mandatoryMessage) => { if (mandatoryMessage) {