yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

https://github.com/umbraco/Umbraco-CMS/issues/7469 - Fixed Ambiguous extension method issue by renaming our extension method from Value to GetValue

Browse Source
This commit is contained in:
Bjarke Berg
2020-01-17 13:53:03 +01:00
parent 6637bf520c
commit baef282b10
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/Umbraco.ModelsBuilder.Embedded/PublishedElementExtensions.cs
View File

@@ -17,13 +17,14 @@ namespace Umbraco.Web
/// <summary> /// <summary>
/// Gets the value of a property. /// Gets the value of a property.
/// </summary> /// </summary>
public static TValue GetValue<TModel, TValue>(this TModel model, Expression<Func<TModel, TValue>> property, string culture = null, string segment = null, Fallback fallback = default, TValue defaultValue = default) public static TValue ValueByExpression<TModel, TValue>(this TModel model, Expression<Func<TModel, TValue>> property, string culture = null, string segment = null, Fallback fallback = default, TValue defaultValue = default)
where TModel : IPublishedElement where TModel : IPublishedElement
{ {
var alias = GetAlias(model, property); var alias = GetAlias(model, property);
return model.Value<TValue>(alias, culture, segment, fallback, defaultValue); return model.Value<TValue>(alias, culture, segment, fallback, defaultValue);
} }
//This cannot be public due to ambiguous issue with external ModelsBuilder if we do not rename.
private static string GetAlias<TModel, TValue>(TModel model, Expression<Func<TModel, TValue>> property) private static string GetAlias<TModel, TValue>(TModel model, Expression<Func<TModel, TValue>> property)
{ {
if (property.NodeType != ExpressionType.Lambda) if (property.NodeType != ExpressionType.Lambda)