diff --git a/src/Umbraco.Core/Services/ConflictingPackageContentFinder.cs b/src/Umbraco.Core/Packaging/ConflictingPackageContentFinder.cs similarity index 96% rename from src/Umbraco.Core/Services/ConflictingPackageContentFinder.cs rename to src/Umbraco.Core/Packaging/ConflictingPackageContentFinder.cs index be2e9a03a0..0188c446d4 100644 --- a/src/Umbraco.Core/Services/ConflictingPackageContentFinder.cs +++ b/src/Umbraco.Core/Packaging/ConflictingPackageContentFinder.cs @@ -2,8 +2,9 @@ using System.Linq; using System.Xml.Linq; using Umbraco.Core.Models; +using Umbraco.Core.Services; -namespace Umbraco.Core.Services +namespace Umbraco.Core.Packaging { public class ConflictingPackageContentFinder : IConflictingPackageContentFinder { diff --git a/src/Umbraco.Core/Services/IConflictingPackageContentFinder.cs b/src/Umbraco.Core/Packaging/IConflictingPackageContentFinder.cs similarity index 88% rename from src/Umbraco.Core/Services/IConflictingPackageContentFinder.cs rename to src/Umbraco.Core/Packaging/IConflictingPackageContentFinder.cs index 88b6e0dd34..5842e978b4 100644 --- a/src/Umbraco.Core/Services/IConflictingPackageContentFinder.cs +++ b/src/Umbraco.Core/Packaging/IConflictingPackageContentFinder.cs @@ -1,7 +1,7 @@ using System.Xml.Linq; using Umbraco.Core.Models; -namespace Umbraco.Core.Services +namespace Umbraco.Core.Packaging { public interface IConflictingPackageContentFinder { diff --git a/src/Umbraco.Core/Services/PackagingService.cs b/src/Umbraco.Core/Services/PackagingService.cs index f685426d4a..db7eb357a5 100644 --- a/src/Umbraco.Core/Services/PackagingService.cs +++ b/src/Umbraco.Core/Services/PackagingService.cs @@ -1575,14 +1575,16 @@ namespace Umbraco.Core.Services internal IPackageInstallation PackageInstallation { + //NOTE The PackageInstallation class should be passed as IPackageInstallation through the + //constructor (probably as an overload to avoid breaking stuff), so that its extendable. + // NOTE COMMENT: But is is not a service? and all other parced in constructor is services... private get { return _packageInstallation ?? new PackageInstallation(this, _macroService, _fileService, new PackageExtraction()); } set { _packageInstallation = value; } - - } internal InstallationSummary InstallPackage(string packageFilePath, int userId = 0) { + //TODO Add events ? return PackageInstallation.InstallPackage(packageFilePath, userId); } diff --git a/src/Umbraco.Core/Services/ServiceContext.cs b/src/Umbraco.Core/Services/ServiceContext.cs index a2bee22c85..c32160f5f0 100644 --- a/src/Umbraco.Core/Services/ServiceContext.cs +++ b/src/Umbraco.Core/Services/ServiceContext.cs @@ -31,7 +31,7 @@ namespace Umbraco.Core.Services private Lazy _memberTypeService; private Lazy _memberGroupService; private Lazy _notificationService; - + /// /// public ctor - will generally just be used for unit testing /// diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj index 5c76d2e0bb..8f665a55ab 100644 --- a/src/Umbraco.Core/Umbraco.Core.csproj +++ b/src/Umbraco.Core/Umbraco.Core.csproj @@ -1045,7 +1045,7 @@ - + @@ -1060,7 +1060,7 @@ - +