yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v9: Throw error on duplicate routes (#11774)

Browse Source 
* Add conflicting route service and check

* Added testclass

* Cleanup

* Update src/Umbraco.Web.BackOffice/Services/ConflictingRouteService.cs

Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>

* Implemented out variable

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
This commit is contained in:
Nikolaj Geisle
2021-12-22 13:03:38 +01:00
committed by GitHub
parent 1af09c7f13
commit bc6d8b5ece
6 changed files with 93 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/Umbraco.Tests.Integration/Testing/TestConflictingRouteService.cs Normal file
View File

@@ -0,0 +1,14 @@
using System;
using Umbraco.Cms.Core.Services;
namespace Umbraco.Cms.Tests.Integration.Testing
{
public class TestConflictingRouteService : IConflictingRouteService
{
public bool HasConflictingRoutes(out string controllername)
{
controllername = string.Empty;
return false;
}
}
}

3
tests/Umbraco.Tests.Integration/Testing/UmbracoIntegrationTest.cs
View File

@@ -201,6 +201,9 @@ namespace Umbraco.Cms.Tests.Integration.Testing
IWebHostEnvironment webHostEnvironment = TestHelper.GetWebHostEnvironment();
services.AddRequiredNetCoreServices(TestHelper, webHostEnvironment);
// We register this service because we need it for IRuntimeState, if we don't this breaks 900 tests
services.AddSingleton<IConflictingRouteService, TestConflictingRouteService>();
// Add it!
Core.Hosting.IHostingEnvironment hostingEnvironment = TestHelper.GetHostingEnvironment();
TypeLoader typeLoader = services.AddTypeLoader(