From bcec927e647e670fc5cd925609b98b2260126724 Mon Sep 17 00:00:00 2001 From: Lee Kelleher Date: Tue, 2 Dec 2025 17:04:19 +0000 Subject: [PATCH] Modal: Remove unused `uui-dialog` element in modal component (#21030) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit refactor(backoffice): remove unused uui-dialog element in modal component Remove dead code that created an unnecessary uui-dialog element inside uui-modal-dialog. The uui-modal-dialog component already manages its own internal dialog element, making the manual creation redundant. This aligns the dialog implementation with the sidebar implementation pattern, where container elements manage their own internal structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude --- .../src/packages/core/modal/component/modal.element.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal.element.ts index e9067ba9cb..bb392924f0 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/modal/component/modal.element.ts @@ -10,7 +10,6 @@ import { UmbBasicState, type UmbObserverController } from '@umbraco-cms/backoffi import { UUIModalCloseEvent, type UUIModalElement, - type UUIDialogElement, type UUIModalDialogElement, type UUIModalSidebarElement, type UUIModalSidebarSize, @@ -127,8 +126,6 @@ export class UmbModalElement extends UmbLitElement { #createDialogElement() { const modalDialogElement = document.createElement('uui-modal-dialog'); - const dialogElement: UUIDialogElement = document.createElement('uui-dialog'); - modalDialogElement.appendChild(dialogElement); return modalDialogElement; }