From be2a105fc21b33bf8d55d51a40b5a6d7da0c2b33 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Wed, 11 Jan 2023 16:23:14 +0100 Subject: [PATCH] fix errors as listed by eslint-plugin-wc --- .../collection-view-media-grid.element.ts | 47 ++++++++++++------- 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/collection/views/collection-view-media-grid.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/collection/views/collection-view-media-grid.element.ts index 73f4f93dfb..52d943758a 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/collection/views/collection-view-media-grid.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/collection/views/collection-view-media-grid.element.ts @@ -74,23 +74,36 @@ export class UmbCollectionViewsMediaGridElement extends UmbLitElement { constructor() { super(); - document.addEventListener('dragenter', () => { - this.toggleAttribute('dragging', true); - }); - document.addEventListener('dragleave', () => { - this.toggleAttribute('dragging', false); - }); - document.addEventListener('drop', (e) => { - e.preventDefault(); - this.toggleAttribute('dragging', false); - }); + document.addEventListener('dragenter', this._handleDragEnter.bind(this)); + document.addEventListener('dragleave', this._handleDragLeave.bind(this)); + document.addEventListener('drop', this._handleDrop.bind(this)); this.consumeContext('umbCollectionContext', (instance) => { - console.log("umbCollectionContext", instance) + console.log('umbCollectionContext', instance); this._collectionContext = instance; this._observeCollectionContext(); }); } + disconnectedCallback(): void { + super.disconnectedCallback(); + document.removeEventListener('dragenter', this._handleDragEnter.bind(this)); + document.removeEventListener('dragleave', this._handleDragLeave.bind(this)); + document.removeEventListener('drop', this._handleDrop.bind(this)); + } + + private _handleDragEnter() { + this.toggleAttribute('dragging', true); + } + + private _handleDragLeave() { + this.toggleAttribute('dragging', false); + } + + private _handleDrop(e: DragEvent) { + e.preventDefault(); + this.toggleAttribute('dragging', false); + } + private _observeCollectionContext() { if (!this._collectionContext) return; @@ -144,11 +157,13 @@ export class UmbCollectionViewsMediaGridElement extends UmbLitElement { label="Drop files here" accept="">
- ${this._mediaItems ? repeat( - this._mediaItems, - (file, index) => file.key + index, - (file) => this._renderMediaItem(file) - ) : ''} + ${this._mediaItems + ? repeat( + this._mediaItems, + (file, index) => file.key + index, + (file) => this._renderMediaItem(file) + ) + : ''}
`; }