From be6979d710cef4f7609134343c716cd676076dc9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= <niels.lyngso@gmail.com>
Date: Thu, 1 Jun 2023 11:33:33 +0200
Subject: [PATCH] rename to settings

---
 .../document-types/workspace/manifests.ts        | 16 ++++++++--------
 ...ument-type-workspace-view-edit-tab.element.ts |  8 ++++++--
 ...ment-type-workspace-view-settings.element.ts} | 16 ++++++++++------
 ...ment-type-workspace-view-structure.element.ts | 15 ++++++++-------
 4 files changed, 32 insertions(+), 23 deletions(-)
 rename src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/{details/document-type-workspace-view-details.element.ts => settings/document-type-workspace-view-settings.element.ts} (89%)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/manifests.ts
index 219a2d9ca1..1188c3f5a2 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/manifests.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/manifests.ts
@@ -36,7 +36,7 @@ const workspaceEditorViews: Array<ManifestWorkspaceEditorView> = [
 		alias: 'Umb.WorkspaceView.DocumentType.Structure',
 		name: 'Document Type Workspace Structure View',
 		loader: () => import('./views/structure/document-type-workspace-view-structure.element.js'),
-		weight: 100,
+		weight: 800,
 		meta: {
 			label: 'Structure',
 			pathname: 'structure',
@@ -48,13 +48,13 @@ const workspaceEditorViews: Array<ManifestWorkspaceEditorView> = [
 	},
 	{
 		type: 'workspaceEditorView',
-		alias: 'Umb.WorkspaceView.DocumentType.Permissions',
-		name: 'Document Type Workspace Permissions View',
-		loader: () => import('./views/details/document-type-workspace-view-details.element.js'),
-		weight: 100,
+		alias: 'Umb.WorkspaceView.DocumentType.Settings',
+		name: 'Document Type Workspace Settings View',
+		loader: () => import('./views/settings/document-type-workspace-view-settings.element.js'),
+		weight: 600,
 		meta: {
-			label: 'Details',
-			pathname: 'details',
+			label: 'Settings',
+			pathname: 'settings',
 			icon: 'umb:settings',
 		},
 		conditions: {
@@ -66,7 +66,7 @@ const workspaceEditorViews: Array<ManifestWorkspaceEditorView> = [
 		alias: 'Umb.WorkspaceView.DocumentType.Templates',
 		name: 'Document Type Workspace Templates View',
 		loader: () => import('./views/templates/document-type-workspace-view-templates.element.js'),
-		weight: 100,
+		weight: 400,
 		meta: {
 			label: 'Templates',
 			pathname: 'templates',
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts
index 962095effb..f9a8342735 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/design/document-type-workspace-view-edit-tab.element.ts
@@ -87,7 +87,7 @@ export class UmbDocumentTypeWorkspaceViewEditTabElement extends UmbLitElement {
 			${repeat(
 				this._groups,
 				(group) => group.name,
-				(group) => html`<uui-box .headline=${group.name || ''}>
+				(group) => html` <uui-box .headline=${group.name || ''}>
 					<umb-document-type-workspace-view-edit-properties
 						container-id=${group.id}
 						container-type="Group"
@@ -103,7 +103,11 @@ export class UmbDocumentTypeWorkspaceViewEditTabElement extends UmbLitElement {
 		css`
 			:host {
 				display: block;
-				padding: var(--uui-size-layout-1);
+				margin: var(--uui-size-layout-1);
+				padding-bottom: var(--uui-size-layout-1); // To enforce some distance to the bottom of the scroll-container.
+			}
+			uui-box {
+				margin-top: var(--uui-size-layout-1);
 			}
 
 			#add {
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/details/document-type-workspace-view-details.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/settings/document-type-workspace-view-settings.element.ts
similarity index 89%
rename from src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/details/document-type-workspace-view-details.element.ts
rename to src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/settings/document-type-workspace-view-settings.element.ts
index 568e5a4daa..82e4c6a333 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/details/document-type-workspace-view-details.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/settings/document-type-workspace-view-settings.element.ts
@@ -6,8 +6,8 @@ import { UmbLitElement } from '@umbraco-cms/internal/lit-element';
 import { UMB_ENTITY_WORKSPACE_CONTEXT } from '@umbraco-cms/backoffice/workspace';
 import { UmbWorkspaceEditorViewExtensionElement } from '@umbraco-cms/backoffice/extension-registry';
 
-@customElement('umb-document-type-workspace-view-details')
-export class UmbDocumentTypeWorkspaceViewDetailsElement
+@customElement('umb-document-type-workspace-view-settings')
+export class UmbDocumentTypeWorkspaceViewSettingsElement
 	extends UmbLitElement
 	implements UmbWorkspaceEditorViewExtensionElement
 {
@@ -45,7 +45,7 @@ export class UmbDocumentTypeWorkspaceViewDetailsElement
 
 	render() {
 		return html`
-			<uui-box headline="Data configuration">
+			<uui-box headline="Data variations">
 				<umb-workspace-property-layout alias="VaryByCulture" label="Allow vary by culture">
 					<div slot="description">Allow editors to create content of different languages.</div>
 					<div slot="editor">
@@ -105,7 +105,11 @@ export class UmbDocumentTypeWorkspaceViewDetailsElement
 		css`
 			:host {
 				display: block;
-				padding: var(--uui-size-layout-1);
+				margin: var(--uui-size-layout-1);
+				padding-bottom: var(--uui-size-layout-1); // To enforce some distance to the bottom of the scroll-container.
+			}
+			uui-box {
+				margin-top: var(--uui-size-layout-1);
 			}
 
 			uui-label,
@@ -121,10 +125,10 @@ export class UmbDocumentTypeWorkspaceViewDetailsElement
 	];
 }
 
-export default UmbDocumentTypeWorkspaceViewDetailsElement;
+export default UmbDocumentTypeWorkspaceViewSettingsElement;
 
 declare global {
 	interface HTMLElementTagNameMap {
-		'umb-document-type-workspace-view-details': UmbDocumentTypeWorkspaceViewDetailsElement;
+		'umb-document-type-workspace-view-settings': UmbDocumentTypeWorkspaceViewSettingsElement;
 	}
 }
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/structure/document-type-workspace-view-structure.element.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/structure/document-type-workspace-view-structure.element.ts
index 45a71d1ad5..5eaffe6831 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/structure/document-type-workspace-view-structure.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/document-types/workspace/views/structure/document-type-workspace-view-structure.element.ts
@@ -76,12 +76,9 @@ export class UmbDocumentTypeWorkspaceViewStructureElement
 				</umb-workspace-property-layout>
 			</uui-box>
 			<uui-box headline="Presentation">
-				<umb-workspace-property-layout alias="Root" label="Collection">
-					<div slot="description">
-						Use this document as a collection, displaying its children in a Collection View. This could be a list or a
-						table.
-					</div>
-					<div slot="editor"><uui-toggle label="Present as a Collection"></uui-toggle></div>
+				<umb-workspace-property-layout alias="Root" label="Collection view">
+					<div slot="description">Provides an overview of child content and hides it in the tree.</div>
+					<div slot="editor"><uui-toggle label="Display children in a Collection view"></uui-toggle></div>
 				</umb-workspace-property-layout>
 			</uui-box>
 		`;
@@ -92,7 +89,11 @@ export class UmbDocumentTypeWorkspaceViewStructureElement
 		css`
 			:host {
 				display: block;
-				padding: var(--uui-size-layout-1);
+				margin: var(--uui-size-layout-1);
+				padding-bottom: var(--uui-size-layout-1); // To enforce some distance to the bottom of the scroll-container.
+			}
+			uui-box {
+				margin-top: var(--uui-size-layout-1);
 			}
 			uui-label,
 			umb-property-editor-ui-number {