IsFrontEndUmbracoRequest as ext method instead, makes IUmbracoContext IDisposable since it has a Dispose method

This commit is contained in:
Shannon
2020-12-22 13:32:12 +11:00
parent 57020b4778
commit c074a4d7d4
7 changed files with 21 additions and 21 deletions

View File

@@ -73,9 +73,11 @@ namespace Umbraco.Web.Common.Middleware
_backofficeSecurityFactory.EnsureBackOfficeSecurity(); // Needs to be before UmbracoContext, TODO: Why?
UmbracoContextReference umbracoContextReference = _umbracoContextFactory.EnsureUmbracoContext();
bool isFrontEndRequest = umbracoContextReference.UmbracoContext.IsFrontEndUmbracoRequest();
try
{
if (umbracoContextReference.UmbracoContext.IsFrontEndUmbracoRequest)
if (isFrontEndRequest)
{
LogHttpRequest.TryGetCurrentHttpRequestId(out Guid httpRequestId, _requestCache);
_logger.LogTrace("Begin request [{HttpRequestId}]: {RequestUrl}", httpRequestId, requestUri);
@@ -104,7 +106,7 @@ namespace Umbraco.Web.Common.Middleware
}
finally
{
if (umbracoContextReference.UmbracoContext.IsFrontEndUmbracoRequest)
if (isFrontEndRequest)
{
LogHttpRequest.TryGetCurrentHttpRequestId(out var httpRequestId, _requestCache);
_logger.LogTrace("End Request [{HttpRequestId}]: {RequestUrl} ({RequestDuration}ms)", httpRequestId, requestUri, DateTime.Now.Subtract(umbracoContextReference.UmbracoContext.ObjectCreated).TotalMilliseconds);