Merge pull request #1882 from umbraco/chore/fixing-cyclic-dependencies

Chore: fixing cyclic dependencies continued

src/Umbraco.Web.UI.Client/src/packages/core/entry-point.ts

@@ -6,7 +6,6 @@ import { UmbNotificationContext } from '@umbraco-cms/backoffice/notification';
 import { UmbModalManagerContext } from '@umbraco-cms/backoffice/modal';
 import { UmbExtensionsApiInitializer, type UmbEntryPointOnInit } from '@umbraco-cms/backoffice/extension-api';
 
-// TODO temp relative import until modules ship a component sub module
 import './menu/components/index.js';
 import './extension-registry/components/index.js';
 

src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/conditions/menu-alias.condition.ts

@@ -1,4 +1,4 @@
-import { UMB_MENU_CONTEXT } from '../../menu/menu.context.js';
+import { UMB_MENU_CONTEXT } from '../../menu/components/menu/menu.context.js';
 import { UmbConditionBase } from './condition-base.controller.js';
 import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
 import type {

src/Umbraco.Web.UI.Client/src/packages/core/menu/components/index.ts

@@ -1,2 +1,3 @@
+export * from './menu/index.js';
 export * from './menu-item/index.js';
 export * from './menu-item-layout/index.js';

src/Umbraco.Web.UI.Client/src/packages/core/menu/components/menu/index.ts

@@ -0,0 +1,2 @@
+export * from './menu.element.js';
+export * from './menu.context.js';

src/Umbraco.Web.UI.Client/src/packages/core/menu/components/menu/menu.context.ts

@@ -1,4 +1,4 @@
-import type { ManifestMenu } from '../extension-registry/models/index.js';
+import type { ManifestMenu } from '@umbraco-cms/backoffice/extension-registry';
 import { UmbContextToken } from '@umbraco-cms/backoffice/context-api';
 import { UmbDeepState } from '@umbraco-cms/backoffice/observable-api';
 

src/Umbraco.Web.UI.Client/src/packages/core/menu/components/menu/menu.element.ts

@@ -2,7 +2,7 @@ import { html, customElement, property } from '@umbraco-cms/backoffice/external/
 import type { ManifestMenu, ManifestMenuItem } from '@umbraco-cms/backoffice/extension-registry';
 import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
 
-import './components/menu-item/menu-item-default.element.js';
+import '../menu-item/menu-item-default.element.js';
 
 @customElement('umb-menu')
 export class UmbMenuElement extends UmbLitElement {

src/Umbraco.Web.UI.Client/src/packages/core/menu/index.ts

@@ -1,6 +1,4 @@
 export * from './components/index.js';
-export * from './menu.element.js';
-export * from './menu.context.js';
 export * from './menu-tree-structure-workspace-context-base.js';
 export * from './menu-variant-tree-structure-workspace-context-base.js';
 export * from './types.js';

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/components/ref-property-editor-ui/ref-property-editor-ui.element.ts

@@ -1,4 +1,4 @@
-import { UMB_PROPERTY_EDITOR_SCHEMA_ALIAS_DEFAULT } from '@umbraco-cms/backoffice/property-editor';
+import { UMB_PROPERTY_EDITOR_SCHEMA_ALIAS_DEFAULT } from '../../constants.js';
 import { UUIRefNodeElement } from '@umbraco-cms/backoffice/external/uui';
 import { html, customElement, property } from '@umbraco-cms/backoffice/external/lit';
 

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/constants.ts

@@ -0,0 +1 @@
+export const UMB_PROPERTY_EDITOR_SCHEMA_ALIAS_DEFAULT = 'Umbraco.Label';

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/index.ts

@@ -1,5 +1,4 @@
 export * from './components/index.js';
 export * from './config/index.js';
 export * from './events/index.js';
-
-export const UMB_PROPERTY_EDITOR_SCHEMA_ALIAS_DEFAULT = 'Umbraco.Label';
+export * from './constants.js';

src/Umbraco.Web.UI.Client/src/packages/core/section/section-sidebar-menu-with-entity-actions/section-sidebar-menu-with-entity-actions.element.ts

@@ -2,12 +2,9 @@ import { UmbSectionSidebarMenuElement } from '../section-sidebar-menu/section-si
 import { css, html, customElement } from '@umbraco-cms/backoffice/external/lit';
 import type {
 	ManifestSectionSidebarAppMenuWithEntityActionsKind,
-	UmbBackofficeManifestKind} from '@umbraco-cms/backoffice/extension-registry';
-import {
-	umbExtensionsRegistry,
+	UmbBackofficeManifestKind,
 } from '@umbraco-cms/backoffice/extension-registry';
-
-import '../../menu/menu.element.js';
+import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
 
 const manifestWithEntityActions: UmbBackofficeManifestKind = {
 	type: 'kind',

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/variant-selector/index.ts

@@ -1 +0,0 @@
-export * from './variant-selector.element.js';

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/variant-selector/variant-selector.stories.ts

@@ -1,15 +0,0 @@
-import type { Meta, StoryObj } from '@storybook/web-components';
-import './variant-selector.element.js';
-import type { UmbVariantSelectorElement } from './variant-selector.element.js';
-
-const meta: Meta<UmbVariantSelectorElement> = {
-	title: 'Components/Variant Selector',
-	component: 'umb-variant-selector',
-};
-
-export default meta;
-type Story = StoryObj<UmbVariantSelectorElement>;
-
-export const Overview: Story = {
-	args: {},
-};

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-action/common/submit/submit.action.ts

@@ -1,6 +1,7 @@
-import type { UmbSubmittableWorkspaceContext } from '../../../../contexts/tokens/submittable-workspace-context.interface.js';
+import { UMB_SUBMITTABLE_WORKSPACE_CONTEXT } from '../../../../contexts/tokens/index.js';
+import type { UmbSubmittableWorkspaceContext } from '../../../../contexts/tokens/index.js';
+import type { UmbWorkspaceActionArgs } from '../../types.js';
 import { UmbWorkspaceActionBase } from '../../workspace-action-base.controller.js';
-import { UMB_SUBMITTABLE_WORKSPACE_CONTEXT, type UmbWorkspaceActionArgs } from '@umbraco-cms/backoffice/workspace';
 import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
 
 export class UmbSubmitWorkspaceAction extends UmbWorkspaceActionBase<UmbSubmittableWorkspaceContext> {

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-entity-action-menu/workspace-entity-action-menu.element.ts

@@ -1,8 +1,9 @@
+import { UMB_ENTITY_WORKSPACE_CONTEXT } from '../../contexts/index.js';
+import type { UmbWorkspaceUniqueType } from '../../types.js';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
 import { css, html, customElement, state, nothing, query } from '@umbraco-cms/backoffice/external/lit';
 import type { UmbActionExecutedEvent } from '@umbraco-cms/backoffice/event';
 import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
-import { UMB_ENTITY_WORKSPACE_CONTEXT, type UmbWorkspaceUniqueType } from '@umbraco-cms/backoffice/workspace';
 import type { UUIPopoverContainerElement } from '@umbraco-cms/backoffice/external/uui';
 @customElement('umb-workspace-entity-action-menu')
 export class UmbWorkspaceEntityActionMenuElement extends UmbLitElement {

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts

@@ -1,4 +1,6 @@
-import { UmbVariantId } from '../../../variant/variant-id.class.js';
+import type { ActiveVariant } from '../../controllers/index.js';
+import { UMB_WORKSPACE_SPLIT_VIEW_CONTEXT } from './workspace-split-view.context.js';
+import { UmbVariantId } from '@umbraco-cms/backoffice/variant';
 import { UMB_PROPERTY_DATASET_CONTEXT, isNameablePropertyDatasetContext } from '@umbraco-cms/backoffice/property';
 import {
 	type UUIInputElement,
@@ -6,7 +8,6 @@ import {
 	type UUIPopoverContainerElement,
 } from '@umbraco-cms/backoffice/external/uui';
 import { css, html, nothing, customElement, state, query } from '@umbraco-cms/backoffice/external/lit';
-import { UMB_WORKSPACE_SPLIT_VIEW_CONTEXT, type ActiveVariant } from '@umbraco-cms/backoffice/workspace';
 import { UmbLitElement, umbFocus } from '@umbraco-cms/backoffice/lit-element';
 import { DocumentVariantStateModel } from '@umbraco-cms/backoffice/external/backend-api';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
@@ -22,8 +23,9 @@ type UmbDocumentVariantOption = {
 
 type UmbDocumentVariantOptions = Array<UmbDocumentVariantOption>;
 
-@customElement('umb-variant-selector')
-export class UmbVariantSelectorElement extends UmbLitElement {
+const elementName = 'umb-workspace-split-view-variant-selector';
+@customElement(elementName)
+export class UmbWorkspaceSplitViewVariantSelectorElement extends UmbLitElement {
 	@query('#variant-selector-popover')
 	private _popoverElement?: UUIPopoverContainerElement;
 
@@ -407,10 +409,8 @@ export class UmbVariantSelectorElement extends UmbLitElement {
 	];
 }
 
-export default UmbVariantSelectorElement;
-
 declare global {
 	interface HTMLElementTagNameMap {
-		'umb-variant-selector': UmbVariantSelectorElement;
+		[elementName]: UmbWorkspaceSplitViewVariantSelectorElement;
 	}
 }

src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts

@@ -2,7 +2,10 @@ import { UmbWorkspaceSplitViewContext } from './workspace-split-view.context.js'
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
 import { css, html, customElement, property, ifDefined } from '@umbraco-cms/backoffice/external/lit';
 import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
-import '../variant-selector/index.js';
+
+// import local components
+import './workspace-split-view-variant-selector.element.js';
+
 /**
  *
  * Example. Document Workspace would use a Variant-component(variant component would talk directly to the workspace-context)
@@ -38,7 +41,7 @@ export class UmbWorkspaceSplitViewElement extends UmbLitElement {
 				.hideNavigation=${!this.displayNavigation}
 				.enforceNoFooter=${true}>
 				<div id="header" slot="header">
-					<umb-variant-selector></umb-variant-selector>
+					<umb-workspace-split-view-variant-selector></umb-workspace-split-view-variant-selector>
 				</div>
 				${this.displayNavigation
 					? html`<umb-workspace-entity-action-menu slot="action-menu"></umb-workspace-entity-action-menu>`

src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/culture-and-hostnames/modal/culture-and-hostnames-modal.element.ts

@@ -1,14 +1,14 @@
+import { UmbDocumentCultureAndHostnamesRepository } from '../repository/index.js';
+import type {
+	UmbCultureAndHostnamesModalData,
+	UmbCultureAndHostnamesModalValue,
+} from './culture-and-hostnames-modal.token.js';
 import { html, customElement, state, css, repeat, query } from '@umbraco-cms/backoffice/external/lit';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
 import { UmbModalBaseElement } from '@umbraco-cms/backoffice/modal';
 import type { UmbLanguageDetailModel } from '@umbraco-cms/backoffice/language';
 import { UmbLanguageCollectionRepository } from '@umbraco-cms/backoffice/language';
 import type { DomainPresentationModel } from '@umbraco-cms/backoffice/external/backend-api';
-import {
-	UmbDocumentCultureAndHostnamesRepository,
-	type UmbCultureAndHostnamesModalData,
-	type UmbCultureAndHostnamesModalValue,
-} from '@umbraco-cms/backoffice/document';
 import type { UUIInputEvent, UUIPopoverContainerElement, UUISelectEvent } from '@umbraco-cms/backoffice/external/uui';
 
 @customElement('umb-culture-and-hostnames-modal')

src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/public-access/modal/public-access-modal.element.ts

@@ -1,13 +1,10 @@
 import { UmbDocumentPublicAccessRepository } from '../repository/public-access.repository.js';
+import { UmbDocumentDetailRepository } from '../../../repository/index.js';
+import type { UmbInputDocumentElement } from '../../../components/index.js';
+import type { UmbPublicAccessModalData, UmbPublicAccessModalValue } from './public-access-modal.token.js';
 import { html, customElement, state, css, nothing } from '@umbraco-cms/backoffice/external/lit';
 import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
 import { UmbModalBaseElement } from '@umbraco-cms/backoffice/modal';
-import {
-	UmbDocumentDetailRepository,
-	type UmbInputDocumentElement,
-	type UmbPublicAccessModalData,
-	type UmbPublicAccessModalValue,
-} from '@umbraco-cms/backoffice/document';
 import type { UUIRadioEvent } from '@umbraco-cms/backoffice/external/uui';
 import type { PublicAccessRequestModel } from '@umbraco-cms/backoffice/external/backend-api';
 import type { UmbInputMemberTypeElement } from '@umbraco-cms/backoffice/member-type';

src/Umbraco.Web.UI.Client/src/packages/members/member-type/components/input-member-type/input-member-type.context.ts

@@ -4,8 +4,8 @@ import type {
 } from '../../modal/member-type-picker-modal.token.js';
 import { UMB_MEMBER_TYPE_PICKER_MODAL } from '../../modal/member-type-picker-modal.token.js';
 import type { UmbMemberTypeItemModel } from '../../repository/item/types.js';
-import type { UmbMemberTypeTreeItemModel } from '@umbraco-cms/backoffice/member-type';
-import { UMB_MEMBER_TYPE_ITEM_REPOSITORY_ALIAS } from '@umbraco-cms/backoffice/member-type';
+import { UMB_MEMBER_TYPE_ITEM_REPOSITORY_ALIAS } from '../../repository/index.js';
+import type { UmbMemberTypeTreeItemModel } from '../../tree/index.js';
 import { UmbPickerInputContext } from '@umbraco-cms/backoffice/picker-input';
 import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';