From c4ab25f1ac7253a6fd72cd38aec58c717091c8c0 Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Mon, 11 Sep 2017 10:50:54 +0200 Subject: [PATCH] fixing first round of unit tests --- .../test/unit/app/content/edit-content-controller.spec.js | 2 +- .../test/unit/app/media/edit-media-controller.spec.js | 2 +- .../app/propertyeditors/content-picker-controller.spec.js | 8 ++++---- .../test/unit/common/services/content-factory.spec.js | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/test/unit/app/content/edit-content-controller.spec.js b/src/Umbraco.Web.UI.Client/test/unit/app/content/edit-content-controller.spec.js index 0d9b8a29e2..c7ddee12a3 100644 --- a/src/Umbraco.Web.UI.Client/test/unit/app/content/edit-content-controller.spec.js +++ b/src/Umbraco.Web.UI.Client/test/unit/app/content/edit-content-controller.spec.js @@ -42,7 +42,7 @@ describe('edit content controller tests', function () { it('it should have an content object', function() { //controller should have a content object - expect(scope.content).toNotBe(undefined); + expect(scope.content).toBeTruthy(); //if should be the same as the routeParams defined one expect(scope.content.id).toBe(1234); diff --git a/src/Umbraco.Web.UI.Client/test/unit/app/media/edit-media-controller.spec.js b/src/Umbraco.Web.UI.Client/test/unit/app/media/edit-media-controller.spec.js index 35179c5646..c34cd498c3 100644 --- a/src/Umbraco.Web.UI.Client/test/unit/app/media/edit-media-controller.spec.js +++ b/src/Umbraco.Web.UI.Client/test/unit/app/media/edit-media-controller.spec.js @@ -41,7 +41,7 @@ describe('edit media controller tests', function () { it('it should have an media object', function() { //controller should have a content object - expect(scope.content).toNotBe(undefined); + expect(scope.content).toBeTruthy(); //if should be the same as the routeParams defined one expect(scope.content.id).toBe(1234); diff --git a/src/Umbraco.Web.UI.Client/test/unit/app/propertyeditors/content-picker-controller.spec.js b/src/Umbraco.Web.UI.Client/test/unit/app/propertyeditors/content-picker-controller.spec.js index d5e3a7a496..df674c6ad0 100644 --- a/src/Umbraco.Web.UI.Client/test/unit/app/propertyeditors/content-picker-controller.spec.js +++ b/src/Umbraco.Web.UI.Client/test/unit/app/propertyeditors/content-picker-controller.spec.js @@ -59,19 +59,19 @@ describe('Content picker controller tests', function () { }; it('should define the default properties on construction', function () { - expect(scope.model.value).toNotBe(undefined); + expect(scope.model.value).toBeTruthy(); }); it("should populate scope.renderModel", function(){ - expect(scope.renderModel).toNotBe(undefined); + expect(scope.renderModel).toBeTruthy(); expect(scope.renderModel.length).toBe(3); }); it("Each rendermodel item should contain name, id and icon", function(){ var item = scope.renderModel[0]; - expect(item.name).toNotBe(undefined); + expect(item.name).toBeTruthy(); expect(item.id).toBe(1233); - expect(item.icon).toNotBe(undefined); + expect(item.icon).toBeTruthy(); }); it("Removing an item should update renderModel, ids and model.value", function(){ diff --git a/src/Umbraco.Web.UI.Client/test/unit/common/services/content-factory.spec.js b/src/Umbraco.Web.UI.Client/test/unit/common/services/content-factory.spec.js index fe2a92549d..5cec87a6ba 100644 --- a/src/Umbraco.Web.UI.Client/test/unit/common/services/content-factory.spec.js +++ b/src/Umbraco.Web.UI.Client/test/unit/common/services/content-factory.spec.js @@ -36,7 +36,7 @@ describe('content factory tests', function () { $rootScope.$digest(); $httpBackend.flush(); - expect(doc).toNotBe(undefined); + expect(doc).toBeTruthy(); expect(doc.id).toBe(1234); });