yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix placeholder text when empty alias input after generating alias (#4032)

Browse Source
This commit is contained in:
Bjarne Fyrstenborg
2019-01-13 13:06:16 +01:00
committed by Sebastiaan Janssen
parent 291d58900f
commit c619b79276
1 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/Umbraco.Web.UI.Client/src/common/directives/components/umbGenerateAlias.directive.js
View File

@@ -86,20 +86,21 @@ angular.module("umbraco.directives")
function generateAlias(value) { function generateAlias(value) {
if (generateAliasTimeout) { if (generateAliasTimeout) {
$timeout.cancel(generateAliasTimeout); $timeout.cancel(generateAliasTimeout);
} }
if( value !== undefined && value !== "" && value !== null) { if (value !== undefined && value !== "" && value !== null) {
scope.alias = ""; scope.alias = "";
scope.placeholderText = scope.labels.busy; scope.placeholderText = scope.labels.busy;
generateAliasTimeout = $timeout(function () { generateAliasTimeout = $timeout(function () {
updateAlias = true; updateAlias = true;
entityResource.getSafeAlias(value, true).then(function (safeAlias) { entityResource.getSafeAlias(value, true).then(function (safeAlias) {
if (updateAlias) { if (updateAlias) {
scope.alias = safeAlias.alias; scope.alias = safeAlias.alias;
} }
scope.placeholderText = scope.labels.idle;
}); });
}, 500); }, 500);
@@ -108,7 +109,6 @@ angular.module("umbraco.directives")
scope.alias = ""; scope.alias = "";
scope.placeholderText = scope.labels.idle; scope.placeholderText = scope.labels.idle;
} }
} }
// if alias gets unlocked - stop watching alias // if alias gets unlocked - stop watching alias
@@ -119,17 +119,17 @@ angular.module("umbraco.directives")
})); }));
// validate custom entered alias // validate custom entered alias
eventBindings.push(scope.$watch('alias', function(newValue, oldValue){ eventBindings.push(scope.$watch('alias', function (newValue, oldValue) {
if (scope.alias === "" || scope.alias === null || scope.alias === undefined) {
if(scope.alias === "" && bindWatcher === true || scope.alias === null && bindWatcher === true) { if (bindWatcher === true) {
// add watcher // add watcher
eventBindings.push(scope.$watch('aliasFrom', function(newValue, oldValue) { eventBindings.push(scope.$watch('aliasFrom', function (newValue, oldValue) {
if(bindWatcher) { if (bindWatcher) {
generateAlias(newValue); generateAlias(newValue);
} }
})); }));
} }
}
})); }));
// clean up // clean up