From c847a111fe6651ff14dc25c5eab33e7233d1cfa1 Mon Sep 17 00:00:00 2001
From: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
Date: Wed, 22 Jan 2025 10:39:26 +0100
Subject: [PATCH] 15: Convert pagesize properly to skip and take (#18069)

* convert pagesize properly to skip and take

* Obsolete pagesize & pageIndex GetAll method
---
 src/Umbraco.Core/Services/IMemberService.cs                   | 1 +
 .../Search/IndexingNotificationHandler.ContentType.cs         | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/Umbraco.Core/Services/IMemberService.cs b/src/Umbraco.Core/Services/IMemberService.cs
index df3bde6ce1..4cb17e9fbc 100644
--- a/src/Umbraco.Core/Services/IMemberService.cs
+++ b/src/Umbraco.Core/Services/IMemberService.cs
@@ -23,6 +23,7 @@ public interface IMemberService : IMembershipMemberService, IContentServiceBase<
     /// <returns>
     ///     <see cref="IEnumerable{T}" />
     /// </returns>
+    [Obsolete("Please use the skip & take instead of pageIndex & pageSize, scheduled for removal in v17")]
     IEnumerable<IMember> GetAll(
         long pageIndex,
         int pageSize,
diff --git a/src/Umbraco.Infrastructure/Search/IndexingNotificationHandler.ContentType.cs b/src/Umbraco.Infrastructure/Search/IndexingNotificationHandler.ContentType.cs
index 4955f17554..48bf98c7a3 100644
--- a/src/Umbraco.Infrastructure/Search/IndexingNotificationHandler.ContentType.cs
+++ b/src/Umbraco.Infrastructure/Search/IndexingNotificationHandler.ContentType.cs
@@ -117,13 +117,15 @@ public sealed class ContentTypeIndexingNotificationHandler : INotificationHandle
             while (page * pageSize < total)
             {
                 IEnumerable<IMember> memberToRefresh = _memberService.GetAll(
-                    page++, pageSize, out total, "LoginName", Direction.Ascending,
+                    page * pageSize, pageSize, out total, "LoginName", Direction.Ascending,
                     memberType.Alias);
 
                 foreach (IMember c in memberToRefresh)
                 {
                     _umbracoIndexingHandler.ReIndexForMember(c);
                 }
+
+                page++;
             }
         }
     }