https://github.com/umbraco/Umbraco-CMS/pull/9248>

- Removed BackOfficeArea
- Injected IEmailSender
- Uses nameof instead of magic strings
- Uses GetControllerName instead of magic strings

Signed-off-by: Bjarke Berg <mail@bergmania.dk>

src/Umbraco.Infrastructure/HealthCheck/NotificationMethods/EmailNotificationMethod.cs

@@ -4,7 +4,6 @@ using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Extensions.Options;
 using Umbraco.Core;
-using Umbraco.Core.Configuration;
 using Umbraco.Core.Configuration.Models;
 using Umbraco.Core.HealthCheck;
 using Umbraco.Core.Services;
@@ -17,14 +16,14 @@ namespace Umbraco.Web.HealthCheck.NotificationMethods
     {
         private readonly ILocalizedTextService _textService;
         private readonly IRequestAccessor _requestAccessor;
+        private readonly IEmailSender _emailSender;
 
-        private readonly GlobalSettings _globalSettings;
         private readonly ContentSettings _contentSettings;
 
         public EmailNotificationMethod(
             ILocalizedTextService textService,
             IRequestAccessor requestAccessor,
-            IOptions<GlobalSettings> globalSettings,
+            IEmailSender emailSender,
             IOptions<HealthChecksSettings> healthChecksSettings,
             IOptions<ContentSettings> contentSettings)
             : base(healthChecksSettings)
@@ -40,7 +39,7 @@ namespace Umbraco.Web.HealthCheck.NotificationMethods
 
             _textService = textService ?? throw new ArgumentNullException(nameof(textService));
             _requestAccessor = requestAccessor;
-            _globalSettings = globalSettings.Value;
+            _emailSender = emailSender;
             _contentSettings = contentSettings.Value ?? throw new ArgumentNullException(nameof(contentSettings));
         }
 
@@ -71,11 +70,9 @@ namespace Umbraco.Web.HealthCheck.NotificationMethods
 
             var subject = _textService.Localize("healthcheck/scheduledHealthCheckEmailSubject", new[] { host.ToString() });
 
-            // TODO: Why isn't this injected?
-            var mailSender = new EmailSender(Options.Create(_globalSettings));
             using (var mailMessage = CreateMailMessage(subject, message))
             {
-                await mailSender.SendAsync(mailMessage);
+                await _emailSender.SendAsync(mailMessage);
             }
         }