From cb097952800f01ea5a247ae247eba78f5ae8f282 Mon Sep 17 00:00:00 2001 From: Shannon Date: Tue, 25 Feb 2014 01:45:41 +1100 Subject: [PATCH] Removes new member service Creating event, as only Created makes sense. Deprecates the other 'Creating' events with a note to just use the Created event. --- src/Umbraco.Core/Services/ContentService.cs | 1 + src/Umbraco.Core/Services/MediaService.cs | 1 + src/Umbraco.Core/Services/MemberService.cs | 13 +------------ 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/src/Umbraco.Core/Services/ContentService.cs b/src/Umbraco.Core/Services/ContentService.cs index 80c4ca362e..5cb6c5b974 100644 --- a/src/Umbraco.Core/Services/ContentService.cs +++ b/src/Umbraco.Core/Services/ContentService.cs @@ -1984,6 +1984,7 @@ namespace Umbraco.Core.Services /// /// Occurs before Create /// + [Obsolete("Use the Created event instead, the Creating and Created events both offer the same functionality, Creating event has been deprecated.")] public static event TypedEventHandler> Creating; /// diff --git a/src/Umbraco.Core/Services/MediaService.cs b/src/Umbraco.Core/Services/MediaService.cs index 7ee4fc6eab..3a864bd397 100644 --- a/src/Umbraco.Core/Services/MediaService.cs +++ b/src/Umbraco.Core/Services/MediaService.cs @@ -1042,6 +1042,7 @@ namespace Umbraco.Core.Services /// /// Occurs before Create /// + [Obsolete("Use the Created event instead, the Creating and Created events both offer the same functionality, Creating event has been deprecated.")] public static event TypedEventHandler> Creating; /// diff --git a/src/Umbraco.Core/Services/MemberService.cs b/src/Umbraco.Core/Services/MemberService.cs index ca1a7cc366..6dba8cd184 100644 --- a/src/Umbraco.Core/Services/MemberService.cs +++ b/src/Umbraco.Core/Services/MemberService.cs @@ -582,12 +582,6 @@ namespace Umbraco.Core.Services var member = new Member(username, email.ToLower().Trim(), username, password, -1, memberType); - if (Creating.IsRaisedEventCancelled(new NewEventArgs(member, memberTypeAlias, -1), this)) - { - member.WasCancelled = true; - return member; - } - Created.RaiseEvent(new NewEventArgs(member, false, memberTypeAlias, -1), this); return member; @@ -1020,12 +1014,7 @@ namespace Umbraco.Core.Services /// Occurs before Save /// public static event TypedEventHandler> Saving; - - /// - /// Occurs before Create - /// - public static event TypedEventHandler> Creating; - + /// /// Occurs after Create ///