From ce43f515640aad6e698aa8e33efa77c9009318e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jesper=20M=C3=B8ller=20Jensen?= <26099018+JesmoDev@users.noreply.github.com> Date: Wed, 10 May 2023 16:19:17 +1200 Subject: [PATCH] cleanup --- .../collection/user-group-collection-header.element.ts | 1 - .../user-groups/repository/sources/user-group.server.data.ts | 2 +- .../backoffice/users/users/workspace/user-workspace.context.ts | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/collection/user-group-collection-header.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/collection/user-group-collection-header.element.ts index b41baa4244..010073b580 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/collection/user-group-collection-header.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/collection/user-group-collection-header.element.ts @@ -19,7 +19,6 @@ export class UmbUserGroupCollectionHeaderElement extends UmbLitElement { } #onCreate() { - //TODO Navigate to create workspace history.pushState(null, '', 'section/users/view/user-groups/user-group/create/'); } diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/repository/sources/user-group.server.data.ts b/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/repository/sources/user-group.server.data.ts index 471a70bbba..7cc1742883 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/repository/sources/user-group.server.data.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/users/user-groups/repository/sources/user-group.server.data.ts @@ -5,7 +5,6 @@ import { UserGroupResource, UpdateUserGroupRequestModel, SaveUserGroupRequestModel, - UserGroupBaseModel, } from '@umbraco-cms/backoffice/backend-api'; import { UmbControllerHostElement } from '@umbraco-cms/backoffice/controller'; import { tryExecuteAndNotify } from '@umbraco-cms/backoffice/resources'; @@ -28,6 +27,7 @@ export class UmbUserGroupServerDataSource implements UmbUserGroupDetailDataSourc this.#host = host; } + //TODO should parentId be optional in the generic interface? async createScaffold(parentId: string | null) { const data: SaveUserGroupRequestModel = { name: '', diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/users/users/workspace/user-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/backoffice/users/users/workspace/user-workspace.context.ts index 7ea8fa12f4..0eac18312b 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/users/users/workspace/user-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/users/users/workspace/user-workspace.context.ts @@ -16,8 +16,6 @@ export class UmbUserWorkspaceContext data = this.#data.asObservable(); async load(id: string) { - console.log('load'); - const { data } = await this.repository.requestById(id); if (data) { this.setIsNew(false);