From ce8f692c2b83eb8c6aa304fac827fd168a6e8744 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Tue, 10 Jan 2023 16:03:27 +0100 Subject: [PATCH] correct events --- .../components/input-user-group/input-user-group.element.ts | 2 +- .../src/auth/components/input-user/input-user.element.ts | 2 +- .../shared/components/input-section/input-section.element.ts | 2 +- .../property-actions/clear/property-action-clear.element.ts | 2 +- .../content-picker/property-editor-ui-content-picker.element.ts | 2 +- .../uis/number/property-editor-ui-number.element.ts | 2 +- .../uis/text-box/property-editor-ui-text-box.element.ts | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/auth/components/input-user-group/input-user-group.element.ts b/src/Umbraco.Web.UI.Client/src/auth/components/input-user-group/input-user-group.element.ts index 7f92e52413..f1133821f4 100644 --- a/src/Umbraco.Web.UI.Client/src/auth/components/input-user-group/input-user-group.element.ts +++ b/src/Umbraco.Web.UI.Client/src/auth/components/input-user-group/input-user-group.element.ts @@ -63,7 +63,7 @@ export class UmbInputPickerUserGroupElement extends UmbInputListBase { selectionUpdated() { this._observeUserGroups(); - this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); + this.dispatchEvent(new CustomEvent('change', { bubbles: true, composed: true })); } private _renderUserGroupList() { diff --git a/src/Umbraco.Web.UI.Client/src/auth/components/input-user/input-user.element.ts b/src/Umbraco.Web.UI.Client/src/auth/components/input-user/input-user.element.ts index 16d035b2f4..dd99d8520d 100644 --- a/src/Umbraco.Web.UI.Client/src/auth/components/input-user/input-user.element.ts +++ b/src/Umbraco.Web.UI.Client/src/auth/components/input-user/input-user.element.ts @@ -63,7 +63,7 @@ export class UmbPickerUserElement extends UmbInputListBase { selectionUpdated() { this._observeUser(); - this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); + this.dispatchEvent(new CustomEvent('change', { bubbles: true, composed: true })); } private _renderUserList() { diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/input-section/input-section.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/input-section/input-section.element.ts index 26e3295df2..8d26ad21e2 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/input-section/input-section.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/input-section/input-section.element.ts @@ -58,7 +58,7 @@ export class UmbInputPickerSectionElement extends UmbInputListBase { selectionUpdated() { this._observeSections(); // TODO: Use proper event class: - this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); + this.dispatchEvent(new CustomEvent('change', { bubbles: true, composed: true })); } renderContent() { diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-actions/clear/property-action-clear.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-actions/clear/property-action-clear.element.ts index b5e81487e1..6df5a91cc9 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-actions/clear/property-action-clear.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-actions/clear/property-action-clear.element.ts @@ -38,7 +38,7 @@ export class UmbPropertyActionClearElement extends UmbLitElement implements UmbP private _clearValue() { // TODO: how do we want to update the value? Testing an event based approach. We need to test an api based approach too. //this.value = '';// This is though bad as it assumes we are dealing with a string. So wouldn't work as a generalized element. - //this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); + //this.dispatchEvent(new CustomEvent('property-value-change')); // Or you can do this: this._propertyContext?.resetValue();// This resets value to what the property wants. } diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/content-picker/property-editor-ui-content-picker.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/content-picker/property-editor-ui-content-picker.element.ts index 9ce4bfc0d5..e3d5dfa1c4 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/content-picker/property-editor-ui-content-picker.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/content-picker/property-editor-ui-content-picker.element.ts @@ -90,7 +90,7 @@ export class UmbPropertyEditorUIContentPickerElement extends UmbLitElement { private _setValue(newValue: Array) { this.value = newValue; this._observePickedDocuments(); - this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); + this.dispatchEvent(new CustomEvent('property-value-change')); } private _renderItem(item: FolderTreeItem) { diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/number/property-editor-ui-number.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/number/property-editor-ui-number.element.ts index fb1e450df1..7c704fbc8c 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/number/property-editor-ui-number.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/number/property-editor-ui-number.element.ts @@ -21,7 +21,7 @@ export class UmbPropertyEditorUINumberElement extends LitElement { private onInput(e: InputEvent) { this.value = (e.target as HTMLInputElement).value; - this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); + this.dispatchEvent(new CustomEvent('property-value-change')); } render() { diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/text-box/property-editor-ui-text-box.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/text-box/property-editor-ui-text-box.element.ts index 8845fd53e5..302a353da3 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/text-box/property-editor-ui-text-box.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/property-editors/uis/text-box/property-editor-ui-text-box.element.ts @@ -21,7 +21,7 @@ export class UmbPropertyEditorUITextBoxElement extends LitElement { private onInput(e: InputEvent) { this.value = (e.target as HTMLInputElement).value; - this.dispatchEvent(new CustomEvent('property-value-change', { bubbles: true, composed: true })); + this.dispatchEvent(new CustomEvent('property-value-change')); } render() {