Merge pull request #1536 from umbraco/bugfix/rename-long-paths

Bugfix/rename-long-paths

src/Umbraco.Web.UI.Client/devops/build/check-path-length.js

@@ -7,6 +7,9 @@ const IS_CI = process.env.CI === 'true';
 const IS_AZURE_PIPELINES = process.env.TF_BUILD === 'true';
 const IS_GITHUB_ACTIONS = process.env.GITHUB_ACTIONS === 'true';
 const FILE_PATH_COLOR = '\x1b[36m%s\x1b[0m';
+const ERROR_COLOR = '\x1b[31m%s\x1b[0m';
+const SUCCESS_COLOR = '\x1b[32m%s\x1b[0m';
+const processExitCode = 1; // Default to 1 to fail the build, 0 to just log the issues
 
 console.log(`Checking path length in ${PROJECT_DIR} for paths exceeding ${MAX_PATH_LENGTH}...`);
 console.log('CI detected:', IS_CI);
@@ -17,14 +20,12 @@ console.log('-----------------------------------\n');
 
 function checkPathLength(dir) {
 	const files = readdirSync(dir);
+	let hasError = false;
 
 	files.forEach(file => {
 		const filePath = join(dir, file);
 		if (filePath.length > MAX_PATH_LENGTH) {
-
-			if (IS_CI) {
-				//process.exitCode = 1; // TODO: Uncomment this line to fail the build
-			}
+			hasError = true;
 
 			if (IS_AZURE_PIPELINES) {
 				console.error(`##vso[task.logissue type=warning;sourcepath=${filePath};]Path exceeds maximum length of ${MAX_PATH_LENGTH} characters: ${filePath} with ${filePath.length} characters`);
@@ -36,9 +37,27 @@ function checkPathLength(dir) {
 		}
 
 		if (statSync(filePath).isDirectory()) {
-			checkPathLength(filePath, MAX_PATH_LENGTH);
+			const subHasError = checkPathLength(filePath);
+			if (subHasError) {
+				hasError = true;
+			}
 		}
 	});
+
+	return hasError;
 }
 
-checkPathLength(PROJECT_DIR, MAX_PATH_LENGTH);
+const hasError = checkPathLength(PROJECT_DIR, MAX_PATH_LENGTH);
+
+if (hasError) {
+	console.error('\n-----------------------------------');
+	console.error(ERROR_COLOR, 'Path length check failed');
+	console.error('-----------------------------------\n');
+	if (IS_CI && processExitCode) {
+		process.exit(processExitCode);
+	}
+} else {
+	console.log('\n-----------------------------------');
+	console.log(SUCCESS_COLOR, 'Path length check passed');
+	console.log('-----------------------------------\n');
+}

src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-area-config-entry/workspace/views/manifests.ts

@@ -6,7 +6,7 @@ export const workspaceViews: Array<ManifestWorkspaceView> = [
 		type: 'workspaceView',
 		alias: 'Umb.WorkspaceView.BlockGridAreaType.Settings',
 		name: 'Block Grid Area Type Workspace Settings View',
-		js: () => import('./block-grid-area-type-workspace-view-settings.element.js'),
+		js: () => import('./settings.element.js'),
 		weight: 1000,
 		meta: {
 			label: 'Settings',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/bulk-action-permissions/manifests.ts

@@ -4,7 +4,7 @@ export const manifest: ManifestPropertyEditorUi = {
 	type: 'propertyEditorUi',
 	alias: 'Umb.PropertyEditorUi.CollectionView.BulkActionPermissions',
 	name: 'Collection View Bulk Action Permissions Property Editor UI',
-	element: () => import('./property-editor-ui-collection-view-bulk-action-permissions.element.js'),
+	element: () => import('./permissions.element.js'),
 	meta: {
 		label: 'Collection View Bulk Action Permissions',
 		icon: 'icon-autofill',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/bulk-action-permissions/permissions.element.ts

@@ -1,4 +1,4 @@
-import type { UmbCollectionBulkActionPermissions } from '../../../../../../core/collection/types.js';
+import type { UmbCollectionBulkActionPermissions } from '../../../../../collection/types.js';
 import type { UmbPropertyEditorUiElement } from '@umbraco-cms/backoffice/extension-registry';
 import { html, customElement, property, css } from '@umbraco-cms/backoffice/external/lit';
 import type { UUIBooleanInputEvent } from '@umbraco-cms/backoffice/external/uui';
@@ -15,10 +15,10 @@ type BulkActionPermissionType =
 	| 'allowBulkUnpublish';
 
 /**
- * @element umb-property-editor-ui-collection-view-bulk-action-permissions
+ * @element umb-property-editor-ui-collection-view-permissions
  */
-@customElement('umb-property-editor-ui-collection-view-bulk-action-permissions')
-export class UmbPropertyEditorUICollectionViewBulkActionPermissionsElement
+@customElement('umb-property-editor-ui-collection-view-permissions')
+export class UmbPropertyEditorUICollectionViewPermissionsElement
 	extends UmbLitElement
 	implements UmbPropertyEditorUiElement
 {
@@ -98,10 +98,10 @@ export class UmbPropertyEditorUICollectionViewBulkActionPermissionsElement
 	];
 }
 
-export default UmbPropertyEditorUICollectionViewBulkActionPermissionsElement;
+export default UmbPropertyEditorUICollectionViewPermissionsElement;
 
 declare global {
 	interface HTMLElementTagNameMap {
-		'umb-property-editor-ui-collection-view-bulk-action-permissions': UmbPropertyEditorUICollectionViewBulkActionPermissionsElement;
+		'umb-property-editor-ui-collection-view-permissions': UmbPropertyEditorUICollectionViewPermissionsElement;
 	}
 }

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/bulk-action-permissions/permissions.stories.ts

@@ -0,0 +1,15 @@
+import type { Meta, Story } from '@storybook/web-components';
+import type { UmbPropertyEditorUICollectionViewPermissionsElement } from './permissions.element.js';
+import { html } from '@umbraco-cms/backoffice/external/lit';
+
+import './permissions.element.js';
+
+export default {
+	title: 'Property Editor UIs/Collection View Bulk Action Permissions',
+	component: 'umb-property-editor-ui-collection-view-permissions',
+	id: 'umb-property-editor-ui-collection-view-permissions',
+} as Meta;
+
+export const AAAOverview: Story<UmbPropertyEditorUICollectionViewPermissionsElement> = () =>
+	html`<umb-property-editor-ui-collection-view-permissions></umb-property-editor-ui-collection-view-permissions>`;
+AAAOverview.storyName = 'Overview';

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/bulk-action-permissions/permissions.test.ts

@@ -1,18 +1,18 @@
 import { expect, fixture, html } from '@open-wc/testing';
-import { UmbPropertyEditorUICollectionViewBulkActionPermissionsElement } from './property-editor-ui-collection-view-bulk-action-permissions.element.js';
+import { UmbPropertyEditorUICollectionViewPermissionsElement } from './permissions.element.js';
 import { type UmbTestRunnerWindow, defaultA11yConfig } from '@umbraco-cms/internal/test-utils';
 
-describe('UmbPropertyEditorUICollectionViewBulkActionPermissionsElement', () => {
-	let element: UmbPropertyEditorUICollectionViewBulkActionPermissionsElement;
+describe('UmbPropertyEditorUICollectionViewPermissionsElement', () => {
+	let element: UmbPropertyEditorUICollectionViewPermissionsElement;
 
 	beforeEach(async () => {
 		element = await fixture(html`
-			<umb-property-editor-ui-collection-view-bulk-action-permissions></umb-property-editor-ui-collection-view-bulk-action-permissions>
+			<umb-property-editor-ui-collection-view-permissions></umb-property-editor-ui-collection-view-permissions>
 		`);
 	});
 
 	it('is defined with its own instance', () => {
-		expect(element).to.be.instanceOf(UmbPropertyEditorUICollectionViewBulkActionPermissionsElement);
+		expect(element).to.be.instanceOf(UmbPropertyEditorUICollectionViewPermissionsElement);
 	});
 
 	if ((window as UmbTestRunnerWindow).__UMBRACO_TEST_RUN_A11Y_TEST) {

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/bulk-action-permissions/property-editor-ui-collection-view-bulk-action-permissions.stories.ts

@@ -1,15 +0,0 @@
-import type { Meta, Story } from '@storybook/web-components';
-import type { UmbPropertyEditorUICollectionViewBulkActionPermissionsElement } from './property-editor-ui-collection-view-bulk-action-permissions.element.js';
-import { html } from '@umbraco-cms/backoffice/external/lit';
-
-import './property-editor-ui-collection-view-bulk-action-permissions.element.js';
-
-export default {
-	title: 'Property Editor UIs/Collection View Bulk Action Permissions',
-	component: 'umb-property-editor-ui-collection-view-bulk-action-permissions',
-	id: 'umb-property-editor-ui-collection-view-bulk-action-permissions',
-} as Meta;
-
-export const AAAOverview: Story<UmbPropertyEditorUICollectionViewBulkActionPermissionsElement> = () =>
-	html`<umb-property-editor-ui-collection-view-bulk-action-permissions></umb-property-editor-ui-collection-view-bulk-action-permissions>`;
-AAAOverview.storyName = 'Overview';

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/column/column-configuration.stories.ts

@@ -1,8 +1,8 @@
 import type { Meta, Story } from '@storybook/web-components';
-import type { UmbPropertyEditorUICollectionViewColumnConfigurationElement } from './property-editor-ui-collection-view-column-configuration.element.js';
+import type { UmbPropertyEditorUICollectionViewColumnConfigurationElement } from './column-configuration.element.js';
 import { html } from '@umbraco-cms/backoffice/external/lit';
 
-import './property-editor-ui-collection-view-column-configuration.element.js';
+import './column-configuration.element.js';
 
 export default {
 	title: 'Property Editor UIs/Collection View Column Configuration',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/column/column-configuration.test.ts

@@ -1,5 +1,5 @@
 import { expect, fixture, html } from '@open-wc/testing';
-import { UmbPropertyEditorUICollectionViewColumnConfigurationElement } from './property-editor-ui-collection-view-column-configuration.element.js';
+import { UmbPropertyEditorUICollectionViewColumnConfigurationElement } from './column-configuration.element.js';
 import { type UmbTestRunnerWindow, defaultA11yConfig } from '@umbraco-cms/internal/test-utils';
 
 describe('UmbPropertyEditorUICollectionViewColumnConfigurationElement', () => {

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/column/manifests.ts

@@ -4,7 +4,7 @@ export const manifest: ManifestPropertyEditorUi = {
 	type: 'propertyEditorUi',
 	alias: 'Umb.PropertyEditorUi.CollectionView.ColumnConfiguration',
 	name: 'Collection View Column Configuration Property Editor UI',
-	element: () => import('./property-editor-ui-collection-view-column-configuration.element.js'),
+	element: () => import('./column-configuration.element.js'),
 	meta: {
 		label: 'Collection View Column Configuration',
 		icon: 'icon-autofill',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/layout/layout-configuration.stories.ts

@@ -1,8 +1,8 @@
 import type { Meta, Story } from '@storybook/web-components';
-import type { UmbPropertyEditorUICollectionViewLayoutConfigurationElement } from './property-editor-ui-collection-view-layout-configuration.element.js';
+import type { UmbPropertyEditorUICollectionViewLayoutConfigurationElement } from './layout-configuration.element.js';
 import { html } from '@umbraco-cms/backoffice/external/lit';
 
-import './property-editor-ui-collection-view-layout-configuration.element.js';
+import './layout-configuration.element.js';
 
 export default {
 	title: 'Property Editor UIs/Collection View Layout Configuration',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/layout/layout-configuration.test.ts

@@ -1,5 +1,5 @@
 import { expect, fixture, html } from '@open-wc/testing';
-import { UmbPropertyEditorUICollectionViewLayoutConfigurationElement } from './property-editor-ui-collection-view-layout-configuration.element.js';
+import { UmbPropertyEditorUICollectionViewLayoutConfigurationElement } from './layout-configuration.element.js';
 import { type UmbTestRunnerWindow, defaultA11yConfig } from '@umbraco-cms/internal/test-utils';
 
 describe('UmbPropertyEditorUICollectionViewLayoutConfigurationElement', () => {

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/layout/manifests.ts

@@ -4,7 +4,7 @@ export const manifest: ManifestPropertyEditorUi = {
 	type: 'propertyEditorUi',
 	alias: 'Umb.PropertyEditorUi.CollectionView.LayoutConfiguration',
 	name: 'Collection View Column Configuration Property Editor UI',
-	element: () => import('./property-editor-ui-collection-view-layout-configuration.element.js'),
+	element: () => import('./layout-configuration.element.js'),
 	meta: {
 		label: 'Collection View Layout Configuration',
 		icon: 'icon-autofill',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/order-by/manifests.ts

@@ -4,7 +4,7 @@ export const manifest: ManifestPropertyEditorUi = {
 	type: 'propertyEditorUi',
 	alias: 'Umb.PropertyEditorUi.CollectionView.OrderBy',
 	name: 'Collection View Column Configuration Property Editor UI',
-	element: () => import('./property-editor-ui-collection-view-order-by.element.js'),
+	element: () => import('./order-by.element.js'),
 	meta: {
 		label: 'Collection View Order By',
 		icon: 'icon-autofill',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/order-by/order-by.stories.ts

@@ -1,8 +1,8 @@
 import type { Meta, Story } from '@storybook/web-components';
-import type { UmbPropertyEditorUICollectionViewOrderByElement } from './property-editor-ui-collection-view-order-by.element.js';
+import type { UmbPropertyEditorUICollectionViewOrderByElement } from './order-by.element.js';
 import { html } from '@umbraco-cms/backoffice/external/lit';
 
-import './property-editor-ui-collection-view-order-by.element.js';
+import './order-by.element.js';
 
 export default {
 	title: 'Property Editor UIs/Collection View Order By',

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/config/order-by/order-by.test.ts

@@ -1,5 +1,5 @@
 import { expect, fixture, html } from '@open-wc/testing';
-import { UmbPropertyEditorUICollectionViewOrderByElement } from './property-editor-ui-collection-view-order-by.element.js';
+import { UmbPropertyEditorUICollectionViewOrderByElement } from './order-by.element.js';
 import { type UmbTestRunnerWindow, defaultA11yConfig } from '@umbraco-cms/internal/test-utils';
 
 describe('UmbPropertyEditorUICollectionViewOrderByElement', () => {

src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/collection-view/manifests.ts

@@ -1,6 +1,6 @@
 import { manifest as bulkActionPermissions } from './config/bulk-action-permissions/manifests.js';
-import { manifest as columnConfiguration } from './config/column-configuration/manifests.js';
-import { manifest as layoutConfiguration } from './config/layout-configuration/manifests.js';
+import { manifest as columnConfiguration } from './config/column/manifests.js';
+import { manifest as layoutConfiguration } from './config/layout/manifests.js';
 import { manifest as orderBy } from './config/order-by/manifests.js';
 import type { ManifestPropertyEditorUi } from '@umbraco-cms/backoffice/extension-registry';