From 23816665f3dba2f898469a378701de460a5973a4 Mon Sep 17 00:00:00 2001 From: Jason Woods Date: Tue, 25 Apr 2017 08:21:02 -0600 Subject: [PATCH 1/3] Fixed issue on line 216 Found that when uploading media from the folder browser caused an issue of invalid JSON object being stored in the database. Added quotes around the property values. --- src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs b/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs index 362be7d73d..3e73e28a88 100644 --- a/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs +++ b/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs @@ -213,7 +213,7 @@ namespace Umbraco.Web.PropertyEditors .GetPreValuesByDataTypeId(property.PropertyType.DataTypeDefinitionId).FirstOrDefault(); var crops = string.IsNullOrWhiteSpace(config) ? "[]" : config; src = svalue; - property.Value = "{src: '" + svalue + "', crops: " + crops + "}"; + property.Value = "{\"src\": '" + svalue + "', \"crops\": " + crops + "}"; } else { From 850e354b11d275e133631e1fa1a892a3658a4a0e Mon Sep 17 00:00:00 2001 From: Jason Woods Date: Thu, 27 Apr 2017 16:03:45 -0600 Subject: [PATCH 2/3] wrapped all values in double quotes Wrapped image src and crop values in double quotes to keep consistent across all saves and updates. --- src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs b/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs index 3e73e28a88..3e55d12d25 100644 --- a/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs +++ b/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs @@ -213,7 +213,7 @@ namespace Umbraco.Web.PropertyEditors .GetPreValuesByDataTypeId(property.PropertyType.DataTypeDefinitionId).FirstOrDefault(); var crops = string.IsNullOrWhiteSpace(config) ? "[]" : config; src = svalue; - property.Value = "{\"src\": '" + svalue + "', \"crops\": " + crops + "}"; + property.Value = "{\"src\": \" " + svalue + " \", \"crops\": " + crops + "}"; } else { From f737004544c3775cf72453232a454a48b85fe4cb Mon Sep 17 00:00:00 2001 From: Jason Woods Date: Thu, 27 Apr 2017 16:13:41 -0600 Subject: [PATCH 3/3] Removed space before svalue --- src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs b/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs index 3e55d12d25..5196fda0ee 100644 --- a/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs +++ b/src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs @@ -213,7 +213,7 @@ namespace Umbraco.Web.PropertyEditors .GetPreValuesByDataTypeId(property.PropertyType.DataTypeDefinitionId).FirstOrDefault(); var crops = string.IsNullOrWhiteSpace(config) ? "[]" : config; src = svalue; - property.Value = "{\"src\": \" " + svalue + " \", \"crops\": " + crops + "}"; + property.Value = "{\"src\": \"" + svalue + "\", \"crops\": " + crops + "}"; } else {