diff --git a/src/Umbraco.Core/Persistence/Factories/DictionaryItemFactory.cs b/src/Umbraco.Core/Persistence/Factories/DictionaryItemFactory.cs index e84b1c96e2..8994026ccb 100644 --- a/src/Umbraco.Core/Persistence/Factories/DictionaryItemFactory.cs +++ b/src/Umbraco.Core/Persistence/Factories/DictionaryItemFactory.cs @@ -4,11 +4,11 @@ using Umbraco.Core.Persistence.Dtos; namespace Umbraco.Core.Persistence.Factories { - internal class DictionaryItemFactory + internal static class DictionaryItemFactory { #region Implementation of IEntityFactory - public IDictionaryItem BuildEntity(DictionaryDto dto) + public static IDictionaryItem BuildEntity(DictionaryDto dto) { var item = new DictionaryItem(dto.Parent, dto.Key); @@ -29,7 +29,7 @@ namespace Umbraco.Core.Persistence.Factories } } - public DictionaryDto BuildDto(IDictionaryItem entity) + public static DictionaryDto BuildDto(IDictionaryItem entity) { return new DictionaryDto { @@ -43,7 +43,7 @@ namespace Umbraco.Core.Persistence.Factories #endregion - private List BuildLanguageTextDtos(IDictionaryItem entity) + private static List BuildLanguageTextDtos(IDictionaryItem entity) { var list = new List(); foreach (var translation in entity.Translations) diff --git a/src/Umbraco.Core/Persistence/Repositories/Implement/DictionaryRepository.cs b/src/Umbraco.Core/Persistence/Repositories/Implement/DictionaryRepository.cs index 75bcb5e0c0..6d2fcc074f 100644 --- a/src/Umbraco.Core/Persistence/Repositories/Implement/DictionaryRepository.cs +++ b/src/Umbraco.Core/Persistence/Repositories/Implement/DictionaryRepository.cs @@ -130,9 +130,8 @@ namespace Umbraco.Core.Persistence.Repositories.Implement foreach (var translation in dictionaryItem.Translations) translation.Value = translation.Value.ToValidXmlString(); - - var factory = new DictionaryItemFactory(); - var dto = factory.BuildDto(dictionaryItem); + + var dto = DictionaryItemFactory.BuildDto(dictionaryItem); var id = Convert.ToInt32(Database.Insert(dto)); dictionaryItem.Id = id; @@ -154,9 +153,8 @@ namespace Umbraco.Core.Persistence.Repositories.Implement foreach (var translation in entity.Translations) translation.Value = translation.Value.ToValidXmlString(); - - var factory = new DictionaryItemFactory(); - var dto = factory.BuildDto(entity); + + var dto = DictionaryItemFactory.BuildDto(entity); Database.Update(dto); @@ -216,8 +214,7 @@ namespace Umbraco.Core.Persistence.Repositories.Implement protected IDictionaryItem ConvertFromDto(DictionaryDto dto) { - var factory = new DictionaryItemFactory(); - var entity = factory.BuildEntity(dto); + var entity = DictionaryItemFactory.BuildEntity(dto); var f = new DictionaryTranslationFactory(dto.UniqueId); entity.Translations = dto.LanguageTextDtos.EmptyNull()