From d00c07592e73318bbc90bfe6fc571dce406cb680 Mon Sep 17 00:00:00 2001 From: Claus Date: Fri, 7 Aug 2020 12:42:28 +0200 Subject: [PATCH] merging over a bunch of fixes from contrib for element tags not correctly closed. --- .../templatesections/templatesections.html | 4 +- .../components/users/change-password.html | 6 +- .../src/views/content/overlays/publish.html | 5 +- .../overlays/publishdescendants.controller.js | 14 ++-- .../content/overlays/publishdescendants.html | 43 ++++++------ .../src/views/content/overlays/save.html | 15 ++-- .../src/views/content/overlays/schedule.html | 22 +++--- .../views/content/overlays/sendtopublish.html | 11 +-- .../src/views/content/overlays/unpublish.html | 19 +++-- .../src/views/content/protect.html | 15 +++- .../src/views/datatypes/delete.html | 11 +-- .../src/views/documenttypes/create.html | 6 +- .../src/views/logviewer/search.html | 6 +- .../src/views/packages/edit.html | 70 +++++++++++-------- .../listview/layouts.prevalues.html | 69 +++++++++--------- .../listview/orderDirection.prevalues.html | 14 +++- .../radiobuttons/radiobuttons.html | 7 +- .../propertyeditors/rte/rte.prevalues.html | 20 +++--- .../src/views/relationtypes/create.html | 10 ++- .../relationtypes/views/relationType.html | 12 +++- 20 files changed, 216 insertions(+), 163 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/templatesections/templatesections.html b/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/templatesections/templatesections.html index 045a1403e2..b4e8d7fbe8 100644 --- a/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/templatesections/templatesections.html +++ b/src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/templatesections/templatesections.html @@ -45,7 +45,9 @@
- + +
diff --git a/src/Umbraco.Web.UI.Client/src/views/components/users/change-password.html b/src/Umbraco.Web.UI.Client/src/views/components/users/change-password.html index 38ea13eebb..b6e0b4c123 100644 --- a/src/Umbraco.Web.UI.Client/src/views/components/users/change-password.html +++ b/src/Umbraco.Web.UI.Client/src/views/components/users/change-password.html @@ -14,8 +14,10 @@ - + + {{changePasswordForm.resetPassword.errorMsg}} diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html index 4cf4444cfe..71e19651d6 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html @@ -19,8 +19,8 @@ name="publishVariantSelector" model="variant.publish" on-change="vm.changeSelection(variant)" - server-validation-field="{{variant.htmlId}}" - > + server-validation-field="{{variant.htmlId}}"> + * @@ -38,6 +38,7 @@ {{publishVariantSelectorForm.publishVariantSelector.errorMsg}} + diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js index 095c4f3fe1..5d4cc7eec7 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js @@ -5,23 +5,28 @@ var vm = this; - vm.includeUnpublished = false; + vm.includeUnpublished = $scope.model.includeUnpublished || false; vm.changeSelection = changeSelection; vm.toggleIncludeUnpublished = toggleIncludeUnpublished; - function onInit() { vm.variants = $scope.model.variants; - vm.displayVariants = vm.variants.slice(0);// shallow copy, we dont want to share the array-object(because we will be performing a sort method) but each entry should be shared (because we need validation and notifications). + vm.displayVariants = vm.variants.slice(0); // shallow copy, we don't want to share the array-object (because we will be performing a sort method) but each entry should be shared (because we need validation and notifications). vm.labels = {}; + // get localized texts for use in directives if (!$scope.model.title) { localizationService.localize("buttons_publishDescendants").then(function (value) { $scope.model.title = value; }); } + if (!vm.labels.includeUnpublished) { + localizationService.localize("content_includeUnpublished").then(function (value) { + vm.labels.includeUnpublished = value; + }); + } _.each(vm.variants, function (variant) { variant.isMandatory = isMandatoryFilter(variant); @@ -72,8 +77,9 @@ } function toggleIncludeUnpublished() { - console.log("toggleIncludeUnpublished") vm.includeUnpublished = !vm.includeUnpublished; + // make sure this value is pushed back to the scope + $scope.model.includeUnpublished = vm.includeUnpublished; } /** Returns true if publishing is possible based on if there are un-published mandatory languages */ diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html index 2a983b229c..cfc185818c 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html @@ -6,15 +6,13 @@
- - - +
@@ -26,15 +24,13 @@
- - - +
@@ -44,11 +40,11 @@
+ name="publishVariantSelector" + model="variant.publish" + on-change="vm.changeSelection(variant)" + server-validation-field="{{variant.htmlId}}"> + * @@ -66,6 +62,7 @@ {{publishVariantSelectorForm.publishVariantSelector.errorMsg}} + diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html index dd6e96df95..661dd4162e 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html @@ -18,13 +18,12 @@
- + + * @@ -42,12 +41,12 @@ {{saveVariantSelectorForm.saveVariantSelector.errorMsg}} +
-

diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html index 8f515a10e4..fc2f24c648 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html @@ -88,13 +88,12 @@
- + + * @@ -105,16 +104,14 @@ * + ng-if="!scheduleSelectorForm.$invalid && !(variant.notifications && variant.notifications.length > 0)"> - +
- - -
@@ -183,12 +180,9 @@
-

-
- diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html index 91fa1799fc..abf39c6542 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html @@ -15,11 +15,11 @@
+ name="publishVariantSelector" + model="variant.publish" + on-change="vm.changeSelection(variant)" + server-validation-field="{{variant.htmlId}}"> + * @@ -37,6 +37,7 @@ {{publishVariantSelectorForm.publishVariantSelector.errorMsg}} + diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html index 94dd9fdac5..5ab32abf00 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html @@ -17,14 +17,13 @@
- + + * @@ -42,17 +41,15 @@ {{publishVariantSelectorForm.publishVariantSelector.errorMsg}} +
-

- - diff --git a/src/Umbraco.Web.UI.Client/src/views/content/protect.html b/src/Umbraco.Web.UI.Client/src/views/content/protect.html index 6377fd7c65..6fb9f78e67 100644 --- a/src/Umbraco.Web.UI.Client/src/views/content/protect.html +++ b/src/Umbraco.Web.UI.Client/src/views/content/protect.html @@ -19,7 +19,13 @@

- + + +
- + + +
- + + on-confirm="vm.performDelete" + on-cancel="vm.cancel" + confirm-button-style="danger" + confirm-label-key="general_delete"> diff --git a/src/Umbraco.Web.UI.Client/src/views/documenttypes/create.html b/src/Umbraco.Web.UI.Client/src/views/documenttypes/create.html index 5aba520b9b..1357965197 100644 --- a/src/Umbraco.Web.UI.Client/src/views/documenttypes/create.html +++ b/src/Umbraco.Web.UI.Client/src/views/documenttypes/create.html @@ -86,7 +86,8 @@ + text="Create template for the Parent Document Type"> + @@ -96,7 +97,8 @@ + text="Create template for the Item Document Type"> +
diff --git a/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html b/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html index b4f910fd7b..6f828ac49f 100644 --- a/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html +++ b/src/Umbraco.Web.UI.Client/src/views/logviewer/search.html @@ -39,7 +39,11 @@
- + + diff --git a/src/Umbraco.Web.UI.Client/src/views/packages/edit.html b/src/Umbraco.Web.UI.Client/src/views/packages/edit.html index 9f91e1d0f7..45e2a4e376 100644 --- a/src/Umbraco.Web.UI.Client/src/views/packages/edit.html +++ b/src/Umbraco.Web.UI.Client/src/views/packages/edit.html @@ -122,73 +122,81 @@ on-remove="vm.removeContentItem()"> - + + + + -
- + +
- + +
- + +
- + +
- + +
- + +
- + +
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/layouts.prevalues.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/layouts.prevalues.html index 15b66d856d..1240a61fbb 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/layouts.prevalues.html +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/layouts.prevalues.html @@ -1,50 +1,49 @@
-
+
-
+
- + -
+
- + + +
+ +
-
-
-
- -
- - {{ layout.name }} - (system layout) -
- -
- -
- -
- -
- - - +
+ + {{ layout.name }} + (system layout)
-
-
+
+ +
- +
+ +
+ + + +
+
-
+
+ + + +
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/orderDirection.prevalues.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/orderDirection.prevalues.html index 7ec0895936..b6028ad5bb 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/orderDirection.prevalues.html +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/orderDirection.prevalues.html @@ -2,10 +2,20 @@
  • - + +
  • - + +
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/radiobuttons/radiobuttons.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/radiobuttons/radiobuttons.html index 1c3aa898db..82952193e7 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/radiobuttons/radiobuttons.html +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/radiobuttons/radiobuttons.html @@ -3,7 +3,12 @@
  • - + +
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.prevalues.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.prevalues.html index ee2929e3ea..d70f469e6f 100644 --- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.prevalues.html +++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.prevalues.html @@ -2,22 +2,22 @@
- + +
- + +
diff --git a/src/Umbraco.Web.UI.Client/src/views/relationtypes/create.html b/src/Umbraco.Web.UI.Client/src/views/relationtypes/create.html index beb1962b4e..4d8d94e1aa 100644 --- a/src/Umbraco.Web.UI.Client/src/views/relationtypes/create.html +++ b/src/Umbraco.Web.UI.Client/src/views/relationtypes/create.html @@ -14,13 +14,19 @@
  • diff --git a/src/Umbraco.Web.UI.Client/src/views/relationtypes/views/relationType.html b/src/Umbraco.Web.UI.Client/src/views/relationtypes/views/relationType.html index 043ced9a5f..100d8d9d09 100644 --- a/src/Umbraco.Web.UI.Client/src/views/relationtypes/views/relationType.html +++ b/src/Umbraco.Web.UI.Client/src/views/relationtypes/views/relationType.html @@ -11,10 +11,18 @@
    • - + +
    • - + +