From d10ea08f0d2ad1d3362de10fcfd5f1c1aacec970 Mon Sep 17 00:00:00 2001 From: Bjarke Berg Date: Tue, 6 Jul 2021 18:28:01 +0200 Subject: [PATCH] Fixed issue from merge - MediaPickerWithCropsValueConverter was not update to inject _publishedValueFallback --- .../ValueConverters/MediaPickerWithCropsValueConverter.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs b/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs index 0aa6fca5a9..51bf3c477c 100644 --- a/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs +++ b/src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs @@ -15,15 +15,18 @@ namespace Umbraco.Cms.Core.PropertyEditors.ValueConverters { private readonly IPublishedSnapshotAccessor _publishedSnapshotAccessor; private readonly IPublishedUrlProvider _publishedUrlProvider; + private readonly IPublishedValueFallback _publishedValueFallback; private readonly IJsonSerializer _jsonSerializer; public MediaPickerWithCropsValueConverter( IPublishedSnapshotAccessor publishedSnapshotAccessor, IPublishedUrlProvider publishedUrlProvider, + IPublishedValueFallback publishedValueFallback, IJsonSerializer jsonSerializer) { _publishedSnapshotAccessor = publishedSnapshotAccessor ?? throw new ArgumentNullException(nameof(publishedSnapshotAccessor)); _publishedUrlProvider = publishedUrlProvider; + _publishedValueFallback = publishedValueFallback; _jsonSerializer = jsonSerializer; } @@ -77,7 +80,7 @@ namespace Umbraco.Cms.Core.PropertyEditors.ValueConverters // TODO: This should be optimized/cached, as calling Activator.CreateInstance is slow var mediaWithCropsType = typeof(MediaWithCrops<>).MakeGenericType(mediaItem.GetType()); - var mediaWithCrops = (MediaWithCrops)Activator.CreateInstance(mediaWithCropsType, mediaItem, localCrops); + var mediaWithCrops = (MediaWithCrops)Activator.CreateInstance(mediaWithCropsType, mediaItem, _publishedValueFallback, localCrops); mediaItems.Add(mediaWithCrops);