From d14a82d1bc3557a160224585f517b1f1eb14b4cd Mon Sep 17 00:00:00 2001
From: Mads Rasmussen <madsr@hey.com>
Date: Sun, 3 Mar 2024 21:52:35 +0100
Subject: [PATCH] add default kind

---
 .../models/entity-action.model.ts             | 26 +++++++++++--------
 .../documents/entity-actions/manifests.ts     |  1 -
 .../entity-actions/unpublish.action.ts        |  2 +-
 3 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/models/entity-action.model.ts b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/models/entity-action.model.ts
index 06cc8b974e..005b44829d 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/models/entity-action.model.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/models/entity-action.model.ts
@@ -10,10 +10,17 @@ export interface ManifestEntityAction<MetaType extends MetaEntityAction>
 	extends ManifestElementAndApi<UmbControllerHostElement, UmbEntityAction<MetaType>>,
 		ManifestWithDynamicConditions {
 	type: 'entityAction';
+	entityTypes: Array<string>;
 	meta: MetaType;
 }
 
-export interface MetaEntityAction {
+export interface MetaEntityAction {}
+export interface ManifestEntityActionDefaultKind extends ManifestEntityAction<MetaEntityActionDefaultKind> {
+	type: 'entityAction';
+	kind: 'default';
+}
+
+export interface MetaEntityActionDefaultKind extends MetaEntityAction {
 	/**
 	 * An icon to represent the action to be performed
 	 *
@@ -22,7 +29,7 @@ export interface MetaEntityAction {
 	 *   "icon-grid"
 	 * ]
 	 */
-	icon?: string;
+	icon: string;
 
 	/**
 	 * The friendly name of the action to perform
@@ -32,9 +39,7 @@ export interface MetaEntityAction {
 	 *   "Create Content Template"
 	 * ]
 	 */
-	label?: string;
-
-	entityTypes: Array<string>;
+	label: string;
 }
 
 // DELETE
@@ -43,7 +48,7 @@ export interface ManifestEntityActionDeleteKind extends ManifestEntityAction<Met
 	kind: 'delete';
 }
 
-export interface MetaEntityActionDeleteKind extends MetaEntityAction {
+export interface MetaEntityActionDeleteKind extends MetaEntityActionDefaultKind {
 	detailRepositoryAlias: string;
 	itemRepositoryAlias: string;
 }
@@ -54,7 +59,7 @@ export interface ManifestEntityActionRenameKind extends ManifestEntityAction<Met
 	kind: 'rename';
 }
 
-export interface MetaEntityActionRenameKind extends MetaEntityAction {
+export interface MetaEntityActionRenameKind extends MetaEntityActionDefaultKind {
 	renameRepositoryAlias: string;
 	itemRepositoryAlias: string;
 }
@@ -66,7 +71,7 @@ export interface ManifestEntityActionReloadTreeItemChildrenKind
 	kind: 'reloadTreeItemChildren';
 }
 
-export interface MetaEntityActionReloadTreeItemChildrenKind extends MetaEntityAction {}
+export interface MetaEntityActionReloadTreeItemChildrenKind extends MetaEntityActionDefaultKind {}
 
 // DUPLICATE
 export interface ManifestEntityActionDuplicateKind extends ManifestEntityAction<MetaEntityActionDuplicateKind> {
@@ -74,20 +79,19 @@ export interface ManifestEntityActionDuplicateKind extends ManifestEntityAction<
 	kind: 'duplicate';
 }
 
-export interface MetaEntityActionDuplicateKind extends MetaEntityAction {
+export interface MetaEntityActionDuplicateKind extends MetaEntityActionDefaultKind {
 	duplicateRepositoryAlias: string;
 	itemRepositoryAlias: string;
 	pickerModalAlias: string;
 }
 
 // MOVE
-
 export interface ManifestEntityActionMoveKind extends ManifestEntityAction<MetaEntityActionMoveKind> {
 	type: 'entityAction';
 	kind: 'move';
 }
 
-export interface MetaEntityActionMoveKind extends MetaEntityAction {
+export interface MetaEntityActionMoveKind extends MetaEntityActionDefaultKind {
 	moveRepositoryAlias: string;
 	itemRepositoryAlias: string;
 	pickerModalAlias: string;
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts
index 02e2584737..ec11ea9295 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/manifests.ts
@@ -89,7 +89,6 @@ const entityActions: Array<ManifestTypes> = [
 		meta: {
 			icon: 'icon-globe',
 			label: 'Unpublish',
-			repositoryAlias: UMB_DOCUMENT_DETAIL_REPOSITORY_ALIAS,
 			entityTypes: [UMB_DOCUMENT_ENTITY_TYPE],
 		},
 	},
diff --git a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/unpublish.action.ts b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/unpublish.action.ts
index 33b7447d7d..d241ac0f93 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/unpublish.action.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/documents/documents/entity-actions/unpublish.action.ts
@@ -5,7 +5,7 @@ import { UmbLanguageCollectionRepository } from '@umbraco-cms/backoffice/languag
 import { UmbEntityActionBase } from '@umbraco-cms/backoffice/entity-action';
 import { UmbVariantId } from '@umbraco-cms/backoffice/variant';
 
-export class UmbUnpublishDocumentEntityAction extends UmbEntityActionBase<never> {
+export class UmbUnpublishDocumentEntityAction extends UmbEntityActionBase<undefined> {
 	async execute() {
 		if (!this.args.unique) throw new Error('The document unique identifier is missing');