From d1a8f5fc80c8186647fc21967fb3fa8f38c739a0 Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Mon, 20 Mar 2023 15:48:32 +0100 Subject: [PATCH] move header app button kind interfaces into extensions registry --- .../libs/extensions-registry/header-app.models.ts | 12 ++++++++++++ .../libs/extensions-registry/models.ts | 4 +--- .../header-app/header-app-button.element.ts | 14 +------------- 3 files changed, 14 insertions(+), 16 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/libs/extensions-registry/header-app.models.ts b/src/Umbraco.Web.UI.Client/libs/extensions-registry/header-app.models.ts index 71e27cdcb1..bf3eff5244 100644 --- a/src/Umbraco.Web.UI.Client/libs/extensions-registry/header-app.models.ts +++ b/src/Umbraco.Web.UI.Client/libs/extensions-registry/header-app.models.ts @@ -11,3 +11,15 @@ export interface MetaHeaderApp { label: string; icon: string; } + +export interface ManifestHeaderAppButtonKind extends Omit { + type: 'headerApp'; + kind: 'button'; + meta: MetaHeaderAppButtonKind; +} + +export interface MetaHeaderAppButtonKind { + href: string; + label: string; + icon: string; +} diff --git a/src/Umbraco.Web.UI.Client/libs/extensions-registry/models.ts b/src/Umbraco.Web.UI.Client/libs/extensions-registry/models.ts index 9c3e63d71d..6d0228d82e 100644 --- a/src/Umbraco.Web.UI.Client/libs/extensions-registry/models.ts +++ b/src/Umbraco.Web.UI.Client/libs/extensions-registry/models.ts @@ -1,4 +1,3 @@ -import type { ManifestHeaderAppButtonKind } from '../../src/backoffice/shared/components/header-app/header-app-button.element'; import type { ManifestMenuItemTreeKind } from '../../src/backoffice/shared/components/tree/tree-menu-item/tree-menu-item.element'; import type { ManifestCollectionView } from './collection-view.models'; import type { ManifestDashboard } from './dashboard.models'; @@ -6,7 +5,7 @@ import type { ManifestDashboardCollection } from './dashboard-collection.models' import type { ManifestEntityAction } from './entity-action.models'; import type { ManifestEntityBulkAction } from './entity-bulk-action.models'; import type { ManifestExternalLoginProvider } from './external-login-provider.models'; -import type { ManifestHeaderApp } from './header-app.models'; +import type { ManifestHeaderApp, ManifestHeaderAppButtonKind } from './header-app.models'; import type { ManifestHealthCheck } from './health-check.models'; import type { ManifestPackageView } from './package-view.models'; import type { ManifestPropertyAction } from './property-action.models'; @@ -28,7 +27,6 @@ import type { ManifestModal } from './modal.models'; import type { ManifestStore, ManifestTreeStore } from './store.models'; import type { ClassConstructor } from '@umbraco-cms/models'; -export * from '../../src/backoffice/shared/components/header-app/header-app-button.element'; export * from '../../src/backoffice/shared/components/tree/tree-menu-item/tree-menu-item.element'; export * from './collection-view.models'; export * from './dashboard-collection.models'; diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/header-app/header-app-button.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/header-app/header-app-button.element.ts index 7f0857274e..7173cd2d0b 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/header-app/header-app-button.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/header-app/header-app-button.element.ts @@ -2,21 +2,9 @@ import { UUITextStyles } from '@umbraco-ui/uui-css/lib'; import { css, CSSResultGroup, html, LitElement } from 'lit'; import { customElement } from 'lit/decorators.js'; import { ifDefined } from 'lit/directives/if-defined.js'; -import { ManifestHeaderApp, ManifestKind } from '@umbraco-cms/extensions-registry'; +import { ManifestHeaderAppButtonKind, ManifestKind } from '@umbraco-cms/extensions-registry'; import { umbExtensionsRegistry } from '@umbraco-cms/extensions-api'; -export interface ManifestHeaderAppButtonKind extends Omit { - type: 'headerApp'; - kind: 'button'; - meta: MetaHeaderAppButtonKind; -} - -export interface MetaHeaderAppButtonKind { - href: string; - label: string; - icon: string; -} - const manifest: ManifestKind = { type: 'kind', alias: 'Umb.Kind.Button',