From 862b9493972887b4efdce7d49b818c6f5e059499 Mon Sep 17 00:00:00 2001 From: Bjarne Fyrstenborg Date: Wed, 31 Jul 2024 14:57:24 +0200 Subject: [PATCH 1/2] Use constant for language workspace alias --- .../language/workspace/language/language-workspace.context.ts | 3 ++- .../src/packages/language/workspace/language/manifests.ts | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts index 87d2816bd5..646982ea70 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts @@ -1,6 +1,7 @@ import { UmbLanguageDetailRepository } from '../../repository/index.js'; import type { UmbLanguageDetailModel } from '../../types.js'; import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js'; +import { UMB_LANGUAGE_WORKSPACE_ALIAS } from './manifests.js'; import { type UmbSubmittableWorkspaceContext, UmbSubmittableWorkspaceContextBase, @@ -27,7 +28,7 @@ export class UmbLanguageWorkspaceContext readonly validationErrors = this.#validationErrors.asObservable(); constructor(host: UmbControllerHost) { - super(host, 'Umb.Workspace.Language'); + super(host, UMB_LANGUAGE_WORKSPACE_ALIAS); this.routes.setRoutes([ { diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts index 6abbf9bf69..db9c56185f 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts @@ -6,10 +6,12 @@ import type { ManifestTypes, } from '@umbraco-cms/backoffice/extension-registry'; +export const UMB_LANGUAGE_WORKSPACE_ALIAS = 'Umb.Workspace.Language'; + const workspace: ManifestWorkspaces = { type: 'workspace', kind: 'routable', - alias: 'Umb.Workspace.Language', + alias: UMB_LANGUAGE_WORKSPACE_ALIAS, name: 'Language Workspace', api: () => import('./language-workspace.context.js'), meta: { From 3bd174faa81cc4d9f5167762aa405879c722c8eb Mon Sep 17 00:00:00 2001 From: Mads Rasmussen Date: Mon, 5 Aug 2024 12:27:46 +0200 Subject: [PATCH 2/2] move const to a constants file --- .../src/packages/language/workspace/language/constants.ts | 1 + .../language/workspace/language/language-workspace.context.ts | 2 +- .../src/packages/language/workspace/language/manifests.ts | 3 +-- 3 files changed, 3 insertions(+), 3 deletions(-) create mode 100644 src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/constants.ts diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/constants.ts b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/constants.ts new file mode 100644 index 0000000000..43f9eb4861 --- /dev/null +++ b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/constants.ts @@ -0,0 +1 @@ +export const UMB_LANGUAGE_WORKSPACE_ALIAS = 'Umb.Workspace.Language'; diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts index 646982ea70..934b5700d8 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/language-workspace.context.ts @@ -1,7 +1,7 @@ import { UmbLanguageDetailRepository } from '../../repository/index.js'; import type { UmbLanguageDetailModel } from '../../types.js'; import { UmbLanguageWorkspaceEditorElement } from './language-workspace-editor.element.js'; -import { UMB_LANGUAGE_WORKSPACE_ALIAS } from './manifests.js'; +import { UMB_LANGUAGE_WORKSPACE_ALIAS } from './constants.js'; import { type UmbSubmittableWorkspaceContext, UmbSubmittableWorkspaceContextBase, diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts index db9c56185f..ce98f96aaa 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/language/workspace/language/manifests.ts @@ -1,3 +1,4 @@ +import { UMB_LANGUAGE_WORKSPACE_ALIAS } from './constants.js'; import { UmbSubmitWorkspaceAction } from '@umbraco-cms/backoffice/workspace'; import type { ManifestWorkspaces, @@ -6,8 +7,6 @@ import type { ManifestTypes, } from '@umbraco-cms/backoffice/extension-registry'; -export const UMB_LANGUAGE_WORKSPACE_ALIAS = 'Umb.Workspace.Language'; - const workspace: ManifestWorkspaces = { type: 'workspace', kind: 'routable',