yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Had to remove the Resolution freezing idea because we are lazily instantiating the singleton instances, otherwise

Browse Source 
we have to instantiate them all on startup which means that all type searching happens on startup and not lazily which
is bad for performance. I don't think its a big deal that we're not freezing these objects, MVC doesn't freeze its singletons
and nobody seems to have a problem with it, people will just know not to modify these items after startup.
This commit is contained in:
shannon@ShandemVaio
2012-08-01 10:15:39 +06:00
parent bee357ffdc
commit d4806895a9
5 changed files with 5 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Umbraco.Core/Resolving/ManyObjectResolverBase.cs
View File

@@ -90,11 +90,7 @@ namespace Umbraco.Core.Resolving
protected IEnumerable<TResolved> Values
{
get
{
//we should not allow the returning/creating of objects if resolution is not yet frozen!
if (Resolution.IsFrozen)
throw new InvalidOperationException("Resolution is not frozen. It is not possible to instantiate and returng objects until resolution is frozen.");
{
switch (LifetimeScope)
{
case ObjectLifetimeScope.HttpRequest:
@@ -137,8 +133,7 @@ namespace Umbraco.Core.Resolving
/// </summary>
/// <param name="value">The type to remove.</param>
public void Remove(Type value)
{
Resolution.EnsureNotFrozen();
{
EnsureCorrectType(value);
using (new WriteLock(_lock))
{
@@ -161,7 +156,6 @@ namespace Umbraco.Core.Resolving
/// <param name="value">The object to be added.</param>
public void Add(Type value)
{
Resolution.EnsureNotFrozen();
EnsureCorrectType(value);
using (var l = new UpgradeableReadLock(_lock))
{
@@ -189,7 +183,6 @@ namespace Umbraco.Core.Resolving
/// </summary>
public void Clear()
{
Resolution.EnsureNotFrozen();
using (new WriteLock(_lock))
{
InstanceTypes.Clear();
@@ -203,7 +196,6 @@ namespace Umbraco.Core.Resolving
/// <param name="value">The object to insert.</param>
public void Insert(int index, Type value)
{
Resolution.EnsureNotFrozen();
EnsureCorrectType(value);
using (var l = new UpgradeableReadLock(_lock))
{