From 3f1a1ac063ae95f54d7a4998ae09f11ec8972f99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jesper=20M=C3=B8ller=20Jensen?= <26099018+JesmoDev@users.noreply.github.com> Date: Fri, 27 Jan 2023 03:43:20 +0100 Subject: [PATCH 1/6] fix current user --- .../src/backoffice/users/current-user/current-user.store.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/users/current-user/current-user.store.ts b/src/Umbraco.Web.UI.Client/src/backoffice/users/current-user/current-user.store.ts index 02f701b2ec..6f6dcdc54e 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/users/current-user/current-user.store.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/users/current-user/current-user.store.ts @@ -1,11 +1,12 @@ +import { umbUsersData } from '../../../core/mocks/data/users.data'; import { umbracoPath } from '@umbraco-cms/utils'; import type { UserDetails } from '@umbraco-cms/models'; import { UmbContextToken } from '@umbraco-cms/context-api'; import { ObjectState } from '@umbraco-cms/observable-api'; export class UmbCurrentUserStore { - - private _currentUser = new ObjectState(undefined); + //TODO: Temp solution to get a current user. Replace when we have a real user service + private _currentUser = new ObjectState(umbUsersData.getAll()[0]); public readonly currentUser = this._currentUser.asObservable(); /** From 06f579930d520a8365767bdc4547d8bf1687ff58 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:15:12 +0100 Subject: [PATCH 2/6] Update README.md --- src/Umbraco.Web.UI.Client/.github/README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Umbraco.Web.UI.Client/.github/README.md b/src/Umbraco.Web.UI.Client/.github/README.md index 68201b62c3..9cc0f21d62 100644 --- a/src/Umbraco.Web.UI.Client/.github/README.md +++ b/src/Umbraco.Web.UI.Client/.github/README.md @@ -39,3 +39,7 @@ See the Main branch in action here as an [Azure Static Web App](https://ashy-bay ### Storybook Storybook is also being built and deployed automatically on the Main branch, including a preview URL on each pull request. See it in action on this [Azure Static Web App](https://ambitious-stone-0033b3603.1.azurestaticapps.net/). + +## Contributing + +We accept contributions to this project. However be aware that we are mainly working on a private backlog, so not everyone will be immediately obvious. If you want to get started on contributing, please read the [contribute space](https://github.com/umbraco/Umbraco.CMS.Backoffice/contribute) where you will be able to find the guidelines on how to contribute as well as a list of good first issues. From 5a05226ef9d7a36817b9840589543a2674ae4790 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:22:07 +0100 Subject: [PATCH 3/6] Update CONTRIBUTING.md --- src/Umbraco.Web.UI.Client/.github/CONTRIBUTING.md | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/.github/CONTRIBUTING.md b/src/Umbraco.Web.UI.Client/.github/CONTRIBUTING.md index 24741b1823..e38509ec18 100644 --- a/src/Umbraco.Web.UI.Client/.github/CONTRIBUTING.md +++ b/src/Umbraco.Web.UI.Client/.github/CONTRIBUTING.md @@ -13,15 +13,12 @@ Here is the LIT documentation and playground: [https://lit.dev](https://lit.dev) ### What is the process of contribution? -* Umbraco HQ owns the Management API on the backend -* Features can be worked on in the frontend when there is an API, or otherwise, if no API is required -* A contribution should be made in a fork of the backoffice repository -* Once a contribution is ready, a pull request should be made towards the backoffice repository, where HQ will assign a reviewer -* A pull request should always indicate what part of a feature it tries to solve, i.e. which labels can be removed from the issue on the projects board - -### How to work with Github Projects - -TBD +- Read the [README](README.md) to learn how to get the project up and running +- Find an issue marked as [community/up-for-grabs](https://github.com/umbraco/Umbraco.CMS.Backoffice/issues?q=is%3Aissue+is%3Aopen+label%3Acommunity%2Fup-for-grabs) - note that some are also marked [good first issue](https://github.com/umbraco/Umbraco.CMS.Backoffice/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) which indicates they are simple to get started on +- Umbraco HQ owns the Management API on the backend, so features can be worked on in the frontend only when there is an API, or otherwise, if no API is required +- A contribution should be made in a fork of the repository +- Once a contribution is ready, a pull request should be made towards this repository and HQ will assign a reviewer +- A pull request should always indicate what part of a feature it tries to solve, i.e. does it close the targeted issue (if any) or does the developer expect Umbraco HQ to take over ## Contributing in general terms From 03e3f90bec47a3f8f6b177a688c43f33081dddeb Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:35:53 +0100 Subject: [PATCH 4/6] Create LICENSE --- src/Umbraco.Web.UI.Client/LICENSE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 src/Umbraco.Web.UI.Client/LICENSE diff --git a/src/Umbraco.Web.UI.Client/LICENSE b/src/Umbraco.Web.UI.Client/LICENSE new file mode 100644 index 0000000000..f88d3c2e3c --- /dev/null +++ b/src/Umbraco.Web.UI.Client/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2023 Umbraco HQ + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software"), to deal +in the Software without restriction, including without limitation the rights +to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +copies of the Software, and to permit persons to whom the Software is +furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all +copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +SOFTWARE. From ba3f2761f4943832db9af41022fd2301e976e33f Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:38:03 +0100 Subject: [PATCH 5/6] Create pull_request_template --- .../.github/pull_request_template | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 src/Umbraco.Web.UI.Client/.github/pull_request_template diff --git a/src/Umbraco.Web.UI.Client/.github/pull_request_template b/src/Umbraco.Web.UI.Client/.github/pull_request_template new file mode 100644 index 0000000000..01c2c0fe8a --- /dev/null +++ b/src/Umbraco.Web.UI.Client/.github/pull_request_template @@ -0,0 +1,30 @@ + + +## Description + + + +## Types of changes + + + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to change) +- [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets) + +## Motivation and context + + + +## How to test? + +## Screenshots (if appropriate) + +## Checklist + + + +- [ ] If my change requires a change to the documentation, I have updated the documentation in this pull request. +- [ ] I have read the **[CONTRIBUTING](<(https://github.com/umbraco/Umbraco.CMS.Backoffice/blob/main/.github/CONTRIBUTING.md)>)** document. +- [ ] I have added tests to cover my changes. From 246777d46408eef9ad313afae6f6dbf2e0478263 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Fri, 27 Jan 2023 11:39:01 +0100 Subject: [PATCH 6/6] Update issue templates --- .../.github/ISSUE_TEMPLATE/feature_request.md | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 src/Umbraco.Web.UI.Client/.github/ISSUE_TEMPLATE/feature_request.md diff --git a/src/Umbraco.Web.UI.Client/.github/ISSUE_TEMPLATE/feature_request.md b/src/Umbraco.Web.UI.Client/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000000..bbcbbe7d61 --- /dev/null +++ b/src/Umbraco.Web.UI.Client/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here.