diff --git a/src/Umbraco.Web/ITagQuery.cs b/src/Umbraco.Web/ITagQuery.cs
index 031061ad01..1b96ea330c 100644
--- a/src/Umbraco.Web/ITagQuery.cs
+++ b/src/Umbraco.Web/ITagQuery.cs
@@ -24,7 +24,7 @@ namespace Umbraco.Web
///
/// Gets all media tagged with any tag in the specified group.
///
- IEnumerable GetMediaByTagGroup(string group, string culture);
+ IEnumerable GetMediaByTagGroup(string group, string culture = null);
///
/// Gets all tags.
diff --git a/src/Umbraco.Web/PublishedContentQuery.cs b/src/Umbraco.Web/PublishedContentQuery.cs
index 363607fbcb..e0fac5773f 100644
--- a/src/Umbraco.Web/PublishedContentQuery.cs
+++ b/src/Umbraco.Web/PublishedContentQuery.cs
@@ -22,7 +22,6 @@ namespace Umbraco.Web
///
public class PublishedContentQuery : IPublishedContentQuery
{
- private readonly IPublishedContentQuery _query;
private readonly IPublishedContentCache _contentCache;
private readonly IPublishedMediaCache _mediaCache;
@@ -37,79 +36,52 @@ namespace Umbraco.Web
_mediaCache = mediaCache ?? throw new ArgumentNullException(nameof(mediaCache));
}
- ///
- /// Constructor used to wrap the ITypedPublishedContentQuery object passed in
- ///
- ///
- public PublishedContentQuery(IPublishedContentQuery query)
- {
- _query = query ?? throw new ArgumentNullException(nameof(query));
- }
-
#region Content
public IPublishedContent Content(int id)
{
- return _query == null
- ? ItemById(id, _contentCache)
- : _query.Content(id);
+ return ItemById(id, _contentCache);
}
public IPublishedContent Content(Guid id)
{
- return _query == null
- ? ItemById(id, _contentCache)
- : _query.Content(id);
+ return ItemById(id, _contentCache);
}
public IPublishedContent Content(Udi id)
{
if (!(id is GuidUdi udi)) return null;
- return _query == null
- ? ItemById(udi.Guid, _contentCache)
- : _query.Content(udi.Guid);
+ return ItemById(udi.Guid, _contentCache);
}
public IPublishedContent ContentSingleAtXPath(string xpath, params XPathVariable[] vars)
{
- return _query == null
- ? ItemByXPath(xpath, vars, _contentCache)
- : _query.ContentSingleAtXPath(xpath, vars);
+ return ItemByXPath(xpath, vars, _contentCache);
}
public IEnumerable Content(IEnumerable ids)
{
- return _query == null
- ? ItemsByIds(_contentCache, ids)
- : _query.Content(ids);
+ return ItemsByIds(_contentCache, ids);
}
public IEnumerable Content(IEnumerable ids)
{
- return _query == null
- ? ItemsByIds(_contentCache, ids)
- : _query.Content(ids);
+ return ItemsByIds(_contentCache, ids);
}
public IEnumerable ContentAtXPath(string xpath, params XPathVariable[] vars)
{
- return _query == null
- ? ItemsByXPath(xpath, vars, _contentCache)
- : _query.ContentAtXPath(xpath, vars);
+ return ItemsByXPath(xpath, vars, _contentCache);
}
public IEnumerable ContentAtXPath(XPathExpression xpath, params XPathVariable[] vars)
{
- return _query == null
- ? ItemsByXPath(xpath, vars, _contentCache)
- : _query.ContentAtXPath(xpath, vars);
+ return ItemsByXPath(xpath, vars, _contentCache);
}
public IEnumerable ContentAtRoot()
{
- return _query == null
- ? ItemsAtRoot(_contentCache)
- : _query.ContentAtRoot();
+ return ItemsAtRoot(_contentCache);
}
#endregion
@@ -118,45 +90,33 @@ namespace Umbraco.Web
public IPublishedContent Media(int id)
{
- return _query == null
- ? ItemById(id, _mediaCache)
- : _query.Media(id);
+ return ItemById(id, _mediaCache);
}
public IPublishedContent Media(Guid id)
{
- return _query == null
- ? ItemById(id, _mediaCache)
- : _query.Media(id);
+ return ItemById(id, _mediaCache);
}
public IPublishedContent Media(Udi id)
{
if (!(id is GuidUdi udi)) return null;
- return _query == null
- ? ItemById(udi.Guid, _mediaCache)
- : _query.Media(udi.Guid);
+ return ItemById(udi.Guid, _mediaCache);
}
public IEnumerable Media(IEnumerable ids)
{
- return _query == null
- ? ItemsByIds(_mediaCache, ids)
- : _query.Media(ids);
+ return ItemsByIds(_mediaCache, ids);
}
public IEnumerable Media(IEnumerable ids)
{
- return _query == null
- ? ItemsByIds(_mediaCache, ids)
- : _query.Media(ids);
+ return ItemsByIds(_mediaCache, ids);
}
public IEnumerable MediaAtRoot()
{
- return _query == null
- ? ItemsAtRoot(_mediaCache)
- : _query.MediaAtRoot();
+ return ItemsAtRoot(_mediaCache);
}
@@ -231,8 +191,6 @@ namespace Umbraco.Web
{
//TODO: Can we inject IExamineManager?
- if (_query != null) return _query.Search(skip, take, out totalRecords, term, useWildCards, indexName);
-
var indexer = string.IsNullOrEmpty(indexName)
? Examine.ExamineManager.Instance.GetIndexer(Constants.Examine.ExternalIndexer)
: Examine.ExamineManager.Instance.GetIndexer(indexName);
@@ -261,7 +219,6 @@ namespace Umbraco.Web
///
public IEnumerable Search(int skip, int take, out int totalRecords, ISearchCriteria criteria, Examine.ISearcher searchProvider = null)
{
- if (_query != null) return _query.Search(skip, take, out totalRecords, criteria, searchProvider);
//TODO: Can we inject IExamineManager?
diff --git a/src/Umbraco.Web/UmbracoHelper.cs b/src/Umbraco.Web/UmbracoHelper.cs
index 1ce7e51a7f..ea66ec13da 100644
--- a/src/Umbraco.Web/UmbracoHelper.cs
+++ b/src/Umbraco.Web/UmbracoHelper.cs
@@ -33,7 +33,7 @@ namespace Umbraco.Web
private readonly CacheHelper _appCache;
private IUmbracoComponentRenderer _componentRenderer;
- private PublishedContentQuery _query;
+ private IPublishedContentQuery _query;
private MembershipHelper _membershipHelper;
private ITagQuery _tag;
private IDataTypeService _dataTypeService;
@@ -133,10 +133,8 @@ namespace Umbraco.Web
///
/// Gets the query context.
///
- public PublishedContentQuery ContentQuery => _query ??
- (_query = _iQuery != null
- ? new PublishedContentQuery(_iQuery)
- : new PublishedContentQuery(UmbracoContext.ContentCache, UmbracoContext.MediaCache));
+ public IPublishedContentQuery ContentQuery => _query ??
+ (_query = new PublishedContentQuery(UmbracoContext.ContentCache, UmbracoContext.MediaCache));
///
/// Gets the Umbraco context.