yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow installing when connection string is configured

Browse Source 
Disable unattended installs by default and enable install empty
database.

Fix create user step by adding back the HasSomeNonDefaultUser check, if
the check is missing the installer will skip creating the configured user
since the second time NewInstallStep.RequiresExecution is called, Umbraco
has been installed and it would return false and the user would never be
created.
This commit is contained in:
Rasmus John Pedersen
2020-12-16 11:03:23 +01:00
parent bbe2941d25
commit d7801a86ff
3 changed files with 34 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Umbraco.Web/Install/InstallSteps/NewInstallStep.cs
View File

@@ -141,14 +141,15 @@ namespace Umbraco.Web.Install.InstallSteps
// left a version number in there but cleared out their db conn string, in that case, it's really a new install.
if (_globalSettings.ConfigurationStatus.IsNullOrWhiteSpace() == false && databaseSettings != null) return false;
if (_databaseBuilder.IsConnectionStringConfigured(databaseSettings) && _databaseBuilder.IsDatabaseConfigured)
return _databaseBuilder.IsUmbracoInstalled() == false;
// if Umbraco is already installed there's already users in the database, skip this step
if (_databaseBuilder.IsConnectionStringConfigured(databaseSettings) && _databaseBuilder.IsDatabaseConfigured && _databaseBuilder.IsUmbracoInstalled())
return _databaseBuilder.HasSomeNonDefaultUser() == false;
// In this one case when it's a brand new install and nothing has been configured, make sure the
// back office cookie is cleared so there's no old cookies lying around causing problems
_http.ExpireCookie(Current.Configs.Settings().Security.AuthCookieName);
return true;
return true;
}
}
}