From d7b25fc4dc1eb81ccc442cbe363897fcbdd516af Mon Sep 17 00:00:00 2001
From: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Date: Mon, 14 Oct 2019 17:06:36 +0200
Subject: [PATCH] =?UTF-8?q?Replace=20checkbox=20with=20umb-checkbox=20in?=
 =?UTF-8?q?=20listview=20publish=20and=20unpu=E2=80=A6=20(#6544)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../src/views/content/overlays/publish.html   |  6 +--
 .../content/overlays/publishdescendants.html  |  4 +-
 .../src/views/content/overlays/save.html      |  6 +--
 .../src/views/content/overlays/schedule.html  |  4 +-
 .../views/content/overlays/sendtopublish.html |  4 +-
 .../src/views/content/overlays/unpublish.html |  4 +-
 .../listview/listview.controller.js           |  1 +
 .../listview/overlays/listviewpublish.html    | 45 ++++++++++---------
 .../overlays/listviewunpublish.controller.js  |  1 -
 .../listview/overlays/listviewunpublish.html  | 39 +++++++++-------
 10 files changed, 62 insertions(+), 52 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html
index a9afdffda6..d4a3bdd2a0 100644
--- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html
+++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html
@@ -1,6 +1,6 @@
 <div ng-controller="Umbraco.Overlays.PublishController as vm">
 
-    <div style="margin-bottom: 15px;">
+    <div class="mb3">
         <p>{{vm.headline}}</p>
     </div>
 
@@ -48,14 +48,14 @@
     </div>
 
     <div class="umb-list umb-list--condensed" ng-if="!vm.loading && vm.hasPristineVariants">
-        <div style="margin-bottom: 15px; font-weight: bold;">
+        <div class="bold mb3">
             <p><localize key="content_publishedLanguages"></localize></p>
         </div>
 
         <div class="umb-list-item" ng-repeat="variant in vm.variants | filter:vm.pristineVariantFilter">
             <div>
                 <div style="margin-bottom: 2px;">
-                    <span>{{ variant.language.name }}</span>
+                    <span>{{variant.language.name}}</span>
                     <strong ng-if="variant.language.isMandatory" class="umb-control-required">*</strong>
                 </div>
 
diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html
index 4dcaeb6572..5002007e20 100644
--- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html
+++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html
@@ -49,8 +49,8 @@
                             server-validation-field="{{variant.htmlId}}"/>
 
                         <div>
-                            <label for="{{variant.htmlId}}" style="margin-bottom: 0;">
-                                <span>{{ variant.language.name }}</span>
+                            <label for="{{variant.htmlId}}" class="mb0">
+                                <span>{{variant.language.name}}</span>
 
                                 <span class="db umb-list-item__description" ng-if="!publishVariantSelectorForm.publishVariantSelector.$invalid && !(variant.notifications && variant.notifications.length > 0)">
                                     <umb-variant-state variant="variant"></umb-variant-state>
diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html
index 018a1b7add..4ca52ffc85 100644
--- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html
+++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/save.html
@@ -1,13 +1,11 @@
 <div ng-controller="Umbraco.Overlays.SaveContentController as vm">
 
-
-
     <div ng-if="vm.loading" style="min-height: 50px; position: relative;">
         <umb-load-indicator></umb-load-indicator>
     </div>
 
     <div ng-if="!vm.loading">
-        <div style="margin-bottom: 15px;">
+        <div class="mb3">
             <p>
                 <localize ng-if="!vm.isNew" key="content_languagesToSave"></localize>
                 <localize ng-if="vm.isNew" key="content_languagesToSaveForFirstTime"></localize>
@@ -53,7 +51,7 @@
         </div>
 
         <div class="umb-list umb-list--condensed" ng-if="vm.hasPristineVariants">
-            <div style="margin-bottom: 15px; font-weight: bold;">
+            <div class="bold mb3">
                 <p>
                     <localize ng-if="!vm.isNew" key="content_unmodifiedLanguages"></localize>
                     <localize ng-if="vm.isNew" key="content_untouchedLanguagesForFirstTime"></localize>
diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html
index a0fe7baec2..4b0bd55e49 100644
--- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html
+++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/schedule.html
@@ -3,7 +3,7 @@
     <!-- invariant nodes -->
     <div ng-if="vm.variants.length === 1">
 
-        <div style="margin-bottom: 15px;">
+        <div class="mb3">
             <p><localize key="content_schedulePublishHelp"></localize></p>
         </div>
 
@@ -78,7 +78,7 @@
     <!-- nodes with variants -->
     <div ng-if="vm.variants.length > 1">
 
-        <div style="margin-bottom: 15px;">
+        <div class="mb3">
             <p><localize key="content_languagesToSchedule"></localize></p>
         </div>
 
diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html
index b1da239b1f..55e2121d28 100644
--- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html
+++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/sendtopublish.html
@@ -1,6 +1,6 @@
 <div ng-controller="Umbraco.Overlays.SendToPublishController as vm">
 
-    <div style="margin-bottom: 15px;">
+    <div class="mb3">
         <p><localize key="content_languagesToSendForApproval"></localize></p>
     </div>
 
@@ -46,7 +46,7 @@
     </div>
 
     <div class="umb-list umb-list--condensed" ng-if="!vm.loading && (vm.variants | filter:vm.unmodifiedVariantFilter).length > 0">
-        <div style="margin-bottom: 15px; font-weight: bold;">
+        <div class="bold mb3">
             <p><localize key="content_unmodifiedLanguages"></localize></p>
         </div>
 
diff --git a/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html b/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html
index 2c6dea3a6f..32b1d38841 100644
--- a/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html
+++ b/src/Umbraco.Web.UI.Client/src/views/content/overlays/unpublish.html
@@ -1,6 +1,6 @@
 <div ng-controller="Umbraco.Overlays.UnpublishController as vm">
 
-    <!-- 1 language -->
+    <!-- Single language -->
     <div ng-if="vm.variants.length === 1">
         <p><localize key="prompt_confirmUnpublish"></localize></p>
     </div>
@@ -43,7 +43,7 @@
         </div>
             
         <div class="umb-list umb-list--condensed" ng-if="!vm.loading && (vm.variants | filter:vm.unpublishedVariantFilter).length > 0">
-            <div style="margin-bottom: 15px; font-weight: bold;">
+            <div class="bold mb3">
                 <p><localize key="content_unpublishedLanguages"></localize></p>
             </div>
     
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.controller.js
index e50411fe8b..748a0c0d0f 100644
--- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.controller.js
@@ -489,6 +489,7 @@ function listViewController($scope, $routeParams, $injector, $timeout, currentUs
         const dialog = {
             view: "views/propertyeditors/listview/overlays/listviewunpublish.html",
             submitButtonLabelKey: "actions_unpublish",
+            submitButtonStyle: "warning",
             submit: function (model) {
 
                 // create a comma separated array of selected cultures
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewpublish.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewpublish.html
index ebdc1eb4c4..abe1db73d2 100644
--- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewpublish.html
+++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewpublish.html
@@ -1,41 +1,46 @@
 <div ng-controller="Umbraco.Overlays.ListViewPublishController as vm">
 
+        <!-- Single language -->
         <div ng-if="!vm.languages">
             <p><localize key="prompt_confirmListViewPublish"></localize></p>
         </div>
-
-        <div ng-if="vm.languages.length > 1">
+        
+        <div ng-if="vm.loading" style="min-height: 50px; position: relative;">
+                <umb-load-indicator></umb-load-indicator>
+        </div>
+        
+        <!-- Multiple languages -->
+        <div ng-if="vm.languages.length > 1 && !vm.loading">
 
             <div class="mb3">
                 <p><localize key="content_languagesToPublish"></localize></p>
             </div>
 
-            <div ng-if="vm.loading" style="min-height: 50px; position: relative;">
-                <umb-load-indicator></umb-load-indicator>
-            </div>
+            <div class="umb-list umb-list--condensed">
 
-            <div class="umb-list umb-list--condensed" ng-if="!vm.loading">
+                <div class="bold mb1">
+                    <localize key="treeHeaders_languages"></localize>
+                </div>
 
                 <div class="umb-list-item" ng-repeat="language in vm.languages track by language.id">
                     <ng-form name="publishLanguageSelectorForm">
                         <div class="flex">
-                            <input
-                                id="{{language.culture}}"
-                                name="publishLanguageSelector"
-                                type="checkbox"
-                                ng-model="language.publish"
-                                ng-change="vm.changeSelection(language)"
-                                style="margin-right: 8px;" />
+
+                            <umb-checkbox input-id="publishLanguage_{{language.culture}}"
+                                          name="publishLanguageSelector"
+                                          model="language.publish"
+                                          on-change="vm.changeSelection(language)" />
+
                             <div>
-                                <label for="{{language.culture}}" style="margin-bottom: 2px;">
-                                    <span>{{ language.name }}</span>
+                                <label for="publishLanguage_{{language.culture}}" class="mb0">
+                                    <span>{{language.name}}</span>
+
+                                    <span class="db umb-list-item__description">
+                                        <span ng-if="language.isMandatory"><localize key="languages_mandatoryLanguage"></localize></span>
+                                    </span>
                                 </label>
+                            </div>    
 
-                                <div class="umb-list-item__description">
-                                    <span ng-if="language.isMandatory"><localize key="languages_mandatoryLanguage"></localize></span>
-                                </div>
-
-                            </div>
                         </div>
 
                     </ng-form>
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.controller.js b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.controller.js
index b6a236700e..46604227da 100644
--- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.controller.js
+++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.controller.js
@@ -56,7 +56,6 @@
             }
 
             vm.loading = false;
-            
         }
 
         onInit();
diff --git a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.html b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.html
index a171fb1327..f59b351181 100644
--- a/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.html
+++ b/src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/overlays/listviewunpublish.html
@@ -1,12 +1,16 @@
 <div ng-controller="Umbraco.Overlays.ListViewUnpublishController as vm">
 
-        <!-- 1 language -->
+        <!-- Single language -->
         <div ng-if="!vm.languages">
             <p><localize key="prompt_confirmListViewUnpublish"></localize></p>
         </div>
 
+        <div ng-if="vm.loading" style="min-height: 50px; position: relative;">
+                <umb-load-indicator></umb-load-indicator>
+        </div>
+
         <!-- Multiple languages -->
-        <div ng-if="vm.languages.length > 0">
+        <div ng-if="vm.languages.length > 1 && !vm.loading">
 
             <div class="mb3">
                 <p><localize key="content_languagesToUnpublish"></localize></p>
@@ -14,26 +18,29 @@
 
             <div class="umb-list umb-list--condensed">
 
+                <div class="bold mb1">
+                    <localize key="treeHeaders_languages"></localize>
+                </div>
+
                 <div class="umb-list-item" ng-repeat="language in vm.languages track by language.id">
                     <ng-form name="unpublishLanguageSelectorForm">
                         <div class="flex">
-                            <input id="{{language.culture}}"
-                                    name="unpublishLanguageSelector"
-                                    type="checkbox"
-                                    ng-model="language.unpublish"
-                                    ng-change="vm.changeSelection(language)"
-                                    ng-disabled="language.disabled"
-                                    style="margin-right: 8px;" />
+
+                            <umb-checkbox input-id="unpublishLanguage_{{language.culture}}"
+                                          name="unpublishLanguageSelector"
+                                          model="language.unpublish"
+                                          on-change="vm.changeSelection(language)" />
+
                             <div>
-                                <label for="{{language.culture}}" style="margin-bottom: 2px;">
-                                    <span>{{ language.name }}</span>
+                                <label for="unpublishLanguage_{{language.culture}}" class="mb0">
+                                    <span>{{language.name}}</span>
+
+                                    <span class="db umb-list-item__description">
+                                        <span ng-if="language.isMandatory"><localize key="languages_mandatoryLanguage"></localize></span>
+                                    </span>
                                 </label>
-
-                                <div class="umb-list-item__description">
-                                    <span ng-if="language.isMandatory"><localize key="languages_mandatoryLanguage"></localize></span>
-                                </div>
-
                             </div>
+
                         </div>
 
                     </ng-form>