From d9552ce04ab89ee52d87299efa236dbf9c57ccf3 Mon Sep 17 00:00:00 2001 From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com> Date: Thu, 25 Aug 2022 15:13:00 +0200 Subject: [PATCH] check that returned js might potentially be a new element --- .../extension/create-extension-element.function.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/core/extension/create-extension-element.function.ts b/src/Umbraco.Web.UI.Client/src/core/extension/create-extension-element.function.ts index b8ac4eb38b..b090e73053 100644 --- a/src/Umbraco.Web.UI.Client/src/core/extension/create-extension-element.function.ts +++ b/src/Umbraco.Web.UI.Client/src/core/extension/create-extension-element.function.ts @@ -1,13 +1,11 @@ -import { ManifestCore } from '../models'; +import { ManifestTypes } from '../models'; import { hasDefaultExport } from './has-default-export.function'; import { isManifestElementType } from './is-extension.function'; import { loadExtension } from './load-extension.function'; -export async function createExtensionElement(manifest: ManifestCore): Promise { - console.log('🚀 ~ file: create-extension-element.function.ts ~ line 7 ~ createExtensionElement ~ manifest', manifest); +export async function createExtensionElement(manifest: ManifestTypes): Promise { //TODO: Write tests for these extension options: const js = await loadExtension(manifest); - console.log('🚀 ~ file: create-extension-element.function.ts ~ line 9 ~ createExtensionElement ~ js', js); if (isManifestElementType(manifest) && manifest.elementName) { // created by manifest method providing HTMLElement return document.createElement(manifest.elementName); @@ -17,9 +15,9 @@ export async function createExtensionElement(manifest: ManifestCore): Promise