From dc7b5bae9b972e1e6c3b6d4ca4843463f89c697c Mon Sep 17 00:00:00 2001 From: Sebastiaan Janssen Date: Thu, 2 Nov 2017 16:28:25 +0100 Subject: [PATCH] Fix U4-10618 - AbstractConfigCheck SuccessMessages are missing CurrentValue --- .../HealthCheck/Checks/Config/AbstractConfigCheck.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs b/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs index 2cec88d616..af5f94f277 100644 --- a/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs +++ b/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs @@ -140,7 +140,7 @@ namespace Umbraco.Web.HealthCheck.Checks.Config public override IEnumerable GetStatus() { - var successMessage = string.Format(CheckSuccessMessage, FileName, XPath, Values, CurrentValue); + var successMessage = string.Format(CheckSuccessMessage, FileName, XPath, Values); var configValue = _configurationService.GetConfigurationValue(); if (configValue.Success == false) @@ -156,6 +156,9 @@ namespace Umbraco.Web.HealthCheck.Checks.Config CurrentValue = configValue.Result; + // need to update the successMessage with the CurrentValue + successMessage = string.Format(CheckSuccessMessage, FileName, XPath, Values, CurrentValue); + var valueFound = Values.Any(value => string.Equals(CurrentValue, value.Value, StringComparison.InvariantCultureIgnoreCase)); if (ValueComparisonType == ValueComparisonType.ShouldEqual && valueFound || ValueComparisonType == ValueComparisonType.ShouldNotEqual && valueFound == false) {