From dc7b83ca6c789e83f3f9039eb3eaa3a6cdd72ec5 Mon Sep 17 00:00:00 2001 From: Mike Date: Mon, 8 Jan 2018 17:30:11 +0000 Subject: [PATCH] Add initial test fix for SimilarNodeName when a node has no name. --- .../Persistence/Repositories/SimilarNodeName.cs | 6 ++++++ .../Persistence/Repositories/SimilarNodeNameTests.cs | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Core/Persistence/Repositories/SimilarNodeName.cs b/src/Umbraco.Core/Persistence/Repositories/SimilarNodeName.cs index 371f73b27f..df31ae894a 100644 --- a/src/Umbraco.Core/Persistence/Repositories/SimilarNodeName.cs +++ b/src/Umbraco.Core/Persistence/Repositories/SimilarNodeName.cs @@ -20,6 +20,12 @@ namespace Umbraco.Core.Persistence.Repositories var name = Name; + // cater for instances where node has no name. + if(name.Length == 0) + { + return _numPos; + } + if (name[name.Length - 1] != ')') return _numPos = -1; diff --git a/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs b/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs index 72f3e39874..275398091b 100644 --- a/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs +++ b/src/Umbraco.Tests/Persistence/Repositories/SimilarNodeNameTests.cs @@ -24,7 +24,8 @@ namespace Umbraco.Tests.Persistence.Repositories [TestCase("Alpha (10)", "Alpha (2)", +1)] // this is the real stuff [TestCase("Kilo", "Golf (2)", +1)] [TestCase("Kilo (1)", "Golf (2)", +1)] - public void ComparerTest(string name1, string name2, int expected) + [TestCase("", "", 0)] + public void ComparerTest(string name1, string name2, int expected) { var comparer = new SimilarNodeName.Comparer();