From deefad4b89dd4c5635440849bb4725f466b3d05c Mon Sep 17 00:00:00 2001
From: Stephan <stephane@umbraco.dk>
Date: Mon, 20 May 2019 16:56:31 +0200
Subject: [PATCH] Move ILogger/IProfiler/IProfilingLogger to abstractions

---
 .../Logging/DisposableTimer.cs                            | 2 +-
 .../Logging/ILogger.cs                                    | 0
 .../Logging/IProfiler.cs                                  | 0
 .../Logging/IProfilingLogger.cs                           | 0
 .../Logging/LogLevel.cs                                   | 0
 .../Logging/LoggerExtensions.cs                           | 0
 .../Logging/ProfilerExtensions.cs                         | 0
 .../Logging/ProfilingLogger.cs                            | 0
 src/Umbraco.Core/Umbraco.Core.csproj                      | 8 --------
 9 files changed, 1 insertion(+), 9 deletions(-)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/DisposableTimer.cs (98%)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/ILogger.cs (100%)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/IProfiler.cs (100%)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/IProfilingLogger.cs (100%)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/LogLevel.cs (100%)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/LoggerExtensions.cs (100%)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/ProfilerExtensions.cs (100%)
 rename src/{Umbraco.Core => Umbraco.Abstractions}/Logging/ProfilingLogger.cs (100%)

diff --git a/src/Umbraco.Core/Logging/DisposableTimer.cs b/src/Umbraco.Abstractions/Logging/DisposableTimer.cs
similarity index 98%
rename from src/Umbraco.Core/Logging/DisposableTimer.cs
rename to src/Umbraco.Abstractions/Logging/DisposableTimer.cs
index ed98e5cfab..d854813b7d 100644
--- a/src/Umbraco.Core/Logging/DisposableTimer.cs
+++ b/src/Umbraco.Abstractions/Logging/DisposableTimer.cs
@@ -80,7 +80,7 @@ namespace Umbraco.Core.Logging
 
             if ((Stopwatch.ElapsedMilliseconds >= _thresholdMilliseconds || _failed)
                 && _loggerType != null && _logger != null
-                && (_endMessage.IsNullOrWhiteSpace() == false || _failed))
+                && (string.IsNullOrWhiteSpace(_endMessage) == false || _failed))
             {
                 if (_failed)
                 {
diff --git a/src/Umbraco.Core/Logging/ILogger.cs b/src/Umbraco.Abstractions/Logging/ILogger.cs
similarity index 100%
rename from src/Umbraco.Core/Logging/ILogger.cs
rename to src/Umbraco.Abstractions/Logging/ILogger.cs
diff --git a/src/Umbraco.Core/Logging/IProfiler.cs b/src/Umbraco.Abstractions/Logging/IProfiler.cs
similarity index 100%
rename from src/Umbraco.Core/Logging/IProfiler.cs
rename to src/Umbraco.Abstractions/Logging/IProfiler.cs
diff --git a/src/Umbraco.Core/Logging/IProfilingLogger.cs b/src/Umbraco.Abstractions/Logging/IProfilingLogger.cs
similarity index 100%
rename from src/Umbraco.Core/Logging/IProfilingLogger.cs
rename to src/Umbraco.Abstractions/Logging/IProfilingLogger.cs
diff --git a/src/Umbraco.Core/Logging/LogLevel.cs b/src/Umbraco.Abstractions/Logging/LogLevel.cs
similarity index 100%
rename from src/Umbraco.Core/Logging/LogLevel.cs
rename to src/Umbraco.Abstractions/Logging/LogLevel.cs
diff --git a/src/Umbraco.Core/Logging/LoggerExtensions.cs b/src/Umbraco.Abstractions/Logging/LoggerExtensions.cs
similarity index 100%
rename from src/Umbraco.Core/Logging/LoggerExtensions.cs
rename to src/Umbraco.Abstractions/Logging/LoggerExtensions.cs
diff --git a/src/Umbraco.Core/Logging/ProfilerExtensions.cs b/src/Umbraco.Abstractions/Logging/ProfilerExtensions.cs
similarity index 100%
rename from src/Umbraco.Core/Logging/ProfilerExtensions.cs
rename to src/Umbraco.Abstractions/Logging/ProfilerExtensions.cs
diff --git a/src/Umbraco.Core/Logging/ProfilingLogger.cs b/src/Umbraco.Abstractions/Logging/ProfilingLogger.cs
similarity index 100%
rename from src/Umbraco.Core/Logging/ProfilingLogger.cs
rename to src/Umbraco.Abstractions/Logging/ProfilingLogger.cs
diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj
index 50a378fa0e..f400595e81 100755
--- a/src/Umbraco.Core/Umbraco.Core.csproj
+++ b/src/Umbraco.Core/Umbraco.Core.csproj
@@ -347,9 +347,7 @@
     <Compile Include="Logging\Viewer\LogMessage.cs" />
     <Compile Include="Logging\Viewer\LogViewerComposer.cs" />
     <Compile Include="Logging\Viewer\LogViewerSourceBase.cs" />
-    <Compile Include="Logging\IProfilingLogger.cs" />
     <Compile Include="Logging\LogHttpRequest.cs" />
-    <Compile Include="Logging\LogLevel.cs" />
     <Compile Include="Logging\MessageTemplates.cs" />
     <Compile Include="Logging\Serilog\Enrichers\HttpRequestIdEnricher.cs" />
     <Compile Include="Logging\Serilog\Enrichers\HttpRequestNumberEnricher.cs" />
@@ -570,7 +568,6 @@
     <Compile Include="DictionaryExtensions.cs" />
     <Compile Include="Dictionary\ICultureDictionary.cs" />
     <Compile Include="Dictionary\ICultureDictionaryFactory.cs" />
-    <Compile Include="Logging\DisposableTimer.cs" />
     <Compile Include="EmailSender.cs" />
     <Compile Include="Events\CancellableEventArgs.cs" />
     <Compile Include="Events\CancellableObjectEventArgs.cs" />
@@ -643,16 +640,11 @@
     <Compile Include="IRuntimeState.cs" />
     <Compile Include="LambdaExpressionCacheKey.cs" />
     <Compile Include="Logging\DebugDiagnosticsLogger.cs" />
-    <Compile Include="Logging\ILogger.cs" />
-    <Compile Include="Logging\IProfiler.cs" />
     <Compile Include="Logging\Serilog\SerilogLogger.cs" />
-    <Compile Include="Logging\LoggerExtensions.cs" />
     <Compile Include="Logging\LoggingTaskExtension.cs" />
     <Compile Include="Logging\LogProfiler.cs" />
     <Compile Include="Logging\OwinLogger.cs" />
     <Compile Include="Logging\OwinLoggerFactory.cs" />
-    <Compile Include="Logging\ProfilerExtensions.cs" />
-    <Compile Include="Logging\ProfilingLogger.cs" />
     <Compile Include="Logging\VoidProfiler.cs" />
     <Compile Include="MainDom.cs" />
     <Compile Include="Manifest\ManifestParser.cs" />