From df3f0cef823bd59987f89ac9e3a41232a87f2bb6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Tue, 7 Jan 2025 09:46:10 +0100 Subject: [PATCH] Fix: select app language (#17849) * fix selection data * remove unused import --- .../app-language-select.element.ts | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/language/app-language-select/app-language-select.element.ts b/src/Umbraco.Web.UI.Client/src/packages/language/app-language-select/app-language-select.element.ts index 87e02b6087..6b6c217dce 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/language/app-language-select/app-language-select.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/language/app-language-select/app-language-select.element.ts @@ -2,7 +2,7 @@ import { UmbLanguageCollectionRepository } from '../collection/index.js'; import type { UmbLanguageDetailModel } from '../types.js'; import type { UmbAppLanguageContext } from '../global-contexts/index.js'; import { UMB_APP_LANGUAGE_CONTEXT } from '../constants.js'; -import type { UUIMenuItemEvent, UUIPopoverContainerElement } from '@umbraco-cms/backoffice/external/uui'; +import type { UUIPopoverContainerElement } from '@umbraco-cms/backoffice/external/uui'; import { css, html, @@ -112,16 +112,9 @@ export class UmbAppLanguageSelectElement extends UmbLitElement { } } - #onLabelClick(event: UUIMenuItemEvent) { - const menuItem = event.target; - const unique = menuItem.dataset.unique; - if (!unique) throw new Error('Missing unique on menu item'); - + #chooseLanguage(unique: string) { this.#appLanguageContext?.setLanguage(unique); this._isOpen = false; - - // eslint-disable-next-line @typescript-eslint/ban-ts-comment - // @ts-ignore this._popoverElement?.hidePopover(); } @@ -153,7 +146,7 @@ export class UmbAppLanguageSelectElement extends UmbLitElement { label=${ifDefined(language.name)} data-mark="${language.entityType}:${language.unique}" ?active=${language.unique === this._appLanguage?.unique} - @click-label=${this.#onLabelClick}> + @click-label=${() => this.#chooseLanguage(language.unique)}> ${this.#isLanguageReadOnly(language.unique) ? this.#renderReadOnlyTag(language.unique) : nothing} `,