yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

We updated our locator to use data-element instead of alias (#14828)

Browse Source
This commit is contained in:
Andreas Zerbst
2023-09-19 10:50:58 +02:00
committed by GitHub
parent cb4d8e34ce
commit e132bcb2a6
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/content.spec.ts
View File

@@ -275,7 +275,7 @@ test.describe('Content tests', () => {
await umbracoUi.clickElement(umbracoUi.getTreeItem(ConstantHelper.sections.content, [initialNodeName])); await umbracoUi.clickElement(umbracoUi.getTreeItem(ConstantHelper.sections.content, [initialNodeName]));
const header = await page.locator('#headerName') const header = await page.locator('#headerName')
// Sadly playwright doesn't have a clear method for inputs :( // Sadly playwright doesn't have a clear method for inputs :(
// so we have to triple click to select all, and then hit backspace... // so we have to triple click to select all, and then hit backspace...
await header.click({ clickCount: 3 }) await header.click({ clickCount: 3 })
await page.keyboard.press('Backspace'); await page.keyboard.press('Backspace');
@@ -381,12 +381,9 @@ test.describe('Content tests', () => {
// Clean up (content is automatically deleted when document types are gone) // Clean up (content is automatically deleted when document types are gone)
await umbracoApi.documentTypes.ensureNameNotExists(rootDocTypeName); await umbracoApi.documentTypes.ensureNameNotExists(rootDocTypeName);
}); });
test('Preview draft', async ({ page, umbracoApi, umbracoUi }) => { test('Preview draft', async ({ page, umbracoApi, umbracoUi }) => {
await umbracoApi.content.deleteAllContent(); await umbracoApi.content.deleteAllContent();
await umbracoApi.documentTypes.ensureNameNotExists(rootDocTypeName); await umbracoApi.documentTypes.ensureNameNotExists(rootDocTypeName);
@@ -415,13 +412,13 @@ test.describe('Content tests', () => {
await umbracoUi.clickElement(umbracoUi.getTreeItem(ConstantHelper.sections.content, [homeNodeName])); await umbracoUi.clickElement(umbracoUi.getTreeItem(ConstantHelper.sections.content, [homeNodeName]));
// Assert // Assert
await expect(page.locator('[alias="preview"]')).toBeVisible(); await expect(page.locator('[data-element="button-preview"]')).toBeVisible();
await page.locator('[alias="preview"]').click(); await page.locator('[data-element="button-preview"]').click();
await umbracoUi.isSuccessNotificationVisible(); await umbracoUi.isSuccessNotificationVisible();
// Clean up (content is automatically deleted when document types are gone) // Clean up (content is automatically deleted when document types are gone)
await umbracoApi.documentTypes.ensureNameNotExists(rootDocTypeName); await umbracoApi.documentTypes.ensureNameNotExists(rootDocTypeName);
}); });
test('Publish draft', async ({ page, umbracoApi, umbracoUi }) => { test('Publish draft', async ({ page, umbracoApi, umbracoUi }) => {
@@ -548,7 +545,7 @@ test.describe('Content tests', () => {
await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.saveAndPublish)); await umbracoUi.clickElement(umbracoUi.getButtonByLabelKey(ConstantHelper.buttons.saveAndPublish));
// Added additional time because it could fail on pipeline because it's not saving fast enough // Added additional time because it could fail on pipeline because it's not saving fast enough
await umbracoUi.isSuccessNotificationVisible({timeout:20000}); await umbracoUi.isSuccessNotificationVisible({timeout:20000});
// Assert // Assert
const expectedContent = '<p>Acceptance test</p>' const expectedContent = '<p>Acceptance test</p>'
await expect(await umbracoApi.content.verifyRenderedContent('/contentpickercontent', expectedContent, true)).toBeTruthy(); await expect(await umbracoApi.content.verifyRenderedContent('/contentpickercontent', expectedContent, true)).toBeTruthy();