From 7856c481d82d5a06c7c4c096a1d96095c87c3ab7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Fri, 8 Nov 2024 08:58:25 +0100 Subject: [PATCH] remove attached on destroy --- .../src/libs/controller-api/controller-host.mixin.ts | 1 + .../controller/base-extension-initializer.controller.ts | 1 + .../components/extension-slot/extension-slot.element.ts | 1 + 3 files changed, 3 insertions(+) diff --git a/src/Umbraco.Web.UI.Client/src/libs/controller-api/controller-host.mixin.ts b/src/Umbraco.Web.UI.Client/src/libs/controller-api/controller-host.mixin.ts index a0d880a33e..a2763432c0 100644 --- a/src/Umbraco.Web.UI.Client/src/libs/controller-api/controller-host.mixin.ts +++ b/src/Umbraco.Web.UI.Client/src/libs/controller-api/controller-host.mixin.ts @@ -129,6 +129,7 @@ export const UmbControllerHostMixin = (superClass: T prev = ctrl; } this.#controllers.length = 0; + this.#attached = false; } } diff --git a/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extension-initializer.controller.ts b/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extension-initializer.controller.ts index 52cff378b7..004c7d1ea6 100644 --- a/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extension-initializer.controller.ts +++ b/src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/base-extension-initializer.controller.ts @@ -310,6 +310,7 @@ export abstract class UmbBaseExtensionInitializer< /* public hostConnected(): void { super.hostConnected(); + // Should not be nesecary as conditions would be reactive to connectedCallback, as they will use consumeContext. [NL] //this.#onConditionsChangedCallback(); } */ diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/components/extension-slot/extension-slot.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/components/extension-slot/extension-slot.element.ts index 5f610e076c..974102a025 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/components/extension-slot/extension-slot.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/extension-registry/components/extension-slot/extension-slot.element.ts @@ -103,6 +103,7 @@ export class UmbExtensionSlotElement extends UmbLitElement { this.#observeExtensions(); } override disconnectedCallback(): void { + // _permitted is reset as the extensionsController fires a callback on destroy. this.#attached = false; this.#extensionsController?.destroy(); this.#extensionsController = undefined;