From e45ea6560d24dbd7245b5afc9085a05a2ac08f17 Mon Sep 17 00:00:00 2001 From: Shannon Date: Tue, 19 Nov 2019 17:00:58 +1100 Subject: [PATCH] fixes test, adds note --- src/Umbraco.Abstractions/Models/PropertyTypeCollection.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Abstractions/Models/PropertyTypeCollection.cs b/src/Umbraco.Abstractions/Models/PropertyTypeCollection.cs index d26a092c64..bca7e88e03 100644 --- a/src/Umbraco.Abstractions/Models/PropertyTypeCollection.cs +++ b/src/Umbraco.Abstractions/Models/PropertyTypeCollection.cs @@ -83,7 +83,9 @@ namespace Umbraco.Core.Models OnCollectionChanged(new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Reset)); } - void ICollection.Add(IPropertyType item) + // 'new' keyword is required! we can explicitly implement ICollection.Add BUT since normally a concrete PropertyType type + // is passed in, the explicit implementation doesn't get called, this ensures it does get called. + public new void Add(IPropertyType item) { item.SupportsPublishing = SupportsPublishing;