From e5e4e7b685b69cd9a501895df7ec6cad74b45296 Mon Sep 17 00:00:00 2001 From: Shannon Deminick Date: Thu, 18 Apr 2013 21:44:38 +0600 Subject: [PATCH] Fixes another merge issue and improves performance slightly for sorting so that we are not double saving the entity if it is published already. --- .../umbraco/webservices/nodeSorter.asmx.cs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web/umbraco.presentation/umbraco/webservices/nodeSorter.asmx.cs b/src/Umbraco.Web/umbraco.presentation/umbraco/webservices/nodeSorter.asmx.cs index e79747534f..ea1ff472e5 100644 --- a/src/Umbraco.Web/umbraco.presentation/umbraco/webservices/nodeSorter.asmx.cs +++ b/src/Umbraco.Web/umbraco.presentation/umbraco/webservices/nodeSorter.asmx.cs @@ -108,6 +108,11 @@ namespace umbraco.presentation.webservices //TODO: WE don't want to have to republish the entire document !!!! library.UpdateDocumentCache(document); } + else + { + //we need to save it if it is not published to persist the sort order value + document.Save(); + } } // to update the sortorder of the media node in the XML, re-save the node.... else if (isMedia) @@ -116,10 +121,7 @@ namespace umbraco.presentation.webservices { sortOrder = i }; - media.Save(); - { - new cms.businesslogic.CMSNode(int.Parse(ids[i])).sortOrder = i; - } + media.Save(); } // Refresh sort order on cached xml