yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve logging performance by checking Trace/Debug log level is enabled (#12793)

Browse Source
This commit is contained in:
Chad
2023-06-07 21:47:05 +12:00
committed by GitHub
parent 9bafdbd992
commit e784cfa960
69 changed files with 648 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerDistributedLockingMechanism.cs
View File

@@ -70,8 +70,10 @@ public class SqlServerDistributedLockingMechanism : IDistributedLockingMechanism
_timeout = timeout;
LockId = lockId;
LockType = lockType;
_parent._logger.LogDebug("Requesting {lockType} for id {id}", LockType, LockId);
if (_parent._logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_parent._logger.LogDebug("Requesting {lockType} for id {id}", LockType, LockId);
}
try
{
@@ -96,17 +98,24 @@ public class SqlServerDistributedLockingMechanism : IDistributedLockingMechanism
throw new DistributedWriteLockTimeoutException(LockId);
}
_parent._logger.LogDebug("Acquired {lockType} for id {id}", LockType, LockId);
if (_parent._logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_parent._logger.LogDebug("Acquired {lockType} for id {id}", LockType, LockId);
}
}
public int LockId { get; }
public DistributedLockType LockType { get; }
public void Dispose() =>
// Mostly no op, cleaned up by completing transaction in scope.
_parent._logger.LogDebug("Dropped {lockType} for id {id}", LockType, LockId);
public void Dispose()
{
if (_parent._logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
// Mostly no op, cleaned up by completing transaction in scope.
_parent._logger.LogDebug("Dropped {lockType} for id {id}", LockType, LockId);
}
}
public override string ToString()
=> $"SqlServerDistributedLock({LockId}, {LockType}";

7
src/Umbraco.Cms.Persistence.SqlServer/Services/SqlServerSyntaxProvider.cs
View File

@@ -86,9 +86,10 @@ public class SqlServerSyntaxProvider : MicrosoftSqlSyntaxProviderBase<SqlServerS
{
versionName = GetSetVersion(connectionString, ProviderName, _logger).ProductVersionName;
}
_logger.LogDebug("SqlServer {SqlServerVersion}, DatabaseType is {DatabaseType} ({Source}).", versionName, DatabaseType.SqlServer2012, fromSettings ? "settings" : "detected");
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("SqlServer {SqlServerVersion}, DatabaseType is {DatabaseType} ({Source}).", versionName, DatabaseType.SqlServer2012, fromSettings ? "settings" : "detected");
}
return DatabaseType.SqlServer2012;
}