yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve logging performance by checking Trace/Debug log level is enabled (#12793)

Browse Source
This commit is contained in:
Chad
2023-06-07 21:47:05 +12:00
committed by GitHub
parent 9bafdbd992
commit e784cfa960
69 changed files with 648 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/Umbraco.PublishedCache.NuCache/PublishedSnapshotService.cs
View File

@@ -181,7 +181,10 @@ internal class PublishedSnapshotService : IPublishedSnapshotService
foreach (ContentTypeCacheRefresher.JsonPayload payload in payloads)
{
_logger.LogDebug("Notified {ChangeTypes} for {ItemType} {ItemId}", payload.ChangeTypes, payload.ItemType, payload.Id);
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("Notified {ChangeTypes} for {ItemType} {ItemId}", payload.ChangeTypes, payload.ItemType, payload.Id);
}
}
Notify<IContentType>(_contentStore, payloads, RefreshContentTypesLocked);
@@ -230,10 +233,13 @@ internal class PublishedSnapshotService : IPublishedSnapshotService
foreach (DataTypeCacheRefresher.JsonPayload payload in payloads)
{
_logger.LogDebug(
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug(
"Notified {RemovedStatus} for data type {DataTypeId}",
payload.Removed ? "Removed" : "Refreshed",
payload.Id);
}
}
using (_contentStore.GetScopedWriteLock(_scopeProvider))
@@ -622,15 +628,23 @@ internal class PublishedSnapshotService : IPublishedSnapshotService
/// </remarks>
private void MainDomRelease()
{
_logger.LogDebug("Releasing from MainDom...");
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("Releasing from MainDom...");
}
lock (_storesLock)
{
_logger.LogDebug("Releasing content store...");
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("Releasing content store...");
}
_contentStore?.ReleaseLocalDb(); // null check because we could shut down before being assigned
_localContentDb = null;
_logger.LogDebug("Releasing media store...");
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("Releasing media store...");
}
_mediaStore?.ReleaseLocalDb(); // null check because we could shut down before being assigned
_localMediaDb = null;
@@ -742,8 +756,10 @@ internal class PublishedSnapshotService : IPublishedSnapshotService
// beware! at that point the cache is inconsistent,
// assuming we are going to SetAll content items!
_localMediaDb?.Clear();
_logger.LogDebug("Loading media from database...");
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("Loading media from database...");
}
// IMPORTANT GetAllMediaSources sorts kits by level + parentId + sortOrder
try
@@ -852,7 +868,10 @@ internal class PublishedSnapshotService : IPublishedSnapshotService
// contentStore is write-locked during changes - see note above, calls to this method are wrapped in contentStore.GetScopedWriteLock
foreach (ContentCacheRefresher.JsonPayload payload in payloads)
{
_logger.LogDebug("Notified {ChangeTypes} for content {ContentId}", payload.ChangeTypes, payload.Id);
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("Notified {ChangeTypes} for content {ContentId}", payload.ChangeTypes, payload.Id);
}
if (payload.ChangeTypes.HasType(TreeChangeTypes.RefreshAll))
{
@@ -926,7 +945,10 @@ internal class PublishedSnapshotService : IPublishedSnapshotService
// see notes for content cache refresher
foreach (MediaCacheRefresher.JsonPayload payload in payloads)
{
_logger.LogDebug("Notified {ChangeTypes} for media {MediaId}", payload.ChangeTypes, payload.Id);
if (_logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
{
_logger.LogDebug("Notified {ChangeTypes} for media {MediaId}", payload.ChangeTypes, payload.Id);
}
if (payload.ChangeTypes.HasType(TreeChangeTypes.RefreshAll))
{