make sure to unbind properly onSetup

2024-01-10 14:27:25 +01:00
parent 57ac662e2c
commit e795f39f1c
1 changed files with 6 additions and 2 deletions
--- a/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/tiny-mce/plugins/tiny-mce-mediapicker.plugin.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/core/property-editor/uis/tiny-mce/plugins/tiny-mce-mediapicker.plugin.ts
@@ -55,8 +55,12 @@ export default class UmbTinyMceMediaPickerPlugin extends UmbTinyMcePluginBase {
 			icon: 'image',
 			tooltip: 'Media Picker',
 			onAction: () => this.#onAction(),
-			onSetup: (api) => () =>
-				this.editor.selection.selectorChangedWithUnbind('img[data-udi]', (state) => api.setActive(state)),
+			onSetup: (api) => {
+				const changed = this.editor.selection.selectorChangedWithUnbind('img[data-udi]', (state) =>
+					api.setActive(state),
+				);
+				return () => changed.unbind();
+			},
 		});

 		// Register global options for the editor