diff --git a/src/Umbraco.Core/Components/Composition.cs b/src/Umbraco.Core/Components/Composition.cs index c81fe388ba..525d8b773e 100644 --- a/src/Umbraco.Core/Components/Composition.cs +++ b/src/Umbraco.Core/Components/Composition.cs @@ -98,7 +98,7 @@ namespace Umbraco.Core.Components /// /// The type of the collection builder. /// The collection builder. - public TBuilder GetCollectionBuilder() + public TBuilder WithCollectionBuilder() where TBuilder: ICollectionBuilder, new() { var typeOfBuilder = typeof(TBuilder); diff --git a/src/Umbraco.Core/Components/CompositionExtensions.cs b/src/Umbraco.Core/Components/CompositionExtensions.cs index 8ac8c66bc1..f41ecf7186 100644 --- a/src/Umbraco.Core/Components/CompositionExtensions.cs +++ b/src/Umbraco.Core/Components/CompositionExtensions.cs @@ -24,56 +24,56 @@ namespace Umbraco.Core.Components /// /// The composition. public static CacheRefresherCollectionBuilder CacheRefreshers(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the mappers collection builder. /// /// The composition. public static MapperCollectionBuilder Mappers(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the package actions collection builder. /// /// The composition. internal static PackageActionCollectionBuilder PackageActions(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the data editor collection builder. /// /// The composition. public static DataEditorCollectionBuilder DataEditors(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the property value converters collection builder. /// /// The composition. public static PropertyValueConverterCollectionBuilder PropertyValueConverters(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the url segment providers collection builder. /// /// The composition. public static UrlSegmentProviderCollectionBuilder UrlSegmentProviders(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the validators collection builder. /// /// The composition. internal static ManifestValueValidatorCollectionBuilder Validators(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the post-migrations collection builder. /// /// The composition. internal static PostMigrationCollectionBuilder PostMigrations(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); #endregion diff --git a/src/Umbraco.Core/Runtime/CoreRuntimeComponent.cs b/src/Umbraco.Core/Runtime/CoreRuntimeComponent.cs index 63cd4e726b..72d6d37010 100644 --- a/src/Umbraco.Core/Runtime/CoreRuntimeComponent.cs +++ b/src/Umbraco.Core/Runtime/CoreRuntimeComponent.cs @@ -45,7 +45,7 @@ namespace Umbraco.Core.Runtime // register persistence mappers - required by database factory so needs to be done here // means the only place the collection can be modified is in a runtime - afterwards it // has been frozen and it is too late - composition.GetCollectionBuilder().AddCoreMappers(); + composition.WithCollectionBuilder().AddCoreMappers(); // register the scope provider composition.RegisterSingleton(); // implements both IScopeProvider and IScopeAccessor @@ -60,7 +60,7 @@ namespace Umbraco.Core.Runtime composition.RegisterSingleton(); // register our predefined validators - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add() .Add() .Add() @@ -69,7 +69,7 @@ namespace Umbraco.Core.Runtime .Add(); // properties and parameters derive from data editors - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetDataEditors()); composition.RegisterSingleton(); composition.RegisterSingleton(); @@ -96,13 +96,13 @@ namespace Umbraco.Core.Runtime factory.GetInstance(), true, new DatabaseServerMessengerOptions())); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetCacheRefreshers()); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetPackageActions()); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Append(composition.TypeLoader.GetTypes()); composition.RegisterSingleton(); @@ -110,10 +110,10 @@ namespace Umbraco.Core.Runtime composition.RegisterSingleton(factory => new DefaultShortStringHelper(new DefaultShortStringHelperConfig().WithDefault(factory.GetInstance()))); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Append(); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetTypes()); composition.RegisterSingleton(factory => new MigrationBuilder(factory)); diff --git a/src/Umbraco.Tests/Cache/DistributedCache/DistributedCacheTests.cs b/src/Umbraco.Tests/Cache/DistributedCache/DistributedCacheTests.cs index 684e06b300..a57ab93f3c 100644 --- a/src/Umbraco.Tests/Cache/DistributedCache/DistributedCacheTests.cs +++ b/src/Umbraco.Tests/Cache/DistributedCache/DistributedCacheTests.cs @@ -30,7 +30,7 @@ namespace Umbraco.Tests.Cache.DistributedCache register.Register(_ => new TestServerRegistrar()); register.RegisterSingleton(_ => new TestServerMessenger()); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(); Current.Factory = register.CreateFactory(); diff --git a/src/Umbraco.Tests/Cache/PublishedCache/PublishedMediaCacheTests.cs b/src/Umbraco.Tests/Cache/PublishedCache/PublishedMediaCacheTests.cs index a0ab75f0f9..ef50f0b48a 100644 --- a/src/Umbraco.Tests/Cache/PublishedCache/PublishedMediaCacheTests.cs +++ b/src/Umbraco.Tests/Cache/PublishedCache/PublishedMediaCacheTests.cs @@ -29,7 +29,7 @@ namespace Umbraco.Tests.Cache.PublishedCache { base.Compose(); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Clear() .Append(); } diff --git a/src/Umbraco.Tests/Composing/CollectionBuildersTests.cs b/src/Umbraco.Tests/Composing/CollectionBuildersTests.cs index 0d0374d37a..59230c356c 100644 --- a/src/Umbraco.Tests/Composing/CollectionBuildersTests.cs +++ b/src/Umbraco.Tests/Composing/CollectionBuildersTests.cs @@ -33,7 +33,7 @@ namespace Umbraco.Tests.Composing [Test] public void ContainsTypes() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append(); @@ -50,7 +50,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanClearBuilderBeforeCollectionIsCreated() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append(); @@ -66,7 +66,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotClearBuilderOnceCollectionIsCreated() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append(); @@ -79,7 +79,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanAppendToBuilder() { - var builder = _composition.GetCollectionBuilder(); + var builder = _composition.WithCollectionBuilder(); builder.Append(); builder.Append(); @@ -95,7 +95,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotAppendToBuilderOnceCollectionIsCreated() { - var builder = _composition.GetCollectionBuilder(); + var builder = _composition.WithCollectionBuilder(); var factory = _composition.CreateFactory(); var col = builder.CreateCollection(factory); @@ -108,7 +108,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanAppendDuplicateToBuilderAndDeDuplicate() { - var builder = _composition.GetCollectionBuilder(); + var builder = _composition.WithCollectionBuilder(); builder.Append(); builder.Append(); @@ -121,7 +121,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotAppendInvalidTypeToBUilder() { - var builder = _composition.GetCollectionBuilder(); + var builder = _composition.WithCollectionBuilder(); //builder.Append(); // does not compile Assert.Throws(() => @@ -132,7 +132,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanRemoveFromBuilder() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append() .Remove(); @@ -149,7 +149,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanRemoveMissingFromBuilder() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append() .Remove(); @@ -162,7 +162,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotRemoveFromBuilderOnceCollectionIsCreated() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append(); @@ -176,7 +176,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanInsertIntoBuilder() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append() .Insert(); @@ -193,7 +193,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotInsertIntoBuilderOnceCollectionIsCreated() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append(); @@ -207,7 +207,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanInsertDuplicateIntoBuilderAndDeDuplicate() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append() .Insert(); @@ -220,7 +220,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanInsertIntoEmptyBuilder() { - var builder = _composition.GetCollectionBuilder(); + var builder = _composition.WithCollectionBuilder(); builder.Insert(); var factory = _composition.CreateFactory(); @@ -231,7 +231,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotInsertIntoBuilderAtWrongIndex() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append(); @@ -247,7 +247,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanInsertIntoBuilderBefore() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append() .InsertBefore(); @@ -264,7 +264,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotInsertIntoBuilderBeforeOnceCollectionIsCreated() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append(); @@ -278,7 +278,7 @@ namespace Umbraco.Tests.Composing [Test] public void CanInsertDuplicateIntoBuilderBeforeAndDeDuplicate() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Append() .InsertBefore(); @@ -291,7 +291,7 @@ namespace Umbraco.Tests.Composing [Test] public void CannotInsertIntoBuilderBeforeMissing() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append(); Assert.Throws(() => @@ -302,7 +302,7 @@ namespace Umbraco.Tests.Composing [Test] public void ScopeBuilderCreatesScopedCollection() { - _composition.GetCollectionBuilder() + _composition.WithCollectionBuilder() .Append() .Append(); @@ -324,7 +324,7 @@ namespace Umbraco.Tests.Composing [Test] public void TransientBuilderCreatesTransientCollection() { - _composition.GetCollectionBuilder() + _composition.WithCollectionBuilder() .Append() .Append(); @@ -346,7 +346,7 @@ namespace Umbraco.Tests.Composing [Test] public void BuilderRespectsTypesOrder() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Append() .Insert() .InsertBefore(); @@ -359,7 +359,7 @@ namespace Umbraco.Tests.Composing [Test] public void ScopeBuilderRespectsContainerScope() { - _composition.GetCollectionBuilder() + _composition.WithCollectionBuilder() .Append() .Append(); @@ -395,7 +395,7 @@ namespace Umbraco.Tests.Composing [Test] public void WeightedBuilderCreatesWeightedCollection() { - var builder = _composition.GetCollectionBuilder() + var builder = _composition.WithCollectionBuilder() .Add() .Add(); diff --git a/src/Umbraco.Tests/Composing/LazyCollectionBuilderTests.cs b/src/Umbraco.Tests/Composing/LazyCollectionBuilderTests.cs index b3009ae90f..656adedf52 100644 --- a/src/Umbraco.Tests/Composing/LazyCollectionBuilderTests.cs +++ b/src/Umbraco.Tests/Composing/LazyCollectionBuilderTests.cs @@ -42,7 +42,7 @@ namespace Umbraco.Tests.Composing var container = CreateRegister(); var composition = new Composition(container, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add() .Add() .Add() @@ -68,7 +68,7 @@ namespace Umbraco.Tests.Composing var container = CreateRegister(); var composition = new Composition(container, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => new[] { typeof(TransientObject3), typeof(TransientObject2) }) .Add(() => new[] { typeof(TransientObject3), typeof(TransientObject2) }) .Add(() => new[] { typeof(TransientObject1) }); @@ -93,7 +93,7 @@ namespace Umbraco.Tests.Composing var container = CreateRegister(); var composition = new Composition(container, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add() .Add() .Add() @@ -119,7 +119,7 @@ namespace Umbraco.Tests.Composing var container = CreateRegister(); var composition = new Composition(container, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add() // illegal, does not implement the interface! @@ -143,7 +143,7 @@ namespace Umbraco.Tests.Composing var container = CreateRegister(); var composition = new Composition(container, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add() .Add(() => new[] { typeof(TransientObject3), typeof(TransientObject2), typeof(TransientObject1) }) .Exclude(); diff --git a/src/Umbraco.Tests/Composing/PackageActionCollectionTests.cs b/src/Umbraco.Tests/Composing/PackageActionCollectionTests.cs index f66cab18c4..1f08e60375 100644 --- a/src/Umbraco.Tests/Composing/PackageActionCollectionTests.cs +++ b/src/Umbraco.Tests/Composing/PackageActionCollectionTests.cs @@ -21,7 +21,7 @@ namespace Umbraco.Tests.Composing var composition = new Composition(container, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => TypeLoader.GetPackageActions()); Current.Factory = container.CreateFactory(); diff --git a/src/Umbraco.Tests/Integration/ContentEventsTests.cs b/src/Umbraco.Tests/Integration/ContentEventsTests.cs index df7bdb5ccf..c138e48bfe 100644 --- a/src/Umbraco.Tests/Integration/ContentEventsTests.cs +++ b/src/Umbraco.Tests/Integration/ContentEventsTests.cs @@ -52,7 +52,7 @@ namespace Umbraco.Tests.Integration Composition.Register(_ => new TestServerRegistrar()); // localhost-only Composition.RegisterSingleton(); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Add() .Add() .Add(); diff --git a/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs b/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs index 4d813b5059..c908cca64e 100644 --- a/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs +++ b/src/Umbraco.Tests/Models/Mapping/AutoMapperTests.cs @@ -31,7 +31,7 @@ namespace Umbraco.Tests.Models.Mapping Composition.Register(_ => manifestBuilder); Func> typeListProducerList = Enumerable.Empty; - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Clear() .Add(typeListProducerList); } diff --git a/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs b/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs index 8693f65d4d..1a869183bb 100644 --- a/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs +++ b/src/Umbraco.Tests/PropertyEditors/ImageCropperTest.cs @@ -72,7 +72,7 @@ namespace Umbraco.Tests.PropertyEditors var container = RegisterFactory.Create(); var composition = new Composition(container, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder(); + composition.WithCollectionBuilder(); Current.Factory = container.CreateFactory(); diff --git a/src/Umbraco.Tests/Published/ConvertersTests.cs b/src/Umbraco.Tests/Published/ConvertersTests.cs index 026aee4bb1..0937c5ea70 100644 --- a/src/Umbraco.Tests/Published/ConvertersTests.cs +++ b/src/Umbraco.Tests/Published/ConvertersTests.cs @@ -178,7 +178,7 @@ namespace Umbraco.Tests.Published var composition = new Composition(register, new TypeLoader(), Mock.Of(), RuntimeLevel.Run); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Append() .Append(); diff --git a/src/Umbraco.Tests/PublishedContent/PublishedContentTestBase.cs b/src/Umbraco.Tests/PublishedContent/PublishedContentTestBase.cs index 1c66f5a6d3..d18c6b6668 100644 --- a/src/Umbraco.Tests/PublishedContent/PublishedContentTestBase.cs +++ b/src/Umbraco.Tests/PublishedContent/PublishedContentTestBase.cs @@ -23,7 +23,7 @@ namespace Umbraco.Tests.PublishedContent // fixme - what about the if (PropertyValueConvertersResolver.HasCurrent == false) ?? // can we risk double - registering and then, what happens? - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Clear() .Append() .Append() diff --git a/src/Umbraco.Tests/PublishedContent/PublishedMediaTests.cs b/src/Umbraco.Tests/PublishedContent/PublishedMediaTests.cs index 9d603a9569..be2f09b0dd 100644 --- a/src/Umbraco.Tests/PublishedContent/PublishedMediaTests.cs +++ b/src/Umbraco.Tests/PublishedContent/PublishedMediaTests.cs @@ -39,7 +39,7 @@ namespace Umbraco.Tests.PublishedContent { base.Compose(); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Clear() .Append(); } diff --git a/src/Umbraco.Tests/Scoping/ScopeEventDispatcherTests.cs b/src/Umbraco.Tests/Scoping/ScopeEventDispatcherTests.cs index 04703e3195..933d8e9f7e 100644 --- a/src/Umbraco.Tests/Scoping/ScopeEventDispatcherTests.cs +++ b/src/Umbraco.Tests/Scoping/ScopeEventDispatcherTests.cs @@ -39,7 +39,7 @@ namespace Umbraco.Tests.Scoping _testObjects = new TestObjects(register); register.RegisterSingleton(factory => new FileSystems(factory, factory.TryGetInstance())); - composition.GetCollectionBuilder(); + composition.WithCollectionBuilder(); Current.Factory = register.CreateFactory(); diff --git a/src/Umbraco.Tests/Scoping/ScopedNuCacheTests.cs b/src/Umbraco.Tests/Scoping/ScopedNuCacheTests.cs index 50d0f42626..1ab6f8d392 100644 --- a/src/Umbraco.Tests/Scoping/ScopedNuCacheTests.cs +++ b/src/Umbraco.Tests/Scoping/ScopedNuCacheTests.cs @@ -46,7 +46,7 @@ namespace Umbraco.Tests.Scoping // so doing all this mess Composition.RegisterSingleton(); Composition.RegisterSingleton(f => Mock.Of()); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Add(() => Composition.TypeLoader.GetCacheRefreshers()); } diff --git a/src/Umbraco.Tests/Scoping/ScopedRepositoryTests.cs b/src/Umbraco.Tests/Scoping/ScopedRepositoryTests.cs index b00dfbaa03..815da6e6a6 100644 --- a/src/Umbraco.Tests/Scoping/ScopedRepositoryTests.cs +++ b/src/Umbraco.Tests/Scoping/ScopedRepositoryTests.cs @@ -32,7 +32,7 @@ namespace Umbraco.Tests.Scoping // so doing all this mess Composition.RegisterSingleton(); Composition.RegisterSingleton(f => Mock.Of()); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Add(() => Composition.TypeLoader.GetCacheRefreshers()); } diff --git a/src/Umbraco.Tests/Scoping/ScopedXmlTests.cs b/src/Umbraco.Tests/Scoping/ScopedXmlTests.cs index c829643964..8855bc5a13 100644 --- a/src/Umbraco.Tests/Scoping/ScopedXmlTests.cs +++ b/src/Umbraco.Tests/Scoping/ScopedXmlTests.cs @@ -34,7 +34,7 @@ namespace Umbraco.Tests.Scoping // so doing all this mess Composition.RegisterSingleton(); Composition.RegisterSingleton(f => Mock.Of()); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Add(() => Composition.TypeLoader.GetCacheRefreshers()); } diff --git a/src/Umbraco.Tests/Services/ContentTypeServiceVariantsTests.cs b/src/Umbraco.Tests/Services/ContentTypeServiceVariantsTests.cs index 17c31ca409..5cd1cdd1bc 100644 --- a/src/Umbraco.Tests/Services/ContentTypeServiceVariantsTests.cs +++ b/src/Umbraco.Tests/Services/ContentTypeServiceVariantsTests.cs @@ -37,7 +37,7 @@ namespace Umbraco.Tests.Services // pfew - see note in ScopedNuCacheTests? Composition.RegisterSingleton(); Composition.RegisterSingleton(f => Mock.Of()); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Add(() => Composition.TypeLoader.GetCacheRefreshers()); } diff --git a/src/Umbraco.Tests/Services/Importing/PackageImportTests.cs b/src/Umbraco.Tests/Services/Importing/PackageImportTests.cs index 49b52f4276..8e67aa4e1f 100644 --- a/src/Umbraco.Tests/Services/Importing/PackageImportTests.cs +++ b/src/Umbraco.Tests/Services/Importing/PackageImportTests.cs @@ -49,7 +49,7 @@ namespace Umbraco.Tests.Services.Importing // pollute everything, they are ignored by the type finder and explicitely // added to the editors collection - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Add() .Add(); } diff --git a/src/Umbraco.Tests/TestHelpers/BaseUsingSqlCeSyntax.cs b/src/Umbraco.Tests/TestHelpers/BaseUsingSqlCeSyntax.cs index 846fcfac5d..9dd8324e9f 100644 --- a/src/Umbraco.Tests/TestHelpers/BaseUsingSqlCeSyntax.cs +++ b/src/Umbraco.Tests/TestHelpers/BaseUsingSqlCeSyntax.cs @@ -48,7 +48,7 @@ namespace Umbraco.Tests.TestHelpers false); container.RegisterInstance(pluginManager); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => Current.TypeLoader.GetAssignedMapperTypes()); var factory = Current.Factory = container.CreateFactory(); diff --git a/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs b/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs index cc3ddb6f6a..72468f89b8 100644 --- a/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs +++ b/src/Umbraco.Tests/TestHelpers/TestWithDatabaseBase.cs @@ -76,7 +76,7 @@ namespace Umbraco.Tests.TestHelpers Composition.Register(factory => PublishedSnapshotService); Composition.Register(factory => DefaultCultureAccessor); - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .Clear() .Add(() => Composition.TypeLoader.GetDataEditors()); diff --git a/src/Umbraco.Tests/Testing/UmbracoTestBase.cs b/src/Umbraco.Tests/Testing/UmbracoTestBase.cs index e67fd912c8..67fa8361ba 100644 --- a/src/Umbraco.Tests/Testing/UmbracoTestBase.cs +++ b/src/Umbraco.Tests/Testing/UmbracoTestBase.cs @@ -211,7 +211,7 @@ namespace Umbraco.Tests.Testing // web Composition.Register(_ => Umbraco.Web.Composing.Current.UmbracoContextAccessor); Composition.RegisterSingleton(); - Composition.GetCollectionBuilder(); + Composition.WithCollectionBuilder(); Composition.Register(); Composition.Register(); } @@ -224,14 +224,14 @@ namespace Umbraco.Tests.Testing Composition.RegisterSingleton(f => runtimeStateMock.Object); // ah... - Composition.GetCollectionBuilder(); - Composition.GetCollectionBuilder(); + Composition.WithCollectionBuilder(); + Composition.WithCollectionBuilder(); Composition.RegisterSingleton(); Composition.RegisterSingleton(); // register empty content apps collection - Composition.GetCollectionBuilder(); + Composition.WithCollectionBuilder(); } protected virtual void ComposeAutoMapper(bool configure) @@ -321,7 +321,7 @@ namespace Umbraco.Tests.Testing Composition.RegisterSingleton(); // register application stuff (database factory & context, services...) - Composition.GetCollectionBuilder() + Composition.WithCollectionBuilder() .AddCoreMappers(); Composition.RegisterSingleton(_ => new TransientEventMessagesFactory()); @@ -331,7 +331,7 @@ namespace Umbraco.Tests.Testing new Lazy(Mock.Of))); Composition.RegisterSingleton(f => f.TryGetInstance().SqlContext); - Composition.GetCollectionBuilder(); // empty + Composition.WithCollectionBuilder(); // empty Composition.RegisterSingleton(factory => TestObjects.GetScopeProvider(factory.TryGetInstance(), factory.TryGetInstance(), factory.TryGetInstance())); @@ -344,11 +344,11 @@ namespace Umbraco.Tests.Testing Composition.RegisterSingleton(); // somehow property editor ends up wanting this - Composition.GetCollectionBuilder(); + Composition.WithCollectionBuilder(); Composition.RegisterSingleton(); // note - don't register collections, use builders - Composition.GetCollectionBuilder(); + Composition.WithCollectionBuilder(); Composition.RegisterSingleton(); Composition.RegisterSingleton(); } diff --git a/src/Umbraco.Web/CompositionExtensions.cs b/src/Umbraco.Web/CompositionExtensions.cs index ee57ca98cb..7725fe6524 100644 --- a/src/Umbraco.Web/CompositionExtensions.cs +++ b/src/Umbraco.Web/CompositionExtensions.cs @@ -30,7 +30,7 @@ namespace Umbraco.Core.Components /// The composition. /// internal static ActionCollectionBuilder Actions(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the content apps collection builder. @@ -38,7 +38,7 @@ namespace Umbraco.Core.Components /// The composition. /// public static ContentAppDefinitionCollectionBuilder ContentApps(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the content finders collection builder. @@ -46,7 +46,7 @@ namespace Umbraco.Core.Components /// The composition. /// public static ContentFinderCollectionBuilder ContentFinders(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the editor validators collection builder. @@ -54,7 +54,7 @@ namespace Umbraco.Core.Components /// The composition. /// internal static EditorValidatorCollectionBuilder EditorValidators(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the filtered controller factories collection builder. @@ -62,21 +62,21 @@ namespace Umbraco.Core.Components /// The composition. /// public static FilteredControllerFactoryCollectionBuilder FilderedControllerFactory(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the health checks collection builder. /// /// The composition. public static HealthCheckCollectionBuilder HealthChecks(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); /// /// Gets the url providers collection builder. /// /// The composition. internal static UrlProviderCollectionBuilder UrlProviders(this Composition composition) - => composition.GetCollectionBuilder(); + => composition.WithCollectionBuilder(); #endregion diff --git a/src/Umbraco.Web/Runtime/WebRuntimeComponent.cs b/src/Umbraco.Web/Runtime/WebRuntimeComponent.cs index 29e2cc1058..e5973b24bc 100644 --- a/src/Umbraco.Web/Runtime/WebRuntimeComponent.cs +++ b/src/Umbraco.Web/Runtime/WebRuntimeComponent.cs @@ -123,20 +123,20 @@ namespace Umbraco.Web.Runtime .ComposeMvcControllers(GetType().Assembly) .ComposeApiControllers(GetType().Assembly); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetTypes()); // fixme which searchable trees?! - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetTypes()); - composition.GetCollectionBuilder(); + composition.WithCollectionBuilder(); composition.RegisterSingleton(); // set the default RenderMvcController Current.DefaultRenderMvcControllerType = typeof(RenderMvcController); // fixme WRONG! - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetTypes()); var surfaceControllerTypes = new SurfaceControllerTypeCollection(composition.TypeLoader.GetSurfaceControllers()); @@ -150,24 +150,24 @@ namespace Umbraco.Web.Runtime // here because there cannot be two converters for one property editor - and we want the full // RteMacroRenderingValueConverter that converts macros, etc. So remove TinyMceValueConverter. // (the limited one, defined in Core, is there for tests) - same for others - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Remove() .Remove() .Remove(); // add all known factories, devs can then modify this list on application // startup either by binding to events or in their own global.asax - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Append(); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Append() .Append() .Append(); composition.RegisterSingleton(); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() // all built-in finders in the correct order, // devs can then modify this list on application startup .Append() @@ -182,10 +182,10 @@ namespace Umbraco.Web.Runtime composition.RegisterSingleton(); // register *all* checks, except those marked [HideFromTypeFinder] of course - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetTypes()); - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Add(() => composition.TypeLoader.GetTypes()); // auto-register views @@ -202,7 +202,7 @@ namespace Umbraco.Web.Runtime composition.RegisterSingleton(); // register known content apps - composition.GetCollectionBuilder() + composition.WithCollectionBuilder() .Append() .Append() .Append();