From ea0d7fe041c56f2a69b1ce08a6055db7f382f751 Mon Sep 17 00:00:00 2001
From: Mads Rasmussen <madsr@hey.com>
Date: Mon, 13 Nov 2023 15:45:18 +0100
Subject: [PATCH] add todos to clean up the tree repository interface

---
 .../repository/tree-repository.interface.ts   | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/repository/tree-repository.interface.ts b/src/Umbraco.Web.UI.Client/src/packages/core/repository/tree-repository.interface.ts
index 0ad6c918bf..bfd79af318 100644
--- a/src/Umbraco.Web.UI.Client/src/packages/core/repository/tree-repository.interface.ts
+++ b/src/Umbraco.Web.UI.Client/src/packages/core/repository/tree-repository.interface.ts
@@ -13,17 +13,26 @@ export interface UmbTreeRepository<
 		error?: ProblemDetails;
 	}>;
 
+	requestTreeItemsOf: (parentUnique: string | null) => Promise<{
+		data?: UmbPagedData<TreeItemType>;
+		error?: ProblemDetails;
+		asObservable?: () => Observable<TreeItemType[]>;
+	}>;
+
+	treeItemsOf: (parentUnique: string | null) => Promise<Observable<TreeItemType[]>>;
+
+	/* TODO: remove this. It is not used client side.
+	Logic to call the root endpoint should be in the data source 
+	because it is a server decision to split them
+	*/
 	requestRootTreeItems: () => Promise<{
 		data?: UmbPagedData<TreeItemType>;
 		error?: ProblemDetails;
 		asObservable?: () => Observable<TreeItemType[]>;
 	}>;
 
-	requestTreeItemsOf: (parentUnique: string | null) => Promise<{
-		data?: UmbPagedData<TreeItemType>;
-		error?: ProblemDetails;
-		asObservable?: () => Observable<TreeItemType[]>;
-	}>;
+	// TODO: remove
+	rootTreeItems: () => Promise<Observable<TreeItemType[]>>;
 
 	// TODO: remove this when all repositories are migrated to the new interface items interface
 	requestItemsLegacy?: (uniques: string[]) => Promise<{
@@ -32,10 +41,6 @@ export interface UmbTreeRepository<
 		asObservable?: () => Observable<any[]>;
 	}>;
 
-	rootTreeItems: () => Promise<Observable<TreeItemType[]>>;
-
-	treeItemsOf: (parentUnique: string | null) => Promise<Observable<TreeItemType[]>>;
-
 	// TODO: remove this when all repositories are migrated to the new items interface
 	itemsLegacy?: (uniques: string[]) => Promise<Observable<any[]>>;
 }