yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensures all instances of SqlCeEngine are in a using claus so native objects are disposed properly

Browse Source
This commit is contained in:
Shannon
2016-07-06 09:37:52 +02:00
parent b1b5352e26
commit ee27264a72
7 changed files with 31 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/SQLCE4Umbraco/SqlCEHelper.cs
View File

@@ -40,15 +40,10 @@ namespace SqlCE4Umbraco
var localConnection = new SqlCeConnection(ConnectionString);
if (!System.IO.File.Exists(ReplaceDataDirectory(localConnection.Database)))
{
var sqlCeEngine = new SqlCeEngine(ConnectionString);
sqlCeEngine.CreateDatabase();
// SD: Pretty sure this should be in a using clause but i don't want to cause unknown side-effects here
// since it's been like this for quite some time
//using (var sqlCeEngine = new SqlCeEngine(ConnectionString))
//{
// sqlCeEngine.CreateDatabase();
//}
using (var sqlCeEngine = new SqlCeEngine(ConnectionString))
{
sqlCeEngine.CreateDatabase();
}
}
}