yv01p/Umbraco-CMS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor all usages of SqlHelper, ExecuteReader and ExecuteXmlReader into using blocks

Browse Source
This commit is contained in:
Sebastiaan Janssen
2016-11-25 22:18:35 +01:00
parent 47c8e6854e
commit ee3a4614c3
78 changed files with 2143 additions and 1684 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/umbraco.editorControls/DefaultDataKeyValue.cs
View File

@@ -1,5 +1,6 @@
using System;
using System.Linq;
using umbraco.BusinessLogic;
using Umbraco.Core.Logging;
namespace umbraco.editorControls
@@ -27,16 +28,16 @@ namespace umbraco.editorControls
// Don't query if there's nothing to query for..
if (string.IsNullOrWhiteSpace(Value.ToString()) == false)
{
var dr = SqlHelper.ExecuteReader(string.Format("Select [value] from cmsDataTypeprevalues where id in ({0})", SqlHelper.EscapeString(Value.ToString())));
while (dr.Read())
using (var sqlHelper = Application.SqlHelper)
using (var dr = sqlHelper.ExecuteReader(string.Format("Select [value] from cmsDataTypeprevalues where id in ({0})", sqlHelper.EscapeString(Value.ToString()))))
{
value += value.Length == 0
? dr.GetString("value")
: string.Format(",{0}", dr.GetString("value"));
while (dr.Read())
{
value += value.Length == 0
? dr.GetString("value")
: string.Format(",{0}", dr.GetString("value"));
}
}
dr.Close();
}
}
catch (Exception ex)