From ef40ecfefdc39addb34a0045761d39430451a8a8 Mon Sep 17 00:00:00 2001 From: Jeavon Date: Wed, 1 Nov 2017 12:34:24 +0000 Subject: [PATCH] Fix U4-10618 - AbstractConfigCheck SuccessMessages are missing CurrentValue --- .../HealthCheck/Checks/Config/AbstractConfigCheck.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs b/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs index 004a81abc8..da74465703 100644 --- a/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs +++ b/src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs @@ -139,7 +139,7 @@ namespace Umbraco.Web.HealthCheck.Checks.Config public override IEnumerable GetStatus() { - var successMessage = string.Format(CheckSuccessMessage, FileName, XPath, Values, CurrentValue); + var successMessage = string.Format(CheckSuccessMessage, FileName, XPath, Values); var configValue = _configurationService.GetConfigurationValue(); if (configValue.Success == false) @@ -155,6 +155,9 @@ namespace Umbraco.Web.HealthCheck.Checks.Config CurrentValue = configValue.Result; + // need to update the successMessage with the CurrentValue + successMessage = string.Format(CheckSuccessMessage, FileName, XPath, Values, CurrentValue); + var valueFound = Values.Any(value => string.Equals(CurrentValue, value.Value, StringComparison.InvariantCultureIgnoreCase)); if (ValueComparisonType == ValueComparisonType.ShouldEqual && valueFound || ValueComparisonType == ValueComparisonType.ShouldNotEqual && valueFound == false) {